nitpicks

Author: BlueWitherer

CMakeLists.txt

@@ -15,10 +15,6 @@ add_library(${PROJECT_NAME} SHARED ${SOURCES})
 
 target_include_directories(${PROJECT_NAME} PRIVATE include src)
 
-if(PROJECT_IS_TOP_LEVEL)
-    target_compile_definitions(${PROJECT_NAME} PRIVATE BRKD_HORRIBLE_API_EXPORTING)
-endif()
-
 if(NOT DEFINED ENV{GEODE_SDK})
     message(FATAL_ERROR "Unable to find Geode SDK! Please define GEODE_SDK environment variable to point to Geode")
 else()

include/horrible/DLL.hpp

@@ -1,13 +1,13 @@
 #pragma once
 
 #ifdef GEODE_IS_WINDOWS
-#ifdef BRKD_HORRIBLE_API_EXPORTING
+#ifdef HorribleMenu_EXPORTS
 #define BRKD_HORRIBLE_API_DLL __declspec(dllexport)
 #else
 #define BRKD_HORRIBLE_API_DLL __declspec(dllimport)
 #endif
 #else
-#ifdef BRKD_HORRIBLE_API_EXPORTING
+#ifdef HorribleMenu_EXPORTS
 #define BRKD_HORRIBLE_API_DLL __attribute__((visibility("default")))
 #else
 #define BRKD_HORRIBLE_API_DLL

src/hooks/Gambler.cpp

@@ -26,10 +26,8 @@ class $modify(GamblerPlayLayer, PlayLayer) {
     bool init(GJGameLevel* level, bool useReplay, bool dontCreateObjects) {
         if (!PlayLayer::init(level, useReplay, dontCreateObjects)) return false;
 
-        auto f = m_fields.self();
-
         // check every frame so we can detect each percentage change
-        if (!f->triggered) schedule(schedule_selector(GamblerPlayLayer::gamblerCheck), 0.f);
+        if (!m_fields->triggered) schedule(schedule_selector(GamblerPlayLayer::gamblerCheck), 0.f);
 
         return true;
     };

src/hooks/Mock.cpp

@@ -29,13 +29,11 @@ class $modify(MockMenuLayer, MenuLayer) {
     bool init() {
         if (!MenuLayer::init()) return false;
 
-        auto f = m_fields.self();
-
         // show a lazysprite for the first png found in the save dir
         auto rnd = rng::fast();
         log::trace("mock chance {}", rnd);
 
-        if (rnd <= f->chance) {
+        if (rnd <= m_fields->chance) {
             auto const mockConfigPath = fmt::format("{}\\mock.json", mod->getSaveDir());
             auto const mockConfig = file::readJson(fs::path(mockConfigPath));
 

src/hooks/OnIce.cpp

@@ -20,8 +20,7 @@ class $modify(OnIcePlayerObject, PlayerObject) {
     HORRIBLE_DELEGATE_HOOKS(THIS_ID);
 
     void update(float p0) {
-        // make the player always on ice. yea this is it xD
-        m_isOnIce = true;
         PlayerObject::update(p0);
+        m_isOnIce = true;  // make the player always on ice. yea this is it xD
     };
 };

src/hooks/Parry.cpp

@@ -1,6 +1,6 @@
 #include <Utils.h>
 
-#include <Geode/Geode.hpp>
+// #include <Geode/Geode.hpp>
 
 // #include <Geode/modify/PlayLayer.hpp>
 // #include <Geode/modify/PlayerObject.hpp>

src/hooks/Sticky.cpp

@@ -61,13 +61,11 @@ class $modify(StickyPlayerObject, PlayerObject) {
 
     void stickyCol1() {
         auto f = m_fields.self();
-
         if (f->m_clickLabel) f->m_clickLabel->setColor(colors::yellow);
     };
 
     void stickyCol2() {
         auto f = m_fields.self();
-
         if (f->m_clickLabel) f->m_clickLabel->setColor(colors::white);
     };