@@ -27,8 +27,7 @@ void filterOptionsByTier(ScrollLayer* optionsScrollLayer, const std::vector<Opti
2727 {
2828 optionsScrollLayer->m_contentLayer ->getScaledContentWidth (),
2929 32 .f
30- },
31- id, name, desc, silly, restart
30+ }, id, name, desc, silly, restart
3231 )) optionsScrollLayer->m_contentLayer ->addChild (modOption);
3332 };
3433 };
@@ -49,6 +48,7 @@ bool HorribleMenuPopup::setup() {
4948 optionScrollBg->setPosition ({ mainLayerSize.width / 2 .f - 80 .f , mainLayerSize.height / 2 .f - 10 .f });
5049 optionScrollBg->setContentSize ({ mainLayerSize.width / 1 .5f - 25 .f , mainLayerSize.height - 45 .f });
5150 optionScrollBg->setOpacity (50 );
51+
5252 m_mainLayer->addChild (optionScrollBg);
5353
5454 // add a list button background
@@ -57,6 +57,7 @@ bool HorribleMenuPopup::setup() {
5757 listBtnBg->setPosition ({ mainLayerSize.width - (mainLayerSize.width / 2 .f - 25 .f ) + 115 .f , mainLayerSize.height / 2 .f - 10 .f });
5858 listBtnBg->setContentSize ({ mainLayerSize.width / 3 .f , mainLayerSize.height - 45 .f });
5959 listBtnBg->setOpacity (50 );
60+
6061 m_mainLayer->addChild (listBtnBg);
6162
6263 // filter buttons :o
@@ -77,18 +78,20 @@ bool HorribleMenuPopup::setup() {
7778
7879 float btnY = 0 .f ;
7980 for (const auto & btn : btns) {
80- auto normalBS = ButtonSprite::create (btn.label , 0 , false , " bigFont.fnt" , " GJ_button_01.png" , 0 , 0 .8f );
81- if (normalBS && normalBS->m_label ) {
81+ if (auto normalBS = ButtonSprite::create (btn.label , 0 , false , " bigFont.fnt" , " GJ_button_01.png" , 0 , 0 .8f )) {
8282 normalBS->m_label ->setColor (btn.color );
8383 normalBS->setScale (.8f );
84- }
8584
86- auto filterBtn = CCMenuItemSpriteExtra::create (normalBS, this , menu_selector (HorribleMenuPopup::filterTierCallback));
87- filterBtn->setTag (static_cast <int >(btn.tier ));
88- filterBtn->setPosition ({ 0 .f , btnY });
89- filterMenu->addChild (filterBtn);
90- btnY -= 40 .f ;
91- }
85+ auto filterBtn = CCMenuItemSpriteExtra::create (normalBS, this , menu_selector (HorribleMenuPopup::filterTierCallback));
86+ filterBtn->setTag (static_cast <int >(btn.tier ));
87+ filterBtn->setPosition ({ 0 .f , btnY });
88+ filterMenu->addChild (filterBtn);
89+
90+ btnY -= 40 .f ;
91+ } else {
92+ log::error (" Failed to create filter button sprite" );
93+ };
94+ };
9295
9396 m_mainLayer->addChild (filterMenu);
9497
@@ -120,12 +123,14 @@ bool HorribleMenuPopup::setup() {
120123 CircleBaseColor::Green,
121124 CircleBaseSize::Medium);
122125 modSettingsBtnSprite->setScale (0 .75f );
126+
123127 auto modSettingsBtn = CCMenuItemSpriteExtra::create (
124128 modSettingsBtnSprite,
125129 this ,
126130 menu_selector (HorribleMenuPopup::openModSettings));
127131 modSettingsMenu->setPosition ({ 0 .f , 0 .f });
128132 modSettingsMenu->addChild (modSettingsBtn);
133+
129134 m_mainLayer->addChild (modSettingsMenu);
130135
131136 auto safeModeLabel = CCLabelBMFont::create (" Safe Mode: INACTIVE" , " bigFont.fnt" );
@@ -143,21 +148,22 @@ bool HorribleMenuPopup::setup() {
143148 };
144149
145150 m_mainLayer->addChild (safeModeLabel, 100 );
151+
146152 return true ;
147- }
153+ };
148154
149155void HorribleMenuPopup::filterTierCallback (CCObject* sender) {
150156 auto filterBtn = typeinfo_cast<CCMenuItemSpriteExtra*>(sender);
151- if (!filterBtn)
152- return ;
157+ if (!filterBtn) return ;
158+
153159 SillyTier tier = static_cast <SillyTier>(filterBtn->getTag ());
154160
155161 // Toggle: clicking same button disables filter
156162 if (s_selectedTier == tier) {
157163 s_selectedTier = SillyTier::None;
158164 } else {
159165 s_selectedTier = tier;
160- }
166+ };
161167
162168 // Find scroll layer and options
163169 auto optionsScrollLayer = static_cast <ScrollLayer*>(m_mainLayer->getChildByID (" scrollLayer" ));
0 commit comments