Skip to content

Containment command fails #215

Description

@nmoore-mdsol

Recently activated a second profile, so I don't know if this is related or not.

when attempting to contain a host via CLI, errors would pop up.

User confirmed action
Changing the network containment status on a batch of systems...Traceback (most recent call last):
  File "/Users/user/.local/bin/falcon", line 8, in <module>
    sys.exit(cli())
             ~~~^^
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/click/core.py", line 1442, in __call__
    return self.main(*args, **kwargs)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/click/core.py", line 1363, in main
    rv = self.invoke(ctx)
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/click/core.py", line 1830, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/click/core.py", line 1830, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/click/core.py", line 1226, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/click/core.py", line 794, in invoke
    return callback(*args, **kwargs)
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/click/decorators.py", line 34, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/falcon_toolkit/containment/cli.py", line 190, in contain
    perform_containment_action(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^
        device_ids=device_ids,
        ^^^^^^^^^^^^^^^^^^^^^^
        client=client,
        ^^^^^^^^^^^^^^
        action="contain",
        ^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Users/user/.local/pipx/venvs/falcon-toolkit/lib/python3.13/site-packages/falcon_toolkit/containment/perform_containment.py", line 137, in perform_containment_action
    ids=device_ids[i : i + limit],
        ~~~~~~~~~~^^^^^^^^^^^^^^^
TypeError: 'set' object is not subscriptable

Ended up adding this: device_ids = list(device_ids) to the perform_containment.py script at line 120 to try and work around it.

Testing seems to work. wasn't sure if anyone else would benefit.

Metadata

Metadata

Labels

🐛 bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions