Skip to content

Update Packages workflow has been failing daily: DisableTls removed from ChronicleConnectionString #48

Description

@woksin

Describe the bug

The scheduled Update Packages workflow has failed every run since at least 24 July. It is not flaky — the CLI no longer compiles against current Cratis.Chronicle.Connections, so the daily dependency bump can never land.

The repository is pinned at 16.0.6. 16.9.1 is current.

Steps to reproduce

  1. Bump Cratis.Chronicle.* in Directory.Packages.props to 16.9.1.
  2. dotnet build -c Release.

Actual behavior

error CS1061: 'ChronicleConnectionString' does not contain a definition for 'DisableTls'
  Source/Cli/Commands/Chronicle/CliChronicleConnection.cs(61,34)
  Source/Cli/Commands/Chronicle/CliChronicleConnection.cs(132,30)
  Source/Cli/Commands/Chronicle/Auth/LoginCommand.cs(47,47)

Additional context

ChronicleConnectionString.DisableTls has been removed and SkipTlsValidation added. These are not the same property and this is not a rename:

  • DisableTls — do not use TLS at all.
  • SkipTlsValidation — use TLS, but do not validate the certificate. The docs on the new type say validation is skipped by default so a development client can reach the self-signed certificate the server generates.

That matches the direction of Chronicle 16, where TLS is effectively required. So the three call sites need deciding rather than mechanically substituting:

Site Current use Question
CliChronicleConnection.cs:61 passed to ChronicleConnection does the ctor still take a disable-TLS flag, or has it moved to SkipTlsValidation?
CliChronicleConnection.cs:132 passed to OAuthTokenProvider same
LoginCommand.cs:47 picks http vs https for the /connect/token endpoint if TLS can no longer be disabled, this should be https unconditionally

The third is the one with user-visible consequence: it currently builds a plaintext token endpoint whenever disableTls=true appears in a connection string.

Worth confirming which release dropped it, so the bump can be taken deliberately rather than by the scheduled job.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions