placement_test.go

// SPDX-License-Identifier: Apache-2.0

package git

import (
	"context"
	"os"
	"path/filepath"
	"strings"
	"testing"

	gogit "github.com/go-git/go-git/v6"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"

	v1alpha3 "github.com/ConfigButler/gitops-reverser/api/v1alpha3"
	"github.com/ConfigButler/gitops-reverser/internal/manifestanalyzer"
	"github.com/ConfigButler/gitops-reverser/internal/types"
)

// newConfigMapEvent builds a CREATE event for a new ConfigMap with no existing
// document anywhere in the fixture — the only case new-file placement runs for.
func newConfigMapEvent(name, namespace string) Event {
	return Event{
		Object: &unstructured.Unstructured{Object: map[string]interface{}{
			"apiVersion": "v1",
			"kind":       "ConfigMap",
			"metadata":   map[string]interface{}{"name": name, "namespace": namespace},
			"data":       map[string]interface{}{"color": "blue"},
		}},
		Identifier: types.NewResourceIdentifier("", "v1", "configmaps", namespace, name),
		Operation:  "CREATE",
	}
}

func applyEventsWithPolicy(
	t *testing.T,
	worktree *gogit.Worktree,
	policy *manifestanalyzer.PlacementPolicy,
	events ...Event,
) bool {
	t.Helper()
	w := &BranchWorker{contentWriter: newContentWriter(types.SensitiveResourcePolicy{}), mapper: configMapMapper()}
	changed, err := w.flushEventsToWorktree(
		context.Background(),
		worktree,
		"",
		events,
		policy,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)
	require.NoError(t, err)
	return changed
}

func TestPlacement_DeclaredPolicy_NewFile(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()
	policy := &manifestanalyzer.PlacementPolicy{
		ByType: map[string]string{"v1/configmaps": "{namespace}/configmaps.yaml"},
	}

	changed := applyEventsWithPolicy(t, worktree, policy, newConfigMapEvent("cache", "app"))
	require.True(t, changed)

	got, err := os.ReadFile(filepath.Join(root, "app", "configmaps.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(got), "name: cache")
	assert.Contains(t, string(got), "color: blue")
}

// The write path's half of the Option C deletion: an existing document of the same type
// in the same namespace no longer attracts the new file. The folder here has no
// kustomization, so there is no structural root either, and the resource lands at the
// built-in path — where a human can see it, and where one `placement.byType` line moves
// it if the repository wants it in the overlay.
func TestPlacement_ExistingSiblingFile_DoesNotAttractTheNewFile(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()
	seedPlacedManifest(t, worktree, "overlays/test/configmap-existing.yaml",
		"apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: existing\n  namespace: podinfo-test\ndata:\n  k: v\n")

	changed := applyEventsWithPolicy(t, worktree, nil, newConfigMapEvent("cache", "podinfo-test"))
	require.True(t, changed)

	got, err := os.ReadFile(filepath.Join(root, "podinfo-test/configmaps/cache.yaml"))
	require.NoError(t, err, "the new file must land at the built-in path")
	assert.Contains(t, string(got), "name: cache")

	_, statErr := os.Stat(filepath.Join(root, "overlays/test/cache.yaml"))
	assert.True(t, os.IsNotExist(statErr), "the sibling's directory must not be inferred as the destination")
}

// Appending to a bundle is still supported — it is now reached by DECLARING the bundle
// rather than by the writer noticing one. The append machinery itself (splice one
// document, leave every other byte alone) is unchanged, and this is what pins it.
func TestPlacement_DeclaredBundle_AppendsToExistingMultiDocFile(t *testing.T) {
	worktree := newWorktreeForTest(t)
	seeded := "apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: a\n  namespace: app\ndata:\n  k: v\n" +
		"---\n" +
		"apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: b\n  namespace: app\ndata:\n  k: v\n"
	full := seedPlacedManifest(t, worktree, "all.yaml", seeded)
	policy := &manifestanalyzer.PlacementPolicy{
		ByType: map[string]string{"v1/configmaps": "all.yaml"},
	}

	changed := applyEventsWithPolicy(t, worktree, policy, newConfigMapEvent("cache", "app"))
	require.True(t, changed)

	got, err := os.ReadFile(full)
	require.NoError(t, err)
	assert.Contains(t, string(got), "name: a", "the first existing document must survive")
	assert.Contains(t, string(got), "name: b", "the second existing document must survive")
	assert.Contains(t, string(got), "name: cache", "the new document must be appended")
	assert.Equal(t, 3, strings.Count(string(got), "kind: ConfigMap"),
		"exactly one document must be added, not a replace")
}

// A declared destination inside a kustomize context must not write metadata.namespace:
// the kustomization's namespace: transformer supplies it, and repeating it would break the
// "no namespace: in this file" convention every other document in the bundle follows. The
// rule to omit it used to come from reading the siblings' bytes; it now comes from the
// governing kustomization, which is the thing that actually decides the rendered namespace.
func TestPlacement_DeclaredBundle_OmitsNamespaceInKustomizeContext(t *testing.T) {
	worktree := newWorktreeForTest(t)
	kustYAML := "namespace: app\nresources:\n  - all.yaml\n"
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml", kustYAML)
	seeded := "apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: a\ndata:\n  k: v\n" +
		"---\n" +
		"apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: b\ndata:\n  k: v\n"
	full := seedPlacedManifest(t, worktree, "overlays/test/all.yaml", seeded)
	policy := &manifestanalyzer.PlacementPolicy{
		ByType: map[string]string{"v1/configmaps": "overlays/test/all.yaml"},
	}

	changed := applyEventsWithPolicy(t, worktree, policy, newConfigMapEvent("cache", "app"))
	require.True(t, changed)

	got, err := os.ReadFile(full)
	require.NoError(t, err)
	assert.Contains(t, string(got), "name: a", "the first existing document must survive")
	assert.Contains(t, string(got), "name: b", "the second existing document must survive")
	assert.Contains(t, string(got), "name: cache", "the new document must be appended")
	assert.NotContains(t, string(got), "namespace:",
		"the new document must not break the bundle's namespace-omitted convention")
}

// A misconfigured declared template (missing {name}) makes two distinct secrets
// collide on the same rendered path. createNew must skip the write rather than
// crash or corrupt the existing file — the next event or resync retries once the
// policy is fixed.
func TestPlacement_SensitiveCollision_SkipsWithoutCrashing(t *testing.T) {
	worktree := newWorktreeForTest(t)
	existing := "apiVersion: v1\nkind: Secret\nmetadata:\n  name: other\n  namespace: app\nsops:\n  version: \"3\"\n"
	full := seedPlacedManifest(t, worktree, "secrets/app.sops.yaml", existing)
	policy := &manifestanalyzer.PlacementPolicy{
		ByType: map[string]string{"v1/secrets": "secrets/{namespace}.sops.yaml"},
	}

	event := Event{
		Object: &unstructured.Unstructured{Object: map[string]interface{}{
			"apiVersion": "v1",
			"kind":       "Secret",
			"metadata":   map[string]interface{}{"name": "api-token", "namespace": "app"},
		}},
		Identifier: types.NewResourceIdentifier("", "v1", "secrets", "app", "api-token"),
		Operation:  "CREATE",
	}
	w := &BranchWorker{contentWriter: newContentWriter(types.SensitiveResourcePolicy{})}
	changed, err := w.flushEventsToWorktree(
		context.Background(),
		worktree,
		"",
		[]Event{event},
		policy,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)

	require.NoError(t, err, "a placement conflict must be skipped, not returned as a batch error")
	assert.False(t, changed, "no file should be written when placement cannot be resolved safely")

	got, readErr := os.ReadFile(full)
	require.NoError(t, readErr)
	assert.Equal(t, existing, string(got), "the existing secret must survive byte-for-byte")
}

func TestPlacement_KustomizeEntryAppended_SameCommit(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()
	kustYAML := "# overlay for test\n" +
		"namespace: podinfo-test\n" +
		"resources:\n" +
		"  - deployment.yaml\n"
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml", kustYAML)
	seedPlacedManifest(t, worktree, "overlays/test/deployment.yaml",
		"apiVersion: apps/v1\nkind: Deployment\nmetadata:\n  name: web\n  namespace: podinfo-test\n")

	changed := applyEventsWithPolicy(t, worktree, nil, newConfigMapEvent("debug-toolbox", "podinfo-test"))
	require.True(t, changed)

	newFile, err := os.ReadFile(filepath.Join(root, "overlays/test/debug-toolbox.yaml"))
	require.NoError(t, err, "the new resource should land inside the overlay directory")
	assert.Contains(t, string(newFile), "name: debug-toolbox")

	kust, err := os.ReadFile(filepath.Join(root, "overlays/test/kustomization.yaml"))
	require.NoError(t, err)
	kustStr := string(kust)
	assert.Contains(t, kustStr, "# overlay for test", "hand-authored comments must survive")
	assert.Contains(t, kustStr, "- deployment.yaml", "the existing entry must survive")
	assert.Contains(t, kustStr, "- debug-toolbox.yaml", "the new file must be added to resources:")
}

func TestPlacement_KustomizeEntryIdempotent_OnRepeatedApply(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()
	kustYAML := "namespace: podinfo-test\nresources:\n  - deployment.yaml\n"
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml", kustYAML)
	seedPlacedManifest(t, worktree, "overlays/test/deployment.yaml",
		"apiVersion: apps/v1\nkind: Deployment\nmetadata:\n  name: web\n  namespace: podinfo-test\n")

	event := newConfigMapEvent("debug-toolbox", "podinfo-test")
	require.True(t, applyEventsWithPolicy(t, worktree, nil, event))
	// A second apply of the same create (e.g. a resync re-observing the same live
	// object) must not duplicate the resources: entry.
	applyEventsWithPolicy(t, worktree, nil, event)

	kust, err := os.ReadFile(filepath.Join(root, "overlays/test/kustomization.yaml"))
	require.NoError(t, err)
	assert.Equal(t, 1, strings.Count(string(kust), "debug-toolbox.yaml"),
		"the resources: entry must appear exactly once")
}

// A kustomization with no resources: sequence to append to is still accepted — so
// the writer must place the resource's own file, while the resources: entry add is
// skipped rather than inventing the key, leaving the kustomization exactly as it
// was for a human to complete.
func TestPlacement_KustomizeEntryAppendSkipped_NoResourcesSequence(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()
	kustYAML := "namespace: app\n"
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml", kustYAML)

	changed := applyEventsWithPolicy(t, worktree, nil, newConfigMapEvent("cache", "app"))
	require.True(t, changed, "the new resource's own file must still be written")

	_, err := os.Stat(filepath.Join(root, "overlays/test/cache.yaml"))
	require.NoError(t, err, "the resource itself is written even though the kustomize entry could not be added")

	kust, err := os.ReadFile(filepath.Join(root, "overlays/test/kustomization.yaml"))
	require.NoError(t, err)
	// Byte-exact, not YAMLEq: the guarantee under test is that a skipped edit
	// returns the original content untouched, not merely a semantically
	// equivalent one.
	assert.Equal(t, kustYAML, string(kust), //nolint:testifylint
		"a kustomization with no resources: sequence must be left untouched, not corrupted")
}

// A kustomization kustomize itself cannot decode (here resources: is not a
// sequence, which fails `kustomize build` outright) refuses the folder rather than
// being tolerated. Before the analyzer used kustomize's own type this file was
// accepted — only specific disallowed *keys* disqualified a kustomization, never
// its shape — so the operator would happily write into a folder that no GitOps
// controller could render.
func TestPlacement_UndecodableKustomization_RefusesTheFlush(t *testing.T) {
	worktree := newWorktreeForTest(t)
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml", "namespace: app\nresources: not-a-list\n")

	w := &BranchWorker{contentWriter: newContentWriter(types.SensitiveResourcePolicy{}), mapper: configMapMapper()}
	_, err := w.flushEventsToWorktree(
		context.Background(),
		worktree,
		"",
		[]Event{newConfigMapEvent("cache", "app")},
		nil,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)
	require.Error(t, err, "a kustomization kustomize cannot build must refuse the folder, not be written into")
}

// TestPlacement_ExternalBaseOverlay_NewObject proves render-root scoping's WRITE half for a
// brand-new object: a GitTarget rooted at an overlay that reads ../../base gains a new
// ConfigMap. The file must land inside the overlay (never the read-only base), the overlay's
// kustomization must gain the resources: entry so kustomize renders it, the base must be left
// byte-for-byte untouched, and the render oracle must accept the flush — kustomize builds the
// new object through the re-rooted scope. This is the "New object -> overlay-local file plus
// resources: entry" row of render-root-scoping.md §4.
func TestPlacement_ExternalBaseOverlay_NewObject(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()

	// The read-only base, outside the overlay's own subtree.
	seedPlacedManifest(t, worktree, "base/kustomization.yaml", "resources:\n  - deployment.yaml\n")
	seedPlacedManifest(t, worktree, "base/deployment.yaml",
		"apiVersion: apps/v1\nkind: Deployment\nmetadata:\n  name: web\n")
	// The overlay GitTarget reaches ../../base and sets the namespace transformer.
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml",
		"namespace: podinfo-test\nresources:\n  - ../../base\n")
	baseKustBefore, err := os.ReadFile(filepath.Join(root, "base/kustomization.yaml"))
	require.NoError(t, err)

	w := &BranchWorker{contentWriter: newContentWriter(types.SensitiveResourcePolicy{}), mapper: configMapMapper()}
	changed, err := w.flushEventsToWorktree(
		context.Background(), worktree, "overlays/test",
		[]Event{newConfigMapEvent("cache", "podinfo-test")}, nil, namespacePolicy{}, v1alpha3.PruneOnEvent,
	)
	require.NoError(t, err, "the overlay new-object flush must pass the render oracle")
	require.True(t, changed)

	// The new object lands inside the overlay, not the base.
	newFile, err := os.ReadFile(filepath.Join(root, "overlays/test/cache.yaml"))
	require.NoError(t, err, "the new resource must land inside the overlay directory")
	assert.Contains(t, string(newFile), "name: cache")

	// The overlay kustomization gains the resources: entry so kustomize renders it.
	kust, err := os.ReadFile(filepath.Join(root, "overlays/test/kustomization.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(kust), "- ../../base", "the base reference must survive")
	assert.Contains(t, string(kust), "cache.yaml", "the new file must be registered in the overlay's resources:")

	// The read-only base is never written into.
	_, statErr := os.Stat(filepath.Join(root, "base/cache.yaml"))
	assert.True(t, os.IsNotExist(statErr), "nothing may be written into the read-only base")
	baseKustAfter, err := os.ReadFile(filepath.Join(root, "base/kustomization.yaml"))
	require.NoError(t, err)
	assert.Equal(t, string(baseKustBefore), string(baseKustAfter),
		"the base kustomization must be untouched")
}

// overlayBaseDeploymentWorktree seeds an external-base overlay whose base declares one
// Deployment, and returns the worktree. The overlay reaches ../../base and sets the namespace.
func overlayBaseDeploymentWorktree(t *testing.T, baseImage string, baseReplicas string) *gogit.Worktree {
	t.Helper()
	worktree := newWorktreeForTest(t)
	seedPlacedManifest(t, worktree, "base/kustomization.yaml", "resources:\n  - deployment.yaml\n")
	dep := "apiVersion: apps/v1\nkind: Deployment\nmetadata:\n  name: web\n  namespace: podinfo-test\nspec:\n"
	if baseReplicas != "" {
		dep += "  replicas: " + baseReplicas + "\n"
	}
	dep += "  template:\n    spec:\n      containers:\n        - name: app\n          image: " + baseImage + "\n"
	seedPlacedManifest(t, worktree, "base/deployment.yaml", dep)
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml",
		"namespace: podinfo-test\nresources:\n  - ../../base\n")
	return worktree
}

func liveDeployment(image string, replicas int64) Event {
	spec := map[string]interface{}{
		"template": map[string]interface{}{"spec": map[string]interface{}{
			"containers": []interface{}{map[string]interface{}{"name": "app", "image": image}}}},
	}
	if replicas >= 0 {
		spec["replicas"] = replicas
	}
	return Event{
		Object: &unstructured.Unstructured{Object: map[string]interface{}{
			"apiVersion": "apps/v1", "kind": "Deployment",
			"metadata": map[string]interface{}{"name": "web", "namespace": "podinfo-test"},
			"spec":     spec,
		}},
		Identifier: types.NewResourceIdentifier("apps", "v1", "deployments", "podinfo-test", "web"),
		Operation:  "UPDATE",
	}
}

func flushOverlayDeployment(t *testing.T, worktree *gogit.Worktree, event Event) error {
	t.Helper()
	w := &BranchWorker{contentWriter: newContentWriter(types.SensitiveResourcePolicy{}), mapper: deploymentMapper()}
	_, err := w.flushEventsToWorktree(
		context.Background(),
		worktree,
		"overlays/test",
		[]Event{event},
		nil,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)
	return err
}

// TestOverlayAuthors_ImageEntry_ForBaseSuppliedImage is the flagship of "edit a specific
// environment and the override is authored for you": bumping a base-rendered Deployment's image
// in an overlay authors a new images: entry in the overlay's OWN kustomization (never the base),
// verified by the re-render oracle. Before this the flush was refused for escaping the write jail.
func TestOverlayAuthors_ImageEntry_ForBaseSuppliedImage(t *testing.T) {
	worktree := overlayBaseDeploymentWorktree(t, "nginx:1.0", "")
	root := worktree.Filesystem().Root()

	require.NoError(t, flushOverlayDeployment(t, worktree, liveDeployment("nginx:2.0", -1)),
		"an image bump must be authored as an overlay images: entry, not refused")

	kust, err := os.ReadFile(filepath.Join(root, "overlays/test/kustomization.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(kust), "images:", "the overlay must gain an images: section")
	assert.Contains(t, string(kust), "name: nginx", "the entry names the base image")
	assert.Contains(t, string(kust), "newTag: \"2.0\"", "the entry carries the new tag")

	base, err := os.ReadFile(filepath.Join(root, "base/deployment.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(base), "image: nginx:1.0", "the read-only base image must be untouched")
}

// TestOverlayAuthors_ReplicaEntry_ForBaseSuppliedCount scales a base-rendered Deployment in an
// overlay: the overlay authors a replicas: entry over the base's count, base untouched.
func TestOverlayAuthors_ReplicaEntry_ForBaseSuppliedCount(t *testing.T) {
	worktree := overlayBaseDeploymentWorktree(t, "nginx:1.0", "2")
	root := worktree.Filesystem().Root()

	require.NoError(t, flushOverlayDeployment(t, worktree, liveDeployment("nginx:1.0", 5)),
		"a scale must be authored as an overlay replicas: entry, not refused")

	kust, err := os.ReadFile(filepath.Join(root, "overlays/test/kustomization.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(kust), "replicas:", "the overlay must gain a replicas: section")
	assert.Contains(t, string(kust), "name: web", "the entry names the resource")
	assert.Contains(t, string(kust), "count: 5", "the entry carries the new count")

	base, err := os.ReadFile(filepath.Join(root, "base/deployment.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(base), "replicas: 2", "the read-only base replica count must be untouched")
}

// TestOverlayAuthors_Idempotent_OnResync re-observes the same live image after the entry was
// authored: the store now sees the entry, so the change routes to it (no duplicate entry).
func TestOverlayAuthors_Idempotent_OnResync(t *testing.T) {
	worktree := overlayBaseDeploymentWorktree(t, "nginx:1.0", "")
	root := worktree.Filesystem().Root()

	require.NoError(t, flushOverlayDeployment(t, worktree, liveDeployment("nginx:2.0", -1)))
	// A second flush of the same live state must not append a second entry.
	require.NoError(t, flushOverlayDeployment(t, worktree, liveDeployment("nginx:2.0", -1)))

	kust, err := os.ReadFile(filepath.Join(root, "overlays/test/kustomization.yaml"))
	require.NoError(t, err)
	assert.Equal(t, 1, strings.Count(string(kust), "name: nginx"),
		"the authored images: entry must appear exactly once")
}

// TestOverlayAuthors_DeletePatch_ForInheritedObject deletes an object the overlay inherits from
// its base: the writer authors a $patch: delete in the overlay (file + patches: entry), the
// re-render oracle proves the object leaves the render, and the read-only base is untouched.
func TestOverlayAuthors_DeletePatch_ForInheritedObject(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()
	seedPlacedManifest(t, worktree, "base/kustomization.yaml", "resources:\n  - cm.yaml\n")
	seedPlacedManifest(t, worktree, "base/cm.yaml",
		"apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: shared\n  namespace: podinfo-test\ndata:\n  k: v\n")
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml",
		"namespace: podinfo-test\nresources:\n  - ../../base\n")

	del := Event{
		Object: &unstructured.Unstructured{Object: map[string]interface{}{
			"apiVersion": "v1", "kind": "ConfigMap",
			"metadata": map[string]interface{}{"name": "shared", "namespace": "podinfo-test"}}},
		Identifier: types.NewResourceIdentifier("", "v1", "configmaps", "podinfo-test", "shared"),
		Operation:  "DELETE",
	}
	w := &BranchWorker{contentWriter: newContentWriter(types.SensitiveResourcePolicy{}), mapper: configMapMapper()}
	_, err := w.flushEventsToWorktree(
		context.Background(),
		worktree,
		"overlays/test",
		[]Event{del},
		nil,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)
	require.NoError(t, err, "deleting an inherited object must author a $patch: delete, not refuse")

	patch, err := os.ReadFile(filepath.Join(root, "overlays/test/configmap-shared-delete.yaml"))
	require.NoError(t, err, "the overlay must gain a $patch: delete file")
	assert.Contains(t, string(patch), "$patch: delete")
	assert.Contains(t, string(patch), "name: shared")

	kust, err := os.ReadFile(filepath.Join(root, "overlays/test/kustomization.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(kust), "patches:")
	assert.Contains(t, string(kust), "configmap-shared-delete.yaml")

	base, err := os.ReadFile(filepath.Join(root, "base/cm.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(base), "name: shared", "the read-only base object must be untouched")
}

// TestOverlayAuthors_DeletePatch_RefusesOnPathCollision proves the delete-patch author never
// clobbers an unrelated file that happens to occupy the deterministic patch path: the batch is
// refused and the existing file is left byte-for-byte, rather than overwritten or silently kept.
func TestOverlayAuthors_DeletePatch_RefusesOnPathCollision(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()
	seedPlacedManifest(t, worktree, "base/kustomization.yaml", "resources:\n  - cm.yaml\n")
	seedPlacedManifest(t, worktree, "base/cm.yaml",
		"apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: shared\n  namespace: podinfo-test\ndata:\n  k: v\n")
	// An unrelated overlay-local file already occupies the delete patch's deterministic path.
	collision := "apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: keepme\n  namespace: podinfo-test\ndata:\n  x: y\n"
	seedPlacedManifest(t, worktree, "overlays/test/configmap-shared-delete.yaml", collision)
	seedPlacedManifest(t, worktree, "overlays/test/kustomization.yaml",
		"namespace: podinfo-test\nresources:\n  - ../../base\n  - configmap-shared-delete.yaml\n")

	del := Event{
		Object: &unstructured.Unstructured{Object: map[string]interface{}{
			"apiVersion": "v1", "kind": "ConfigMap",
			"metadata": map[string]interface{}{"name": "shared", "namespace": "podinfo-test"}}},
		Identifier: types.NewResourceIdentifier("", "v1", "configmaps", "podinfo-test", "shared"),
		Operation:  "DELETE",
	}
	w := &BranchWorker{contentWriter: newContentWriter(types.SensitiveResourcePolicy{}), mapper: configMapMapper()}
	_, err := w.flushEventsToWorktree(
		context.Background(),
		worktree,
		"overlays/test",
		[]Event{del},
		nil,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)
	var refused *manifestanalyzer.AcceptanceRefusedError
	require.ErrorAs(t, err, &refused, "a patch-path collision refuses the batch")
	assert.True(t, refused.AllIssuesOfKinds(manifestanalyzer.IssueUnownedDeletePatch))

	got, err := os.ReadFile(filepath.Join(root, "overlays/test/configmap-shared-delete.yaml"))
	require.NoError(t, err)
	assert.Equal(t, collision, string(got), "the colliding file must be left byte-for-byte, never overwritten")
}

func newTestWriteBatch(t *testing.T) *writeBatch {
	t.Helper()
	writer := newContentWriter(types.SensitiveResourcePolicy{})
	return newWriteBatch(context.Background(), writer, nil, manifestanalyzer.FolderScan{}, nil, namespacePolicy{}, "")
}

func TestAppendYAMLDocument(t *testing.T) {
	if got := appendYAMLDocument(nil, []byte("a: 1\n")); string(got) != "a: 1\n" {
		t.Errorf("empty existing should return newDoc verbatim, got %q", got)
	}
	if got := appendYAMLDocument([]byte("a: 1"), []byte("b: 2\n")); string(got) != "a: 1\n---\nb: 2\n" {
		t.Errorf("got %q, want a newline inserted before the separator when existing lacks a trailing one", got)
	}
	if got := appendYAMLDocument([]byte("a: 1\n"), []byte("b: 2\n")); string(got) != "a: 1\n---\nb: 2\n" {
		t.Errorf("got %q, want no extra blank line when existing already ends in a newline", got)
	}
}

func TestAppendNewDocument_BuildContentErrorIsPropagated(t *testing.T) {
	wb := newTestWriteBatch(t)
	event := Event{
		Object:     nil,
		Identifier: types.NewResourceIdentifier("", "v1", "configmaps", "app", "x"),
	}

	_, err := wb.appendNewDocument(context.Background(), event, "all.yaml")

	require.Error(t, err, "a nil object cannot be marshaled, and that error must not be swallowed")
}

// If the kustomization file was removed by an earlier delete in the same batch
// (an edge case that should not happen in practice, since kustomization.yaml is
// a retained build directive, but the writer must never panic on it),
// appendKustomizationResource must no-op rather than dereference a nil buffer.
func TestAppendKustomizationResource_VanishedBuffer_NoPanic(t *testing.T) {
	wb := newTestWriteBatch(t)
	kustPath := "overlays/test/kustomization.yaml"
	wb.buffers[kustPath] = &fileBuffer{rel: kustPath, current: nil}
	placement := manifestanalyzer.PlacementResult{
		Path:          "overlays/test/new.yaml",
		Kustomization: &manifestanalyzer.KustomizationInfo{Path: kustPath, Resources: []string{"deployment.yaml"}},
	}
	event := Event{Identifier: types.NewResourceIdentifier("", "v1", "configmaps", "app", "new")}

	assert.NotPanics(t, func() {
		wb.appendKustomizationResource(context.Background(), event, placement)
	})
	assert.Nil(t, wb.buffers[kustPath].current, "a vanished buffer must not be resurrected")
}

// Two new resources that both render to the same brand-new declared path (a
// collision LocateNew cannot see coming, since it only consults the pre-batch
// store) must form one deterministic multi-document file — never silently
// overwrite one another — regardless of which event the writer processes
// first. This is the design doc's "if several new plaintext resources in one
// plan render to the same path, write a multi-document file in deterministic
// resource-identity order".
func TestPlacement_ColdBundleCollision_BothSurviveRegardlessOfOrder(t *testing.T) {
	policy := &manifestanalyzer.PlacementPolicy{Default: "all.yaml"}
	first := newConfigMapEvent("alpha", "app")
	second := newConfigMapEvent("beta", "app")

	forward := newWorktreeForTest(t)
	changed := applyEventsWithPolicy(t, forward, policy, first, second)
	require.True(t, changed)
	forwardBody, err := os.ReadFile(filepath.Join(forward.Filesystem().Root(), "all.yaml"))
	require.NoError(t, err)

	reversed := newWorktreeForTest(t)
	changed = applyEventsWithPolicy(t, reversed, policy, second, first)
	require.True(t, changed)
	reversedBody, err := os.ReadFile(filepath.Join(reversed.Filesystem().Root(), "all.yaml"))
	require.NoError(t, err)

	assert.Contains(t, string(forwardBody), "name: alpha", "the first resource must survive")
	assert.Contains(t, string(forwardBody), "name: beta", "the second resource must survive")
	assert.Equal(t, 2, strings.Count(string(forwardBody), "kind: ConfigMap"), "both must land as separate documents")
	assert.Equal(t, string(forwardBody), string(reversedBody),
		"the resulting file must not depend on event processing order")
}

// A third collision on the same batch-cold path must also survive and stay
// sorted, proving the fix generalizes beyond exactly two resources.
func TestPlacement_ColdBundleCollision_ThreeResourcesAllSurvive(t *testing.T) {
	worktree := newWorktreeForTest(t)
	policy := &manifestanalyzer.PlacementPolicy{Default: "all.yaml"}

	changed := applyEventsWithPolicy(t, worktree, policy,
		newConfigMapEvent("charlie", "app"),
		newConfigMapEvent("alpha", "app"),
		newConfigMapEvent("bravo", "app"),
	)
	require.True(t, changed)

	got, err := os.ReadFile(filepath.Join(worktree.Filesystem().Root(), "all.yaml"))
	require.NoError(t, err)
	body := string(got)
	assert.Equal(t, 3, strings.Count(body, "kind: ConfigMap"))
	// Sorted by resource identity ("…/app/alpha" < "…/app/bravo" < "…/app/charlie"),
	// independent of the arrival order above.
	assert.Less(t, strings.Index(body, "name: alpha"), strings.Index(body, "name: bravo"))
	assert.Less(t, strings.Index(body, "name: bravo"), strings.Index(body, "name: charlie"))
}

// A sensitive resource must never be merged into a shared file, even when the
// collision is with another new resource within the same batch (not a
// pre-existing file, which the analyzer-level test already covers).
func TestPlacement_ColdBundleCollision_SensitiveNeverMerged(t *testing.T) {
	worktree := newWorktreeForTest(t)
	policy := &manifestanalyzer.PlacementPolicy{
		ByType: map[string]string{"v1/secrets": "secrets/{namespace}.sops.yaml"},
	}
	newSecretEvent := func(name string) Event {
		return Event{
			Object: &unstructured.Unstructured{Object: map[string]interface{}{
				"apiVersion": "v1",
				"kind":       "Secret",
				"metadata":   map[string]interface{}{"name": name, "namespace": "app"},
			}},
			Identifier: types.NewResourceIdentifier("", "v1", "secrets", "app", name),
			Operation:  "CREATE",
		}
	}
	writer := newContentWriter(types.SensitiveResourcePolicy{})
	writer.setEncryptor(&stubEncryptor{result: []byte(
		"apiVersion: v1\nkind: Secret\nmetadata:\n  name: first\n  namespace: app\n" +
			"data:\n  k: ENC[AES256,data:x,iv:y,tag:z]\nsops:\n  version: 3.9.0\n",
	)}, "test-scope")
	w := &BranchWorker{contentWriter: writer}

	changed, err := w.flushEventsToWorktree(
		context.Background(), worktree, "", []Event{newSecretEvent("first"), newSecretEvent("second")}, policy,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)

	require.NoError(t, err)
	assert.True(t, changed, "the first secret must still be written")

	got, readErr := os.ReadFile(filepath.Join(worktree.Filesystem().Root(), "secrets/app.sops.yaml"))
	require.NoError(t, readErr)
	assert.Equal(t, 1, strings.Count(string(got), "kind: Secret"),
		"the second secret must be skipped, never merged into the first's file")
}

// A sensitive and a plaintext resource that a bundling default routes to the same
// brand-new file must never co-mingle in it, whichever event the writer processes
// first. This is the same-batch half of Option B2's write-safety guard: the single
// declared map is consulted for both classes, so a Secret and a ConfigMap can now
// resolve to one path, and the guard keeps encrypted and cleartext documents out of
// the same file (the first arrival wins; the other is skipped and retried).
func TestPlacement_ColdBundleCollision_SensitiveAndPlaintextNeverMix(t *testing.T) {
	policy := &manifestanalyzer.PlacementPolicy{Default: "all.yaml"}
	secretEvent := Event{
		Object: &unstructured.Unstructured{Object: map[string]interface{}{
			"apiVersion": "v1",
			"kind":       "Secret",
			"metadata":   map[string]interface{}{"name": "cred", "namespace": "app"},
		}},
		Identifier: types.NewResourceIdentifier("", "v1", "secrets", "app", "cred"),
		Operation:  "CREATE",
	}
	configMapEvent := newConfigMapEvent("cache", "app")

	newWriter := func() *contentWriter {
		writer := newContentWriter(types.SensitiveResourcePolicy{})
		writer.setEncryptor(&stubEncryptor{result: []byte(
			"apiVersion: v1\nkind: Secret\nmetadata:\n  name: cred\n  namespace: app\n" +
				"data:\n  k: ENC[AES256,data:x,iv:y,tag:z]\nsops:\n  version: 3.9.0\n",
		)}, "test-scope")
		return writer
	}

	// Secret first: the Secret wins the file, the ConfigMap is skipped.
	secretFirst := newWorktreeForTest(t)
	wsf := &BranchWorker{contentWriter: newWriter()}
	_, err := wsf.flushEventsToWorktree(
		context.Background(),
		secretFirst,
		"",
		[]Event{secretEvent, configMapEvent},
		policy,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)
	require.NoError(t, err)
	secretFirstBody, readErr := os.ReadFile(filepath.Join(secretFirst.Filesystem().Root(), "all.yaml"))
	require.NoError(t, readErr)
	assert.Contains(t, string(secretFirstBody), "kind: Secret")
	assert.NotContains(t, string(secretFirstBody), "kind: ConfigMap",
		"a plaintext resource must never join a file that already holds an encrypted document")

	// ConfigMap first: the ConfigMap wins the file, the Secret is skipped.
	configMapFirst := newWorktreeForTest(t)
	wcf := &BranchWorker{contentWriter: newWriter()}
	_, err = wcf.flushEventsToWorktree(
		context.Background(),
		configMapFirst,
		"",
		[]Event{configMapEvent, secretEvent},
		policy,
		namespacePolicy{},
		v1alpha3.PruneOnEvent,
	)
	require.NoError(t, err)
	configMapFirstBody, readErr := os.ReadFile(filepath.Join(configMapFirst.Filesystem().Root(), "all.yaml"))
	require.NoError(t, readErr)
	assert.Contains(t, string(configMapFirstBody), "kind: ConfigMap")
	assert.NotContains(t, string(configMapFirstBody), "kind: Secret",
		"a sensitive resource must never share a file with a plaintext resource")
}

// Resync (M8) folds its whole desired snapshot through the same createNew path
// as steady-state events, so the same brand-new-path collision can occur there
// too — proving the fix covers both entry points the design doc calls out.
func TestPlacement_ColdBundleCollision_ViaResync(t *testing.T) {
	worktree := newWorktreeForTest(t)
	policy := &manifestanalyzer.PlacementPolicy{Default: "all.yaml"}
	desired := []manifestanalyzer.DesiredResource{
		{
			Resource: types.NewResourceIdentifier("", "v1", "configmaps", "app", "alpha"),
			Object: &unstructured.Unstructured{Object: map[string]interface{}{
				"apiVersion": "v1", "kind": "ConfigMap",
				"metadata": map[string]interface{}{"name": "alpha", "namespace": "app"},
			}},
		},
		{
			Resource: types.NewResourceIdentifier("", "v1", "configmaps", "app", "beta"),
			Object: &unstructured.Unstructured{Object: map[string]interface{}{
				"apiVersion": "v1", "kind": "ConfigMap",
				"metadata": map[string]interface{}{"name": "beta", "namespace": "app"},
			}},
		},
	}

	w := &BranchWorker{contentWriter: newContentWriter(types.SensitiveResourcePolicy{}), mapper: configMapMapper()}
	_, changed, err := w.applyResyncToWorktree(
		context.Background(),
		worktree,
		"",
		ResolvedTargetMetadata{Placement: policy, PruneMode: v1alpha3.PruneAlways},
		desired,
		nil,
	)

	require.NoError(t, err)
	assert.True(t, changed)

	got, readErr := os.ReadFile(filepath.Join(worktree.Filesystem().Root(), "all.yaml"))
	require.NoError(t, readErr)
	assert.Equal(t, 2, strings.Count(string(got), "kind: ConfigMap"), "both resync creates must survive")
}

// A declared path into a SUBDIRECTORY of a kustomize folder must still be registered
// with the root that governs it (#295). Before the ancestor walk, governingKustomization
// looked only in the new file's own directory (plus the write scope's root under
// render-root scoping), so one byType line put a document in Git that no kustomization
// lists — committed, and rendered by nothing.
func TestPlacement_DeclaredSubdirectory_RegistersWithTheAncestorKustomization(t *testing.T) {
	worktree := newWorktreeForTest(t)
	root := worktree.Filesystem().Root()
	seedPlacedManifest(t, worktree, "kustomization.yaml",
		"namespace: app\nresources:\n  - deployment.yaml\n")
	seedPlacedManifest(t, worktree, "deployment.yaml",
		"apiVersion: apps/v1\nkind: Deployment\nmetadata:\n  name: web\n")
	policy := &manifestanalyzer.PlacementPolicy{
		ByType: map[string]string{"v1/configmaps": "configmaps/{name}.yaml"},
	}

	changed := applyEventsWithPolicy(t, worktree, policy, newConfigMapEvent("cache", "app"))
	require.True(t, changed)

	newFile, err := os.ReadFile(filepath.Join(root, "configmaps/cache.yaml"))
	require.NoError(t, err, "the declared path must be honoured")
	assert.Contains(t, string(newFile), "name: cache")

	kust, err := os.ReadFile(filepath.Join(root, "kustomization.yaml"))
	require.NoError(t, err)
	assert.Contains(t, string(kust), "configmaps/cache.yaml",
		"the ancestor kustomization must list the new file, or kustomize never renders it")

	assert.NotContains(t, string(newFile), "namespace:",
		"the governing kustomization's namespace: transformer supplies the namespace")
}