Commit 9042e91
authored
fix(test): stop the positional path overriding the curated unit-only suite (#221)
`composer test:unit-only` ran `phpunit tests -c tests/phpunit-unit-only.xml`.
A positional path OVERRIDES the configured testsuite entirely, so the curated
directory list in that config was decorative — the script swept all of tests/
regardless, which is precisely what the curation exists to prevent.
Measured today:
with `tests` 572 tests, 7 errors
without it 565 tests, 0 errors
The 7 are unit/Repair. They need Doctrine\DBAL\ParameterType, which only
resolves through the Nextcloud server's 3rdparty autoload — exactly the
dependency a suite named "no Nextcloud bootstrap" exists to avoid.
Dropping the argument makes the config govern, which is what its comment always
claimed. unit/Repair is not lost: the main phpunit.xml suite sweeps all of
tests/ and is what CI executes in-container, where doctrine resolves.
The config's comment now says the list only governs when nothing is passed
positionally, and records that unit/Repair is absent ON PURPOSE — otherwise the
next person to notice the gap re-adds it and reintroduces the errors.1 parent 4f7f1c7 commit 9042e91
2 files changed
Lines changed: 14 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
17 | 30 | | |
18 | 31 | | |
19 | 32 | | |
| |||
0 commit comments