Skip to content

Commit 2fcaf51

Browse files
rubenvdlindeConduction Release Bot
andauthored
fix(e2e): the lint pass renamed Playwright fixtures, which killed the suite (#349)
Playwright resolves a fixture BY NAME from the destructured parameter, so renaming an unused one to `_page` asks for a fixture that does not exist. The e2e leg dies before a single test runs and the report contains no test entries at all. Introduced by the pass that let the linter see tests/. The linter was right that the parameters were unused; underscore-prefixing is the fix for an ordinary unused argument and the wrong fix for a Playwright fixture, because the name is the lookup key. Same defect as buildiq#642, found by a fleet sweep. Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
1 parent 478fefb commit 2fcaf51

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

tests/e2e/jobs.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -299,9 +299,7 @@ test.describe("background jobs", () => {
299299
});
300300

301301
// --- audit retention prune job ----------------------------------------
302-
test("the prune job removes entries older than the retention window", async ({
303-
page: _page,
304-
}) => {
302+
test("the prune job removes entries older than the retention window", async () => {
305303
// Seed one clearly-old audit row and one recent row.
306304
await sqlExec(
307305
`INSERT INTO oc_app_versions_audit (actor_uid, app_id, operation, status, created_at) VALUES ('system','prunetest','install','success', '${tsOffset(-400)}')`,

0 commit comments

Comments
 (0)