Commit 2fcaf51
fix(e2e): the lint pass renamed Playwright fixtures, which killed the suite (#349)
Playwright resolves a fixture BY NAME from the destructured parameter, so
renaming an unused one to `_page` asks for a fixture that does not exist. The
e2e leg dies before a single test runs and the report contains no test
entries at all.
Introduced by the pass that let the linter see tests/. The linter was right
that the parameters were unused; underscore-prefixing is the fix for an
ordinary unused argument and the wrong fix for a Playwright fixture, because
the name is the lookup key.
Same defect as buildiq#642, found by a fleet sweep.
Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>1 parent 478fefb commit 2fcaf51
1 file changed
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
302 | | - | |
303 | | - | |
304 | | - | |
| 302 | + | |
305 | 303 | | |
306 | 304 | | |
307 | 305 | | |
| |||
0 commit comments