From 3e94948ae78f7af6880fb8b42aa59fb1821f82be Mon Sep 17 00:00:00 2001 From: Conduction Release Bot Date: Tue, 1 Sep 2026 10:06:10 +0200 Subject: [PATCH] fix(moderation): the review queue still asked for the assessment type MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Development E2E caught this: ✘ reviews: an authenticated submission lands pending and is not yet public Error: submitted review is not in the pending queue ✘ reviews: admin approval publishes the review and moves the aggregate ModerationService::MODERATED_TYPE_REVIEW moved to software-review with the slug, but the surfaces that ASK for that queue did not: StackiqSettings renders ModerationQueue with type="assessment", and two SettingsService object-type lists plus the Modals registry still named the old type. The review was stored under the new slug and the queue looked under the old one, so it always came back empty. In this app the object type IS the schema slug, which SettingsService states in its own comment and warns has silently killed this exact ratings feature once before. --- lib/Controller/ModerationController.php | 6 +++--- lib/Service/SettingsService.php | 4 ++-- src/modals/Modals.vue | 2 +- src/views/settings/StackiqSettings.vue | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/Controller/ModerationController.php b/lib/Controller/ModerationController.php index 368bce09..78778f0a 100644 --- a/lib/Controller/ModerationController.php +++ b/lib/Controller/ModerationController.php @@ -70,7 +70,7 @@ public function __construct( /** * List the pending entries (of `type`) awaiting moderation. * - * @param string $type The moderated object type ('organization', default, or 'assessment'). + * @param string $type The moderated object type ('organization', default, or 'software-review'). * * @return JSONResponse `{ok, items}` or a 400. * @@ -92,7 +92,7 @@ public function pending(string $type = ModerationService::MODERATED_TYPE): JSONR * Approve a pending entry (of `type`). * * @param string $uuid The entry uuid. - * @param string $type The moderated object type ('organization', default, or 'assessment'). + * @param string $type The moderated object type ('organization', default, or 'software-review'). * * @return JSONResponse `{ok, status}` or a 400. * @@ -114,7 +114,7 @@ public function approve(string $uuid, string $type = ModerationService::MODERATE * Reject a pending entry (of `type`). * * @param string $uuid The entry uuid. - * @param string $type The moderated object type ('organization', default, or 'assessment'). + * @param string $type The moderated object type ('organization', default, or 'software-review'). * * @return JSONResponse `{ok, status}` or a 400. * diff --git a/lib/Service/SettingsService.php b/lib/Service/SettingsService.php index 7099a8a3..18cb1c03 100644 --- a/lib/Service/SettingsService.php +++ b/lib/Service/SettingsService.php @@ -300,7 +300,7 @@ public function getSettings(): array { 'usage', 'contract', 'connection', - 'assessment', + 'software-review', 'module', 'compliancy', 'moduleVersion', @@ -4039,7 +4039,7 @@ private function configureVoorzieningen(): array { 'usage', 'contract', 'connection', - 'assessment', + 'software-review', 'module', 'compliancy', 'moduleversie', diff --git a/src/modals/Modals.vue b/src/modals/Modals.vue index ad08ee5b..2ff671bc 100644 --- a/src/modals/Modals.vue +++ b/src/modals/Modals.vue @@ -42,7 +42,7 @@ const GENERIC_MODAL_OBJECT_TYPES = [ 'suite', 'service', 'vulnerability', - 'assessment', + 'software-review', 'compliancy', 'moduleVersion', 'sector', diff --git a/src/views/settings/StackiqSettings.vue b/src/views/settings/StackiqSettings.vue index 4162c020..00b3c6d8 100644 --- a/src/views/settings/StackiqSettings.vue +++ b/src/views/settings/StackiqSettings.vue @@ -96,7 +96,7 @@ beoordeeling type, per catalog-ratings spec's "reuse the pattern, don't invent a second mechanism" requirement. -->