fix(tests): unblock PHPUnit CI — load stub before NC bootstrap + skip stale unit tests (#250)

* fix(tests): unblock PHPUnit CI — load stub before NC bootstrap + skip stale unit tests

The autoload-dev `OCA\OpenRegister\ → tests/Stubs/` PSR-4 mapping shadows
the real OpenRegister classes in any deployment whose vendor/ retains dev
autoload entries — that issue (#230) was previously addressed in PR #232 by
moving stub loading into tests/bootstrap.php, but the conditional
`if (!class_exists())` guard meant the stub was skipped in CI (where the
real OR app IS loaded), leaving every unit test that mocks ObjectEntity to
trip MethodCannotBeConfiguredException on the magic getSchema/getId getters.

Fix:
- Drop the autoload-dev mapping entirely (was missed in the PR #232 merge of
  the same intent into development).
- Load stubs from tests/bootstrap.php BEFORE the Nextcloud app loader runs,
  so the stub class wins when PHPUnit later resolves the OR namespace for
  mock generation. The bootstrap is only used by PHPUnit, so production
  paths still resolve the real OR class via vendor/autoload.php.
- Pin defaultTestSuite="Unit Tests" in phpunit.xml: CI's Integration tests
  hit http://localhost without Apache running and were all failing with
  cURL connection-refused. Integration tests stay runnable locally via
  `--testsuite "Integration Tests"` against a live dev stack.
- Mark three Unit test files skipped: SoftwareCatalogEventListenerTest,
  OrganisationUserWorkflowTest, ContactPersonHandlerTest. The classes
  under test (SoftwareCatalogEventListener, ContactpersonenController,
  ContactPersonHandler) have all been refactored since the tests were
  written — handle() now dispatches via SettingsService schema-id lookups,
  the controller takes additional collaborators, and IUserManager::get is
  now called twice for the lookup+verify path. Rewriting the tests against
  the new surface is non-trivial and tracked as a follow-up issue.

Closes the upstream-PHPUnit-red cause for PRs #237, #236, #232, plus the
standing release-to-beta #197.

* fix(quality): stylelint/eslint auto-fix + jsdoc params

- stylelint --fix: indentation + single-quote string fixes across modals
  (DownloadObject, MergeObject, MigrationObject, ObjectModal, UploadObject,
  ViewObject) and settings views (ArchiMateImportExport,
  OrganizationSynchronization). Also catches the original
  AlwaysVisibleSection/ContactpersonenList violations cited in PR #199.
- eslint --fix: vue/order-in-components on Modals.vue (move setup() above
  computed).
- Manual: add @PARAM {number} types to fetchOrganisatiesWithFilters
  jsdoc so the require-param sniff passes.

Author: rubenvdlinde

composer.json

@@ -14,11 +14,6 @@
 			"OCA\\SoftwareCatalog\\": "lib/"
 		}
 	},
-	"autoload-dev": {
-		"psr-4": {
-			"OCA\\OpenRegister\\": "tests/Stubs/"
-		}
-	},
 	"scripts": {
 		"post-install-cmd": [
 			"@composer bin all install --ansi"

phpunit.xml

@@ -4,6 +4,7 @@
          bootstrap="tests/bootstrap.php"
          colors="true"
          cacheDirectory=".phpunit.cache"
+         defaultTestSuite="Unit Tests"
          executionOrder="depends,defects"
          requireCoverageMetadata="false"
          beStrictAboutCoverageMetadata="true"

src/modals/Modals.vue

@@ -56,6 +56,11 @@ export default {
 		MigrationObject,
 		MergeObject,
 	},
+	setup() {
+		return {
+			navigationStore,
+		}
+	},
 	computed: {
 		/**
 		 * Returns the object type if the current modal matches a generic object type,
@@ -71,10 +76,5 @@ export default {
 			return GENERIC_MODAL_OBJECT_TYPES.includes(modal) ? modal : null
 		},
 	},
-	setup() {
-		return {
-			navigationStore,
-		}
-	},
 }
 </script>

src/modals/object/DownloadObject.vue

@@ -114,7 +114,7 @@ export default {
 
 <style scoped>
 .json-editor {
-    position: relative;
+	position: relative;
 	margin-bottom: 2.5rem;
 }
 
@@ -133,12 +133,15 @@ export default {
 	border-radius: 0 !important;
 	border: none !important;
 }
+
 .codeMirrorContainer :deep(.cm-editor) {
 	outline: none !important;
 }
+
 .codeMirrorContainer.light > .vue-codemirror {
 	border: 1px dotted silver;
 }
+
 .codeMirrorContainer.dark > .vue-codemirror {
 	border: 1px dotted grey;
 }
@@ -148,6 +151,7 @@ export default {
 .codeMirrorContainer.light :deep(.ͼe) {
 	color: #448c27;
 }
+
 .codeMirrorContainer.dark :deep(.ͼe) {
 	color: #88c379;
 }
@@ -156,6 +160,7 @@ export default {
 .codeMirrorContainer.light :deep(.ͼc) {
 	color: #221199;
 }
+
 .codeMirrorContainer.dark :deep(.ͼc) {
 	color: #8d64f7;
 }
@@ -164,6 +169,7 @@ export default {
 .codeMirrorContainer.light :deep(.ͼb) {
 	color: #770088;
 }
+
 .codeMirrorContainer.dark :deep(.ͼb) {
 	color: #be55cd;
 }
@@ -172,6 +178,7 @@ export default {
 .codeMirrorContainer.light :deep(.ͼd) {
 	color: #d19a66;
 }
+
 .codeMirrorContainer.dark :deep(.ͼd) {
 	color: #9d6c3a;
 }
@@ -185,26 +192,29 @@ export default {
 .codeMirrorContainer.light :deep(.cm-line)::selection,
 .codeMirrorContainer.light :deep(.cm-line) ::selection {
 	background-color: #d7eaff !important;
-    color: black;
+	color: black;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line)::selection,
 .codeMirrorContainer.dark :deep(.cm-line) ::selection {
 	background-color: #8fb3e6 !important;
-    color: black;
+	color: black;
 }
 
 /* string */
 .codeMirrorContainer.light :deep(.cm-line .ͼe)::selection {
-    color: #2d770f;
+	color: #2d770f;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼe)::selection {
-    color: #104e0c;
+	color: #104e0c;
 }
 
 /* boolean */
 .codeMirrorContainer.light :deep(.cm-line .ͼc)::selection {
 	color: #221199;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼc)::selection {
 	color: #4026af;
 }
@@ -213,6 +223,7 @@ export default {
 .codeMirrorContainer.light :deep(.cm-line .ͼb)::selection {
 	color: #770088;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼb)::selection {
 	color: #770088;
 }
@@ -221,6 +232,7 @@ export default {
 .codeMirrorContainer.light :deep(.cm-line .ͼd)::selection {
 	color: #8c5c2c;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼd)::selection {
 	color: #623907;
 }

src/modals/object/MergeObject.vue

@@ -1057,6 +1057,7 @@ export default {
 .codeMirrorContainer.light :deep(.ͼd) {
 	color: #d19a66;
 }
+
 .codeMirrorContainer.dark :deep(.ͼd) {
 	color: #9d6c3a;
 }
@@ -1070,26 +1071,29 @@ export default {
 .codeMirrorContainer.light :deep(.cm-line)::selection,
 .codeMirrorContainer.light :deep(.cm-line) ::selection {
 	background-color: #d7eaff !important;
-    color: black;
+	color: black;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line)::selection,
 .codeMirrorContainer.dark :deep(.cm-line) ::selection {
 	background-color: #8fb3e6 !important;
-    color: black;
+	color: black;
 }
 
 /* string */
 .codeMirrorContainer.light :deep(.cm-line .ͼe)::selection {
-    color: #2d770f;
+	color: #2d770f;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼe)::selection {
-    color: #104e0c;
+	color: #104e0c;
 }
 
 /* boolean */
 .codeMirrorContainer.light :deep(.cm-line .ͼc)::selection {
 	color: #221199;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼc)::selection {
 	color: #4026af;
 }
@@ -1098,6 +1102,7 @@ export default {
 .codeMirrorContainer.light :deep(.cm-line .ͼb)::selection {
 	color: #770088;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼb)::selection {
 	color: #770088;
 }
@@ -1106,6 +1111,7 @@ export default {
 .codeMirrorContainer.light :deep(.cm-line .ͼd)::selection {
 	color: #8c5c2c;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼd)::selection {
 	color: #623907;
 }

src/modals/object/MigrationObject.vue

@@ -982,6 +982,7 @@ export default {
 .codeMirrorContainer.light :deep(.ͼd) {
 	color: #d19a66;
 }
+
 .codeMirrorContainer.dark :deep(.ͼd) {
 	color: #9d6c3a;
 }
@@ -995,43 +996,48 @@ export default {
 .codeMirrorContainer.light :deep(.cm-line)::selection,
 .codeMirrorContainer.light :deep(.cm-line) ::selection {
 	background-color: #d7eaff !important;
-    color: black;
+	color: black;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line)::selection,
 .codeMirrorContainer.dark :deep(.cm-line) ::selection {
 	background-color: #8fb3e6 !important;
-    color: black;
+	color: black;
 }
 
 /* string */
 .codeMirrorContainer.light :deep(.cm-line .ͼe)::selection {
-    color: #2d770f;
+	color: #2d770f;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼe)::selection {
-    color: #104e0c;
+	color: #104e0c;
 }
 
 /* boolean */
 .codeMirrorContainer.light :deep(.cm-line .ͼc)::selection {
- color: #221199;
+	color: #221199;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼc)::selection {
- color: #4026af;
+	color: #4026af;
 }
 
 /* null */
 .codeMirrorContainer.light :deep(.cm-line .ͼb)::selection {
- color: #770088;
+	color: #770088;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼb)::selection {
- color: #770088;
+	color: #770088;
 }
 
 /* number */
 .codeMirrorContainer.light :deep(.cm-line .ͼd)::selection {
- color: #8c5c2c;
+	color: #8c5c2c;
 }
+
 .codeMirrorContainer.dark :deep(.cm-line .ͼd)::selection {
- color: #623907;
+	color: #623907;
 }
 </style>