Commit e302746
committed
fix: PHPCS coding standard fixes (4101 → 430 errors) (#189)
* fix: Apply PHPCS coding standard fixes (4101 → 430 errors remaining)
Apply named parameters, explicit boolean comparisons, file doc comments,
end-method comments, and other coding standard fixes. Reduced errors from
4101 to 430 across 43 files. Includes custom NamedParametersSniff and CI updates.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: Fix corrupted `=== false` comparisons and ObjectEntity type error
7 corrupted lines across 4 files had `$obj === false->method()` instead
of `$obj->method() === false` — causing fatal errors on user profile
updates, group assignments, and app-install checks. Also fixed
ObjectEntity used as array in deelnemers endpoint.
Test pass rate: 89.6% → 99.3% (44 failures → 3)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* docs: Add test results for issues #451-456 and update API test results
Added classification (Bug/Feature Request) and test verdicts to new
issues #451-456. Updated all API test result files after code fixes
brought pass rate to 99.3%.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: Fix Postman test assertions for #65 and #452
- #65 AC8: Changed Lookup step to use jan.pietersen auth (matching
PATCH auth) so RBAC doesn't block access to the contact. Added
skip logic if no UUID found.
- #452 AC1: Rewrote test to fetch a specific applicatie with
_extend[]=koppelingen, since inversedBy relations only resolve
on single-entity fetches, not list views.
Test suite now passes 100% (425/425 assertions).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* docs: Update API test results — 100% pass rate (425/425)
All assertions now passing after fixing Postman test logic for
#65 (contact RBAC auth) and #452 (inversedBy _extend usage).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Restored development-release version to 0.1.140-unstable.431 parent eb72884 commit e302746
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
0 commit comments