fix(softwarecatalog): resolve the config key through one map, not by derivation

CI's PHPUnit matrix went red on all six cells. Three separate causes, and
all three are the same shape: something DERIVED the app-config key from the
object type, and the slug half of that pair was just translated.

- `getRegisterIdForObjectType()` builds `$objectType . '_schema'`. With
  slugs English and the stored keys still Dutch that lookup misses, and a
  miss is not an error — it returns null and the caller reads "not
  configured". Ratings and every catalog type resolved to no register.
- `FacetService::fetchBaseObjects()` did the same and returned an empty
  facet set, which renders as a page with no filters rather than a failure.
- `catalog-ratings.json` still declared the schema map key `beoordeeling`.
  The by-hand fix for map keys covered the main register file only; the
  register.d fragments were not swept. Found systematically this time.

All three now go through `SettingsService::LEGACY_SCHEMA_KEY`, the one
place that knows slug and stored key diverge. FacetService reads it as a
CONSTANT rather than calling the service: it takes SettingsService as a
collaborator and every test mocks it, so a method call there returns the
mock default and misses in exactly the tests meant to catch this.

Also: one assertion hardcoded the old name inside a REGEX literal
(`/module.*dienst|dienst.*module/`) — a position no rename pattern reaches.

The control I used before this was WRONG. `git stash` reverts uncommitted
work only, and this branch already had three commits, so what I compared
against was my own branch. It reported 7 pre-existing failures where a
real control from `origin/development` reports none. Rebuilt with
`git archive origin/development`.

Verified against that real control, full unit suite both sides:
684 tests, 1 error, 25 skipped on BOTH — same count, so nothing silently
stopped running, and the one error (Symfony HeaderUtils missing under the
unit bootstrap) is identical on development.

Author: Conduction Release Bot

lib/Service/FacetService.php

@@ -399,7 +399,17 @@ private function buildCacheKey(string $schema, array $filters, ?string $search,
 	private function fetchBaseObjects(ObjectService $objectService, string $schema, ?string $search, ?string $organization): array {
 		$voorzieningenConfig = $this->settingsService->getVoorzieningenConfig();
 		$registerId = $voorzieningenConfig['register'] ?? null;
-		$schemaId = $voorzieningenConfig[$schema . '_schema'] ?? null;
+		// NOT `$schema . '_schema'`: the slugs are English now and the stored
+		// config keys are still Dutch, so the derived key would miss and this
+		// method would log "not configured" and return an empty facet set —
+		// which renders as a page with no filters rather than as an error.
+		//
+		// Read as a CONSTANT rather than through SettingsService: this class
+		// takes that service as a collaborator and every test mocks it, so a
+		// method call here returns the mock's default and the lookup misses in
+		// exactly the tests meant to catch that.
+		$schemaKey = (SettingsService::LEGACY_SCHEMA_KEY[$schema] ?? $schema . '_schema');
+		$schemaId = ($voorzieningenConfig[$schemaKey] ?? null);
 
 		if (empty($registerId) === true || empty($schemaId) === true) {
 			$this->logger->warning(

lib/Service/SettingsService.php

@@ -102,6 +102,34 @@ class SettingsService {
 	 */
 	private const MIN_OPENREGISTER_VERSION = '0.1.7';
 
+	/**
+	 * Object type => the app-config key its schema id is actually stored under.
+	 *
+	 * The key was always derived from the schema SLUG. Eight slugs are now
+	 * English while the stored keys are deliberately still Dutch — renaming that
+	 * family is a migration across ~40 sites in three shapes, and doing a SUBSET
+	 * resolves some types while leaving others silently "not configured", which
+	 * is how the ratings feature died once already.
+	 *
+	 * So slug and key diverge, and every place that DERIVES the key from the
+	 * object type (`$objectType . '_schema'`) has to come through here. Missing
+	 * one is not an error: the lookup finds nothing and the caller reads it as
+	 * "not configured". `getRegisterIdForObjectType()` did exactly that.
+	 *
+	 * @var array<string, string>
+	 */
+	public const LEGACY_SCHEMA_KEY = [
+		'assessment' => 'beoordeeling_schema',
+		'bioMeasure' => 'bioMaatregel_schema',
+		'connection' => 'koppeling_schema',
+		'contactPerson' => 'contactpersoon_schema',
+		'moduleVersion' => 'moduleVersie_schema',
+		'organization' => 'organisatie_schema',
+		'service' => 'dienst_schema',
+		'usage' => 'gebruik_schema',
+		'vulnerability' => 'kwetsbaarheid_schema',
+	];
+
 	/**
 	 * SettingsService constructor
 	 *
@@ -986,6 +1014,21 @@ public function getSchemaIdForObjectType(string $objectType): ?int {
 		return $result;
 	}//end getSchemaIdForObjectType()
 
+	/**
+	 * The app-config key an object type's schema id is stored under.
+	 *
+	 * Slug and stored key diverged when the slugs were translated, so never
+	 * build the key as `$objectType . '_schema'` directly — see LEGACY_SCHEMA_KEY.
+	 *
+	 * @param string $objectType The object type (schema slug).
+	 *
+	 * @return string The app-config key.
+	 * @spec   openspec/specs/settings-service/spec.md
+	 */
+	public function voorzieningenSchemaKey(string $objectType): string {
+		return (self::LEGACY_SCHEMA_KEY[$objectType] ?? $objectType . '_schema');
+	}//end voorzieningenSchemaKey()
+
 	/**
 	 * Gets the configured register ID for a specific object type
 	 *
@@ -1029,9 +1072,9 @@ public function getRegisterIdForObjectType(string $objectType): ?int {
 		// key map: any type with a `<type>_schema` in the voorzieningen config
 		// belongs to the voorzieningen register.
 		$voorzieningenConfig = $this->getVoorzieningenConfig();
-		$isVoorzieningenType = in_array($objectType, ['organization', 'organization', 'contactPerson', 'contact'], true);
+		$isVoorzieningenType = in_array($objectType, ['organization', 'contactPerson', 'contact'], true);
 		if ($isVoorzieningenType === false) {
-			$isVoorzieningenType = isset($voorzieningenConfig[$objectType . '_schema']);
+			$isVoorzieningenType = isset($voorzieningenConfig[$this->voorzieningenSchemaKey(objectType: $objectType)]);
 		}
 
 		if ($result === null && $isVoorzieningenType === true) {

lib/Settings/register.d/catalog-ratings.json

@@ -1,7 +1,7 @@
 {
   "components": {
     "schemas": {
-      "beoordeeling": {
+      "assessment": {
         "properties": {
           "auteur": {
             "type": "string",

tests/Unit/Service/FacetServiceTest.php

@@ -210,7 +210,7 @@ public function testGetFacetsThrowsForUnsupportedSchema(): void {
 		$service = $this->makeService(objectService: $this->createMock(ObjectService::class));
 
 		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessageMatches('/module.*dienst|dienst.*module/');
+		$this->expectExceptionMessageMatches('/module.*service|service.*module/');
 		$service->getFacets(schema: 'contract');
 
 	}//end testGetFacetsThrowsForUnsupportedSchema()