Commit a99ee19
Conduction Release Bot
fix(ci): correct the documentation.yml permissions rationale — build-image defaults to true
The comment claimed `packages: write` was needed only because GitHub statically
validates a callee's declared job permissions, and that the `image` job "never
runs" here. That is wrong on the second half.
`build-image` in ConductionNL/.github/.github/workflows/documentation.yml is
`type: boolean, default: true`, and none of the callers pass it. So the `image`
job DOES run on a push to `documentation`, and it really does `docker buildx`
push to GHCR. `packages: write` is load-bearing at RUNTIME, not merely
statically — dropping it would 403 that push.
Comment only; the permissions block itself is unchanged and was already correct.1 parent eb71c24 commit a99ee19
1 file changed
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
22 | 27 | | |
23 | 28 | | |
24 | 29 | | |
| |||
0 commit comments