Skip to content

Commit a99ee19

Browse files
author
Conduction Release Bot
committed
fix(ci): correct the documentation.yml permissions rationale — build-image defaults to true
The comment claimed `packages: write` was needed only because GitHub statically validates a callee's declared job permissions, and that the `image` job "never runs" here. That is wrong on the second half. `build-image` in ConductionNL/.github/.github/workflows/documentation.yml is `type: boolean, default: true`, and none of the callers pass it. So the `image` job DOES run on a push to `documentation`, and it really does `docker buildx` push to GHCR. `packages: write` is load-bearing at RUNTIME, not merely statically — dropping it would 403 that push. Comment only; the permissions block itself is unchanged and was already correct.
1 parent eb71c24 commit a99ee19

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/documentation.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,15 @@ jobs:
1515
# deploy contents: write (peaceiris/actions-gh-pages pushes to gh-pages)
1616
# image contents: read, packages: write (buildx push to GHCR)
1717
#
18-
# ⚠️ `packages: write` stays even though `build-image` is not set here, so
19-
# the `image` job never runs. GitHub validates the callee's DECLARED job
20-
# permissions against this ceiling before dispatch — including jobs an `if:`
21-
# will skip — so dropping it makes the whole call fail to start.
18+
# ⚠️ `packages: write` is load-bearing at RUNTIME, not merely statically:
19+
# the callee's `build-image` input DEFAULTS TO TRUE, so the `image` job
20+
# really does run on a push to `documentation` and really does push to
21+
# GHCR. Dropping it 403s that push.
22+
#
23+
# It would be required even if that job were disabled, because GitHub
24+
# validates the callee's DECLARED job permissions against this ceiling
25+
# before dispatch — including for jobs an `if:` will skip — so a too-low
26+
# ceiling makes the whole call fail to start rather than run with less.
2227
permissions:
2328
contents: write
2429
packages: write

0 commit comments

Comments
 (0)