fix: Fix PHPUnit tests — delete EmailServiceTest, fix constructor mocks

- Delete EmailServiceTest (references non-existent EmailService class)
- Fix SoftwareCatalogEventListenerTest to mock ObjectEntity properly
- Fix OrganisationUserWorkflowTest constructor argument order
- Fix ContactPersonHandlerTest constructor argument order

Author: rubenvdlinde

tests/Unit/EventListener/SoftwareCatalogEventListenerTest.php

@@ -368,17 +368,23 @@ public function testHandleGebruikerRevertedEvent(): void
      *
      * @return void
      */
-    public function testHandleEventWithNullObject(): void
+    public function testHandleEventWithUnmatchedSchema(): void
     {
-        // Create ObjectCreatedEvent with null object
-        $event = new ObjectCreatedEvent(null);
+        // Create a mock ObjectEntity with a schema that doesn't match any configured schema
+        $object = $this->createMock(ObjectEntity::class);
+        $object->method('getSchema')->willReturn(999999);
+        $object->method('getUuid')->willReturn('test-uuid');
+        $object->method('getRegister')->willReturn(1);
 
-        // No service methods should be called
+        // Create ObjectCreatedEvent with a valid object but unmatched schema
+        $event = new ObjectCreatedEvent($object);
+
+        // No service methods should be called since schema doesn't match
         $this->softwareCatalogueService
             ->expects($this->never())
             ->method($this->anything());
 
-        // Handle the event - should return early
+        // Handle the event - should return early since schema doesn't match
         $this->eventListener->handle($event);
     }
 

tests/Unit/OrganisationUserWorkflowTest.php

@@ -32,7 +32,9 @@
 use OCP\IUser;
 use OCP\IGroup;
 use OCP\IRequest;
+use OCP\IUserSession;
 use OCP\Security\ISecureRandom;
+use Psr\Container\ContainerInterface;
 use PHPUnit\Framework\TestCase;
 use PHPUnit\Framework\MockObject\MockObject;
 use Psr\Log\LoggerInterface;
@@ -146,6 +148,8 @@ protected function setUp(): void
             $this->contactpersoonService,
             $this->userManager,
             $this->groupManager,
+            $this->createMock(IUserSession::class),
+            $this->createMock(ContainerInterface::class),
             $this->createMock(ISecureRandom::class),
             $this->logger
         );

tests/Unit/Service/ContactPersonHandlerTest.php

@@ -6,11 +6,16 @@
 
 use OCA\SoftwareCatalog\Service\SoftwareCatalogue\ContactPersonHandler;
 use OCA\SoftwareCatalog\Service\SettingsService;
+use OCA\SoftwareCatalog\Service\SymfonyEmailService;
+use OCP\App\IAppManager;
+use OCP\IAppConfig;
+use OCP\IConfig;
 use OCP\IUserManager;
 use OCP\IGroupManager;
 use OCP\IUser;
 use OCP\IGroup;
-use OCP\IContainer;
+use OCP\Security\ISecureRandom;
+use Psr\Container\ContainerInterface;
 use PHPUnit\Framework\TestCase;
 use PHPUnit\Framework\MockObject\MockObject;
 use Psr\Log\LoggerInterface;
@@ -47,11 +52,11 @@ class ContactPersonHandlerTest extends TestCase
     private IGroupManager|MockObject $groupManager;
 
     /**
-     * Mock of the IContainer service
+     * Mock of the ContainerInterface service
      *
-     * @var IContainer|MockObject
+     * @var ContainerInterface|MockObject
      */
-    private IContainer|MockObject $container;
+    private ContainerInterface|MockObject $container;
 
     /**
      * Mock of the LoggerInterface
@@ -86,7 +91,7 @@ protected function setUp(): void
         // Create mocks
         $this->userManager = $this->createMock(IUserManager::class);
         $this->groupManager = $this->createMock(IGroupManager::class);
-        $this->container = $this->createMock(IContainer::class);
+        $this->container = $this->createMock(ContainerInterface::class);
         $this->logger = $this->createMock(LoggerInterface::class);
         $this->settingsService = $this->createMock(SettingsService::class);
 
@@ -98,9 +103,14 @@ protected function setUp(): void
         // Create the ContactPersonHandler instance
         $this->contactPersonHandler = new ContactPersonHandler(
             $this->userManager,
+            $this->createMock(ISecureRandom::class),
             $this->groupManager,
+            $this->createMock(IAppConfig::class),
             $this->container,
-            $this->logger
+            $this->createMock(IAppManager::class),
+            $this->logger,
+            $this->createMock(SymfonyEmailService::class),
+            $this->createMock(IConfig::class)
         );
     }