Skip to content

Commit 5546f7d

Browse files
authored
fix(ci): test the whole declared Nextcloud range, not only the ceiling (#494)
appinfo/info.xml declares <nextcloud min-version="32" max-version="34"/>, but nextcloud-test-refs was '["stable34"]' — so the declared floor and the middle major were advertised to the App Store with no job touching either. This is the coding-standard migration's own defect: its rollout REPLACED the ref list instead of extending it. The programme opened by reporting that nothing was tested on NC 34 and, in fixing that, made 32 and 33 the untested end. Same drift, other direction. stable34 stays first because newman, playwright and journeydoc-capture all read fromJSON(inputs.nextcloud-test-refs)[0] as their single server. Verified green on all three refs against nextcloud/ocp ^34 on portaliq (run 31599055849, six PHPUnit legs: 32/33/34 x PHP 8.3/8.4).
1 parent 514d9c0 commit 5546f7d

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/code-quality.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,15 @@ jobs:
6060
with:
6161
app-name: softwarecatalog
6262
php-version: "8.3"
63-
nextcloud-test-refs: '["stable34"]'
63+
# THE LIST IS THE WHOLE DECLARED RANGE. appinfo/info.xml declares
64+
# <nextcloud min-version="32" max-version="34"/>, so 32, 33 and 34 each get
65+
# a leg. Adopting NC 34 by REPLACING the list left 32 and 33 advertised to
66+
# the App Store with no job touching them — the declared floor became the
67+
# untested end, which is the same drift as never testing 34, reversed.
68+
# stable34 leads because newman, playwright and journeydoc-capture all read
69+
# `fromJSON(inputs.nextcloud-test-refs)[0]` as their single server, and 34
70+
# is the major this app had never been exercised on.
71+
nextcloud-test-refs: '["stable34", "stable32", "stable33"]'
6472
enable-psalm: true
6573
enable-phpstan: true
6674
enable-phpmetrics: true

0 commit comments

Comments
 (0)