Merge pull request #534 from ConductionNL/fix/phpcs-docblocks

fix(phpcs): clear all 19 errors — phpcs exits 0

Author: rubenvdlinde

lib/Controller/ContactpersonenController.php

@@ -139,6 +139,9 @@ class ContactpersonenController extends Controller {
 	 * @param ContainerInterface $container Container for DI
 	 * @param ISecureRandom $secureRandom Secure random generator
 	 * @param LoggerInterface $logger Logger instance
+	 * @param ObjectServiceInterface $objectService OpenRegister object access (ADR-022/ADR-084 —
+	 *                                              the published contract, not the concrete service)
+	 * @param OrganisationService $organisationService Resolves the organisation a contactpersoon belongs to
 	 *
 	 * @SuppressWarnings(PHPMD.ExcessiveParameterList)
 	 */
@@ -1001,7 +1004,7 @@ private function verifyCrossTenantScope(\OCP\IUser $currentUser, string $usernam
 	 * @spec openspec/changes/method-decomposition/tasks.md#task-5
 	 */
 	private function resolveContactOrganisation(object $objectService, string $username): ?string {
-		// development's side on both counts: this method TAKES $objectService as a
+		// Development's side on both counts: this method TAKES $objectService as a
 		// parameter (my dangling-reference pass wrongly made it a property read),
 		// and the schema slug was renamed contactpersoon -> contactPerson there.
 		$results = $objectService->searchObjectsPaginated(

lib/Controller/OrganisationMembersController.php

@@ -77,9 +77,8 @@ class OrganisationMembersController extends Controller {
 	 * @param IUserSession $userSession The user session (auth guard).
 	 * @param IGroupManager $groupManager Group membership (beheerder guard).
 	 * @param IUserManager $userManager User lookup (existing-user-only guard).
-	 *                                      `OrganisationService` without a hard compile-time
-	 *                                      dependency on another app's class.
 	 * @param LoggerInterface $logger Logger.
+	 * @param OrganisationService $organisationService Resolves and updates organisation membership.
 	 */
 	public function __construct(
 		IRequest $request,

lib/Controller/ReviewController.php

@@ -123,14 +123,20 @@ public function submit(array $review = [], string $subjectType = '', string $sub
 	 *      OpenRegister's enforcement of the predicate. So an arbitrary
 	 *      `subjectId` can only ever select from already-approved reviews.
 	 * @spec           openspec/specs/catalog-ratings/spec.md#requirement-module-and-dienst-detail-pages-must-display-an-aggregate-rating-computed-only-from-approved-reviews
+	 *
+	 * Rate limit: a read of already-published aggregate review scores — no
+	 * credential, and the data is public by design, so a volume ceiling only.
+	 * Much looser than IntakeController's 5/3600: that one accepts a SUBMISSION,
+	 * this one answers a page render, and a catalogue page listing many subjects
+	 * will legitimately call it repeatedly.
+	 *
+	 * (This note lived between the attributes and the signature, where PHPCS
+	 * reads any comment as the function's doc comment and requires docblock
+	 * syntax. It belongs up here regardless — nothing should sit between an
+	 * attribute list and the thing it annotates.)
 	 */
 	#[PublicPage]
 	#[NoCSRFRequired]
-	// A read of already-published aggregate review scores — no credential, and
-	// the data is public by design, so a volume ceiling only. Much looser than
-	// IntakeController's 5/3600: that one accepts a SUBMISSION, this one
-	// answers a page render, and a catalogue page listing many subjects will
-	// legitimately call it repeatedly.
 	#[AnonRateLimit(limit: 120, period: 60)]
 	public function aggregate(string $subjectType = '', string $subjectId = ''): JSONResponse {
 		$result = $this->aggregate->getAggregate(subjectType: $subjectType, subjectId: $subjectId);

lib/EventListener/UserProfileUpdatedEventListener.php

@@ -57,6 +57,10 @@ class UserProfileUpdatedEventListener implements IEventListener {
 	 * Constructor for UserProfileUpdatedEventListener.
 	 *
 	 * @param ContainerInterface $container DI container for lazy service resolution.
+	 * @param ObjectServiceInterface $objectService OpenRegister object access (ADR-084 contract).
+	 * @param SchemaMapper $schemaMapper Resolves the contactpersoon schema.
+	 * @param RegisterMapper $registerMapper Resolves the register the schema lives in.
+	 * @param MetadataHydrationHandler $metadataHydrationHandler Hydrates `@self` metadata on read.
 	 */
 	public function __construct(
 		private readonly ContainerInterface $container,

lib/Repair/InitializeSettings.php

@@ -111,7 +111,9 @@ public function run(IOutput $output): void {
 				$this->config->setValueInt(Application::APP_ID, 'eol_warning_window_days', 180);
 			}
 
-			// @spec openspec/changes/portfolio-rationalization-time/specs/portfolio-rationalization-time/spec.md#requirement-report-aggregation-queries-are-bounded
+			// @spec openspec/changes/portfolio-rationalization-time/specs
+			//       /portfolio-rationalization-time/spec.md
+			//       #requirement-report-aggregation-queries-are-bounded
 			// Seed the portfolio-report page-size ceiling default only when
 			// unset, so an operator's chosen bound survives upgrades.
 			if ($this->config->hasKey(Application::APP_ID, 'portfolio_report_page_size_ceiling') === false) {

lib/Repair/RenameDutchCatalogColumns.php

@@ -289,6 +289,8 @@ class RenameDutchCatalogColumns implements IRepairStep {
 	 *
 	 * @param IDBConnection $db Database connection.
 	 * @param LoggerInterface $logger Logger.
+	 * @param RenameDutchCatalogDecisions $decisions The per-column rename decisions this step
+	 *                                               applies; injectable so a test can steer them.
 	 */
 	public function __construct(
 		private readonly IDBConnection $db,

lib/Service/Federation/FederationMerger.php

@@ -63,10 +63,13 @@ class FederationMerger {
 	 * @param array<int,array<string,mixed>> $localMirrors The locally-stored mirrors of THIS peer.
 	 * @param string $syncedAt The ISO-8601 sync moment.
 	 *
-	 * @return array{create:array<int,array<string,mixed>>, update:array<int,array<string,mixed>>, withdraw:array<int,array<string,mixed>>}
-	 *                                                                                                                                      The reconciliation plan. Each create/update item is a full
-	 *                                                                                                                                      mirror data bag (with `_source`); each withdraw item is the
-	 *                                                                                                                                      existing local mirror data bag, marked withdrawn + stale.
+	 * The reconciliation plan. Each create/update item is a full mirror data bag
+	 * (with `_source`); each withdraw item is the existing local mirror data bag,
+	 * marked withdrawn + stale.
+	 *
+	 * @return array{create:array<int,array<string,mixed>>,
+	 *               update:array<int,array<string,mixed>>,
+	 *               withdraw:array<int,array<string,mixed>>}
 	 *
 	 * @spec openspec/specs/federated-catalog-sync/spec.md
 	 *

lib/Service/GebruikSyncService.php

@@ -82,6 +82,7 @@ class GebruikSyncService {
 	 * @param LoggerInterface $logger Logger for debugging and error reporting
 	 * @param SettingsService $settingsService Service for retrieving configuration settings
 	 * @param ContainerInterface $container DI container for lazy service resolution
+	 * @param ObjectServiceInterface $objectService OpenRegister object access (ADR-084 contract)
 	 */
 	public function __construct(
 		LoggerInterface $logger,

lib/Service/OrganizationSyncService.php

@@ -120,6 +120,8 @@ class OrganizationSyncService {
 	 * @param IDBConnection $db The database connection.
 	 * @param ContactPersonHandler $contactpersonHandler The contact person handler.
 	 * @param ContainerInterface $container The DI container.
+	 * @param ObjectServiceInterface $objectService OpenRegister object access (ADR-084 contract).
+	 * @param OrganisationMapper $organisationMapper Resolves the acting organisation for sync writes.
 	 */
 	public function __construct(
 		OrganisatieService $organisationService,