Skip to content

Commit 4fa8c1e

Browse files
author
Conduction Release Bot
committed
Merge remote-tracking branch 'origin/development' into beta
2 parents 6a55b72 + 2d3ceff commit 4fa8c1e

2 files changed

Lines changed: 24 additions & 21 deletions

File tree

lib/Settings/softwarecatalogus_register.json

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"info": {
44
"title": "Software Catalog Register",
55
"description": "Register containing AMEF and Voorzieningen schemas for the VNG Software Catalog application. This configuration includes schemas for applications, services, organizations, and compliance tracking.",
6-
"version": "2.3.0"
6+
"version": "2.3.1"
77
},
88
"x-openregister": {
99
"type": "application",
@@ -7189,7 +7189,7 @@
71897189
},
71907190
"title": "Applicatieversie",
71917191
"description": "Schema voor applicatieversies",
7192-
"version": "0.1.1",
7192+
"version": "0.1.2",
71937193
"summary": "",
71947194
"icon": "ViewModule",
71957195
"required": [],
@@ -7211,15 +7211,13 @@
72117211
"type": "string",
72127212
"order": 2,
72137213
"title": "Versie",
7214-
"maxLength": null,
72157214
"default": "1.0.0"
72167215
},
72177216
"pakketversie_beschrijving": {
72187217
"description": "Beschrijving van de pakketversie",
72197218
"type": "string",
72207219
"order": 2,
7221-
"title": "Pakketversie beschrijving",
7222-
"maxLength": null
7220+
"title": "Pakketversie beschrijving"
72237221
},
72247222
"beschrijvingKort": {
72257223
"description": "Een korte omschrijving van de versie (256 karakters)",
@@ -7233,8 +7231,7 @@
72337231
"type": "string",
72347232
"order": 4,
72357233
"title": "Beschrijving",
7236-
"format": "markdown",
7237-
"maxLength": null
7234+
"format": "markdown"
72387235
},
72397236
"status": {
72407237
"description": "Geef aan wat de status van de versie is.",

tests/e2e/workflows/crud-persistence.spec.ts

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,14 @@
2222
* COLUMNS both work in this deployed shell, so it is the canonical
2323
* UI-driven CRUD subject.
2424
* - Component (`module` schema) + Moduleversie — persistence proven at the
25-
* OpenRegister data layer (real create/find/update/delete verbs). Their
26-
* UI-create paths are NOT headlessly drivable here (the Component schema
27-
* has no manifest index page; the Moduleversie create form is blocked by a
28-
* `maxLength: null` validation bug), so the UI legs are documented
29-
* test.fixme. Organisatie has its own spec (organisatie-crud.spec.ts).
25+
* OpenRegister data layer (real create/find/update/delete verbs) AND the
26+
* Moduleversie UI-create leg is now driven end-to-end through the manifest
27+
* create modal (was previously blocked by a `maxLength: null` validation
28+
* bug on the `versie`/`pakketversie_beschrijving`/`beschrijvingLang` string
29+
* properties — fixed in the register schema, see the UI-create test below).
30+
* The Component schema still has no manifest index page, so its UI-create
31+
* leg is data-layer only. Organisatie has its own spec
32+
* (organisatie-crud.spec.ts).
3033
*
3134
* NOTE on other index pages: Contract (schema 41) requires object-reference
3235
* fields (`dienst`/`gebruik`) with no guaranteed referents; Reviews/Compliance
@@ -312,15 +315,18 @@ test.describe('Component (module) + Moduleversie persistence', () => {
312315
expect(del.ok()).toBeTruthy()
313316
})
314317

315-
// BUG (deployed nextcloud-vue CnIndexPage form validation): a string schema
316-
// property declared with an explicit `maxLength: null` (moduleVersie.versie,
317-
// pakketversie_beschrijving, beschrijvingLang) makes the create form render
318-
// "Maximum null characters." for any typed value and refuse to save — the
319-
// "Create" click never closes the dialog, so a Moduleversie can NOT be
320-
// created through the UI. (Creation via the OR API succeeds — see the
321-
// data-layer test above — so it is a FORM-VALIDATION defect, not a backend
322-
// one.) Re-enable this UI leg once the validator treats `maxLength: null` as
323-
// "no maximum".
318+
// REGRESSION GUARD (was a real bug): the moduleVersie create modal used to
319+
// refuse to save because the `versie` / `pakketversie_beschrijving` /
320+
// `beschrijvingLang` string properties were declared with an explicit
321+
// `maxLength: null`. The CnIndexPage form validator rendered "Maximum null
322+
// characters." for any typed value and blocked the "Create" click, so a
323+
// Moduleversie could not be created through the UI (a direct OR API create of
324+
// the same payload persisted fine, and the contactpersoon manifest create
325+
// worked — an isolated create-flow defect on the moduleVersie surface).
326+
// FIX: removed the `maxLength: null` declarations from those string
327+
// properties in lib/Settings/softwarecatalogus_register.json (absent = "no
328+
// maximum", matching the working contactpersoon string fields). This test
329+
// drives the real manifest create modal and asserts the new version persists.
324330
test('UI create -> module-version row appears', async ({ page }) => {
325331
await navClickTo(page, 'Module versions')
326332
const main = indexMain(page)

0 commit comments

Comments
 (0)