Skip to content

Commit 4f6da66

Browse files
committed
fix(tests): drop constructor arguments belonging to a same-named class
Several classes here share a FILE NAME with another in a different namespace — lib/Service/ChecklistService.php and lib/Service/Inspection/ChecklistService.php, BelplanRoutingService, HearingService and others. The arity fixer keyed constructors by that file name, so some constructions received arguments from the wrong class: Error: Unknown named parameter $settingsService Classes are now resolved through the file's own `use` imports, and the pass refuses to act unless it is certain: a constructor that exists but parses to nothing is treated as a PARSE FAILURE and skipped, never as "takes no arguments". It also reads only DEPTH-0 named arguments. A nested construction has its own constructor: new ProcestToolProvider( caseReader: new ProcestCaseReader( settingsService: $settingsService, <-- the INNER call's parameter logger: $logger, Judging those against the outer constructor is what made the first attempt delete valid arguments; that attempt was reverted, and this is its replacement.
1 parent cee771e commit 4f6da66

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

lib/Controller/ContactpersonenController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -993,7 +993,7 @@ private function verifyCrossTenantScope(\OCP\IUser $currentUser, string $usernam
993993
* made a nested reference compare unequal to a plain UUID, which both this
994994
* method's callers treat as "different tenant" (GH#459).
995995
*
996-
* @param object $this->objectService The OpenRegister ObjectService.
996+
* @param object $objectService The OpenRegister ObjectService.
997997
* @param string $username The username to look up.
998998
*
999999
* @return string|null The organisation UUID or null when not found.

lib/EventListener/UserProfileUpdatedEventListener.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ private function persistContactPersonPatch(
335335
/**
336336
* Find a contactpersoon by username, falling back to a case-insensitive email search.
337337
*
338-
* @param object $this->objectService The OpenRegister ObjectService.
338+
* @param object $objectService The OpenRegister ObjectService.
339339
* @param array $selfQuery The @self register/schema filter.
340340
* @param string $userId The Nextcloud user ID.
341341
* @param UserProfileUpdatedEvent $event The profile updated event.

0 commit comments

Comments
 (0)