Commit 3dc9f1a
committed
fix(e2e): .vs__search is a wrapper now, not the input
development is red on E2E with three failures, all the same error:
locator.fill: Element is not an <input>, <textarea>, <select>
or [contenteditable]
> 181 | await picker.fill(APP_A)
> 126 | await picker.fill(name)
@nextcloud/vue 9.10 reworked NcSelect -- 'fix(NcSelect): floating label
design using NcTextField' (#8570) -- and NcTextField renders a wrapper.
Observed on a live 9.11 build rather than inferred:
.vs__search -> <div class="input-field vs__search">
parent: div.vs__selected-options
inputInside: true
It used to BE the <input>; it is now a div that CONTAINS one. Targeting
the input inside restores the old meaning and reads correctly against
either version.
catalog-ratings.spec.ts is fixed too. It was not among the three
failures -- its test may not have reached that line -- but it holds the
identical selector and would fail the same way. Fixing the instance and
leaving the class is how this comes back.
Verified: the DOM shape was measured against a seeded launchpad-demo
instance on :8605 running a build against 9.11, not read off a
changelog.1 parent d802a5f commit 3dc9f1a
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
| 176 | + | |
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
| 179 | + | |
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
| |||
0 commit comments