Commit 313c49c
committed
fix(deps): node-polyfill-webpack-plugin is pinned to 4.0.0 by webpack-vue-config
npm ci cannot resolve, so every check dies before it runs:
npm error ERESOLVE could not resolve
While resolving: @nextcloud/webpack-vue-config@7.0.4
Found: node-polyfill-webpack-plugin@4.1.0
@nextcloud/webpack-vue-config declares node-polyfill-webpack-plugin as
EXACTLY "4.0.0" -- an exact version, not a caret range. 4.1.0 therefore
cannot satisfy it under any resolution, and the bump was uninstallable
the moment it landed.
I merged that bump unverified, on the reasoning that a MINOR version is
low risk. It is not, when the consumer pins an exact version: semver
tells you what the publisher intended, not what your dependency tree
will accept. This is the check the merge skipped.
Dependabot is told to hold it back, because it will keep proposing it --
it sees a newer version, not the exact pin holding it down.
Five apps carried the same combination; this is one of four fixed
together, decidiq being exempt because it is on webpack-vue-config v6,
which does not depend on the plugin at all.1 parent 7150283 commit 313c49c
2 files changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
36 | 42 | | |
37 | 43 | | |
38 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
0 commit comments