Skip to content

Commit 313c49c

Browse files
committed
fix(deps): node-polyfill-webpack-plugin is pinned to 4.0.0 by webpack-vue-config
npm ci cannot resolve, so every check dies before it runs: npm error ERESOLVE could not resolve While resolving: @nextcloud/webpack-vue-config@7.0.4 Found: node-polyfill-webpack-plugin@4.1.0 @nextcloud/webpack-vue-config declares node-polyfill-webpack-plugin as EXACTLY "4.0.0" -- an exact version, not a caret range. 4.1.0 therefore cannot satisfy it under any resolution, and the bump was uninstallable the moment it landed. I merged that bump unverified, on the reasoning that a MINOR version is low risk. It is not, when the consumer pins an exact version: semver tells you what the publisher intended, not what your dependency tree will accept. This is the check the merge skipped. Dependabot is told to hold it back, because it will keep proposing it -- it sees a newer version, not the exact pin holding it down. Five apps carried the same combination; this is one of four fixed together, decidiq being exempt because it is on webpack-vue-config v6, which does not depend on the plugin at all.
1 parent 7150283 commit 313c49c

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

.github/dependabot.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@ updates:
3333
target-branch: "development"
3434
schedule:
3535
interval: "weekly"
36+
ignore:
37+
# @nextcloud/webpack-vue-config pins this to EXACTLY "4.0.0" (not a
38+
# range), so 4.1.0 can never resolve: npm ci dies with ERESOLVE before
39+
# a single check runs. Dependabot proposes it anyway because it only
40+
# sees a newer version, not the exact pin holding it down.
41+
- dependency-name: "node-polyfill-webpack-plugin"
3642
open-pull-requests-limit: 10
3743
# HELD BACK DELIBERATELY, not out of caution. Each of these is blocked by a
3844
# package we do not control, and dependabot cannot see that, so it proposes

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"gridstack": "^12.6.0",
6363
"lodash": "^4.17.21",
6464
"marked": "^12.0.0",
65-
"node-polyfill-webpack-plugin": "4.1.0",
65+
"node-polyfill-webpack-plugin": "4.0.0",
6666
"path-browserify": "^1.0.1",
6767
"pinia": "^3.0.3",
6868
"sass": "^1.99.0",

0 commit comments

Comments
 (0)