Skip to content

Commit 28b7412

Browse files
author
Conduction Release Bot
committed
fix(quality): clear the three failures development was already carrying
The icon PR could not go green because stackiq development is red on its own account. All three are pre-existing, not introduced here. 1. Frontend Check (format): prettier flagged src/components/CatalogPanels.vue, a file this PR never touched. It has been failing on development since #892. Reformatted with the repo own config; the whole tree now reports "All matched files use Prettier code style!". 2. gate-60 icon-vocabulary FAILED, not warned: FileDocument and Web are named by src/manifest.json but were absent from src/icons.js, so both rendered as NOTHING. Registered. 3. gate-102 manifest-l10n-coverage: three manifest strings had no nl.json key, so they rendered English to a Dutch user. Two of them were the opposite problem, hardcoded DUTCH in a manifest whose menu labels are all English (Dashboard, Organisations, Applications, Suites, Services), so an English user saw Dutch: "Diensten" -> "Services" nl.json already had Services: Diensten "Object statistieken" -> "Object statistics" + new key "Modules" + new key, same word either way Only title and label were touched. The id, route and name values keep "Diensten" because they are identifiers, not copy. ⚠️ The keys were added to BOTH l10n/nl.json and l10n/nl.js. The browser reads the .js; a key in the .json alone is invisible to the user and check:l10n would still call the two in sync. Verified by loading nl.js and diffing the key sets: 760 each, 0 in one and not the other. Sentence case per the Conduction voice rules, not Title Case.
1 parent 2a68e00 commit 28b7412

5 files changed

Lines changed: 16 additions & 9 deletions

File tree

l10n/nl.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -758,7 +758,9 @@ OC.L10N.register(
758758
"Flow": "Flow",
759759
"Where the automation lives": "Waar de automatisering zit",
760760
"Flows are what happens without anyone clicking: a reminder before a deadline passes, a confirmation sent on submission. This is where you read and edit them. Nothing to build now.": "Flows zijn wat er gebeurt zonder dat iemand klikt: een herinnering voordat een termijn verstrijkt, een bevestiging bij indiening. Hier lees en bewerk je ze. Je hoeft nu niets te bouwen.",
761-
"Open Flows in the menu": "Open Flows in het menu"
761+
"Open Flows in the menu": "Open Flows in het menu",
762+
"Modules": "Modules",
763+
"Object statistics": "Object statistieken"
762764
},
763765
"nplurals=2; plural=(n != 1);"
764766
)

l10n/nl.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -757,6 +757,8 @@
757757
"Flow": "Flow",
758758
"Where the automation lives": "Waar de automatisering zit",
759759
"Flows are what happens without anyone clicking: a reminder before a deadline passes, a confirmation sent on submission. This is where you read and edit them. Nothing to build now.": "Flows zijn wat er gebeurt zonder dat iemand klikt: een herinnering voordat een termijn verstrijkt, een bevestiging bij indiening. Hier lees en bewerk je ze. Je hoeft nu niets te bouwen.",
760-
"Open Flows in the menu": "Open Flows in het menu"
760+
"Open Flows in the menu": "Open Flows in het menu",
761+
"Modules": "Modules",
762+
"Object statistics": "Object statistieken"
761763
}
762764
}

src/components/CatalogPanels.vue

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
<h3 class="infoBoxTitle">Beheer van Organisaties</h3>
66
<p class="infoBoxText">
77
Organisaties kunnen worden geaccepteerd en beheerd via de
8-
organisaties pagina. Het aanmaken en bewerken van gebruikers
9-
gaat ook via de organisatie pagina, omdat deze onderdeel zijn
10-
van organisaties.
8+
organisaties pagina. Het aanmaken en bewerken van gebruikers gaat
9+
ook via de organisatie pagina, omdat deze onderdeel zijn van
10+
organisaties.
1111
</p>
1212
<div class="infoBoxActions">
1313
<NcButton variant="primary" @click="navigateToOrganizations">
@@ -171,7 +171,6 @@ export default {
171171
},
172172
173173
computed: {
174-
175174
/**
176175
* Get object statistics for the table display
177176
*

src/icons.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import Database from 'vue-material-design-icons/Database.vue'
3434
import Domain from 'vue-material-design-icons/Domain.vue'
3535
import Eye from 'vue-material-design-icons/Eye.vue'
3636
import EyeOutline from 'vue-material-design-icons/EyeOutline.vue'
37+
import FileDocument from 'vue-material-design-icons/FileDocument.vue'
3738
import FileDocumentEdit from 'vue-material-design-icons/FileDocumentEdit.vue'
3839
import FileSign from 'vue-material-design-icons/FileSign.vue'
3940
import FolderOutline from 'vue-material-design-icons/FolderOutline.vue'
@@ -65,6 +66,7 @@ import TransitConnectionVariant from 'vue-material-design-icons/TransitConnectio
6566
import ViewDashboardOutline from 'vue-material-design-icons/ViewDashboardOutline.vue'
6667
import ViewGridOutline from 'vue-material-design-icons/ViewGridOutline.vue'
6768
import ViewModule from 'vue-material-design-icons/ViewModule.vue'
69+
import Web from 'vue-material-design-icons/Web.vue'
6870

6971
export default {
7072
AccountBoxOutline,
@@ -89,6 +91,7 @@ export default {
8991
Domain,
9092
Eye,
9193
EyeOutline,
94+
FileDocument,
9295
FileDocumentEdit,
9396
FileSign,
9497
FolderOutline,
@@ -120,4 +123,5 @@ export default {
120123
ViewDashboardOutline,
121124
ViewGridOutline,
122125
ViewModule,
126+
Web,
123127
}

src/manifest.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,9 @@
246246
{
247247
"id": "kpi-services",
248248
"type": "stat",
249-
"title": "Diensten",
249+
"title": "Services",
250250
"content": {
251-
"label": "Diensten",
251+
"label": "Services",
252252
"icon": "Web",
253253
"route": {
254254
"name": "Diensten"
@@ -288,7 +288,7 @@
288288
{
289289
"id": "catalog-panels",
290290
"type": "catalog-panels",
291-
"title": "Object statistieken",
291+
"title": "Object statistics",
292292
"_note": "The management info-box and the two per-object-type statistics tables, moved out of the former hand-written Dashboard view into src/components/CatalogPanels.vue. Registered as a widget TYPE via registerDashboardWidget() in main.js: CnDashboardPage resolves a widget's type against the LIBRARY catalog, not the app registry, and an unregistered type renders 'Widget not available' silently."
293293
}
294294
],

0 commit comments

Comments
 (0)