fix: Resolve all PHPCS errors across ArchiMate services #7
code-quality.yml
on: push
quality
/
Composer Audit
16s
quality
/
npm Audit
21s
quality
/
PHP Lint
21s
quality
/
PHPCS
31s
quality
/
PHPMD
33s
quality
/
Psalm
29s
quality
/
PHPStan
46s
quality
/
phpmetrics
48s
quality
/
ESLint
34s
quality
/
Stylelint
23s
quality
/
Coverage Baseline Protection
Matrix: quality / php-tests
quality
/
Update Coverage Baseline
0s
quality
/
Quality Summary
4s
Annotations
27 errors and 17 warnings
|
quality / Stylelint
Process completed with exit code 2.
|
|
InvalidArgument:
lib/Service/ArchiMateImportService.php#L5949
lib/Service/ArchiMateImportService.php:5949:34: InvalidArgument: Calling empty on a boolean value is almost certainly unintended (see https://psalm.dev/004)
|
|
InvalidArgument:
lib/Service/ArchiMateImportService.php#L5947
lib/Service/ArchiMateImportService.php:5947:34: InvalidArgument: Calling empty on a boolean value is almost certainly unintended (see https://psalm.dev/004)
|
|
InvalidArgument:
lib/Service/ArchiMateImportService.php#L5945
lib/Service/ArchiMateImportService.php:5945:34: InvalidArgument: Calling empty on a boolean value is almost certainly unintended (see https://psalm.dev/004)
|
|
InvalidArgument:
lib/Service/ArchiMateImportService.php#L5943
lib/Service/ArchiMateImportService.php:5943:27: InvalidArgument: Calling empty on a boolean value is almost certainly unintended (see https://psalm.dev/004)
|
|
UndefinedFunction:
lib/Service/ArchiMateImportService.php#L3250
lib/Service/ArchiMateImportService.php:3250:106: UndefinedFunction: Function OCA\SoftwareCatalog\Service\falsey does not exist (see https://psalm.dev/021)
|
|
UndefinedThisPropertyFetch:
lib/Service/ArchiMateImportService.php#L3250
lib/Service/ArchiMateImportService.php:3250:81: UndefinedThisPropertyFetch: Instance property OCA\SoftwareCatalog\Service\ArchiMateImportService::$isComplexArra is not defined (see https://psalm.dev/041)
|
|
UndefinedVariable:
lib/Service/ArchiMateExportService.php#L2256
lib/Service/ArchiMateExportService.php:2256:80: UndefinedVariable: Cannot find referenced variable $propRef (see https://psalm.dev/024)
|
|
InvalidArgument:
lib/Service/ArchiMateExportService.php#L1597
lib/Service/ArchiMateExportService.php:1597:31: InvalidArgument: Calling empty on a boolean value is almost certainly unintended (see https://psalm.dev/004)
|
|
InvalidArgument:
lib/Service/ArchiMateExportService.php#L1552
lib/Service/ArchiMateExportService.php:1552:31: InvalidArgument: Calling empty on a boolean value is almost certainly unintended (see https://psalm.dev/004)
|
|
InvalidArgument:
lib/Service/ArchiMateExportService.php#L282
lib/Service/ArchiMateExportService.php:282:23: InvalidArgument: Calling empty on a boolean value is almost certainly unintended (see https://psalm.dev/004)
|
|
quality / PHPCS
Process completed with exit code 1.
|
|
quality / ESLint
Process completed with exit code 1.
|
|
quality / ESLint:
src/views/organisaties/OrganisatieIndex.vue#L70
Unable to resolve path to module '@conduction/nextcloud-vue'
|
|
quality / ESLint:
src/store/plugins/softwarecatalogPlugin.js#L14
Unable to resolve path to module '@conduction/nextcloud-vue'
|
|
quality / ESLint:
src/store/modules/object.js#L18
Unable to resolve path to module '@conduction/nextcloud-vue'
|
|
quality / ESLint:
src/App.vue#L26
Unable to resolve path to module '@conduction/nextcloud-vue'
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L110
Call to method registerService() on an unknown class OCP\AppFramework\Bootstrap\IRegistrationContext.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L104
Class OCP\App\IAppManager not found.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L102
Class OCP\IUserManager not found.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L101
Class OCP\IGroupManager not found.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L97
Call to method registerService() on an unknown class OCP\AppFramework\Bootstrap\IRegistrationContext.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L92
Parameter $context of method OCA\SoftwareCatalog\AppInfo\Application::register() has invalid type OCP\AppFramework\Bootstrap\IRegistrationContext.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L92
Parameter $context of method OCA\SoftwareCatalog\AppInfo\Application::register() has invalid type OCP\AppFramework\Bootstrap\IRegistrationContext.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L82
OCA\SoftwareCatalog\AppInfo\Application::__construct() calls parent::__construct() but OCA\SoftwareCatalog\AppInfo\Application does not extend any class.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L70
Class OCA\SoftwareCatalog\AppInfo\Application implements unknown interface OCP\AppFramework\Bootstrap\IBootstrap.
|
|
quality / PHPStan:
lib/AppInfo/Application.php#L70
Class OCA\SoftwareCatalog\AppInfo\Application extends unknown class OCP\AppFramework\App.
|
|
quality / Composer Audit
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, shivammathur/setup-php@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / npm Audit
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / PHP Lint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, shivammathur/setup-php@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / Stylelint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / Psalm
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, shivammathur/setup-php@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / PHPCS
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, shivammathur/setup-php@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / PHPMD
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, shivammathur/setup-php@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / ESLint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / ESLint:
src/views/organisaties/OrganisatieIndex.vue#L422
Missing JSDoc @PARAM "limit" declaration
|
|
quality / ESLint:
src/views/organisaties/OrganisatieIndex.vue#L422
Missing JSDoc @PARAM "page" declaration
|
|
quality / ESLint:
src/store/plugins/softwarecatalogPlugin.js#L872
Defaults are not permitted on @PARAM
|
|
quality / ESLint:
src/store/plugins/softwarecatalogPlugin.js#L781
Defaults are not permitted on @PARAM
|
|
quality / ESLint:
src/store/plugins/softwarecatalogPlugin.js#L780
Defaults are not permitted on @PARAM
|
|
quality / ESLint:
src/store/plugins/softwarecatalogPlugin.js#L32
Defaults are not permitted on @PARAM
|
|
quality / ESLint:
src/modals/Modals.vue#L74
The "setup" property should be above the "computed" property on line 59
|
|
quality / PHPStan
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, shivammathur/setup-php@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
quality / phpmetrics
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, shivammathur/setup-php@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|