From 5159d2bb2591f1273f9b61a945a5903a8da4f97c Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Sun, 30 Aug 2026 13:13:29 +0200 Subject: [PATCH 1/3] fix(sidebar): render the manifest page's sidebar alongside our own (#1356) * fix(sidebar): render the manifest page's sidebar alongside our own This app fills CnAppRoot's `#sidebar` slot, and Vue only renders a slot's fallback when the slot is ABSENT. So filling it suppressed `pages[].sidebarComponent` silently: no warning, no error, no sidebar. The ADR-110 flow sidebar was declared in the manifest, registered in registry.js and present in the bundle, and still never rendered. Nine apps in the fleet fill this slot and all nine were affected. The five that do not fill it rendered the flow sidebar correctly, which is what identified the cause. CnAppRoot now passes the resolved component to the slot (nextcloud-vue#857), so this renders both: our own rail, and whatever the routed manifest page asks for. Verified: npm run build exits 0. * chore(deps): @conduction/nextcloud-vue 2.24.3, which carries the sidebar slot prop 2.24.3 is the release that passes the resolved `pages[].sidebarComponent` into CnAppRoot's `#sidebar` slot. Without it the App.vue change in this branch is a no-op, because the slot prop it reads does not exist yet. Verified on filinq in the browser against the dev instance: the flow rail (Flow, Steps, Runs, Version, Publish, the trigger list) now renders next to the canvas, and the app's own sidebar still mounts alongside it. --- package-lock.json | 8 ++++---- package.json | 2 +- src/App.vue | 8 +++++++- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 8947df01d..005a0a0cc 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,7 @@ "version": "0.2.1", "license": "EUPL-1.2", "dependencies": { - "@conduction/nextcloud-vue": "^2.24.2", + "@conduction/nextcloud-vue": "^2.24.3", "@nextcloud/auth": "^2.6.0", "@nextcloud/axios": "~2.5.2", "@nextcloud/capabilities": "^1.2.1", @@ -644,9 +644,9 @@ } }, "node_modules/@conduction/nextcloud-vue": { - "version": "2.24.2", - "resolved": "https://registry.npmjs.org/@conduction/nextcloud-vue/-/nextcloud-vue-2.24.2.tgz", - "integrity": "sha512-BGvyJpRhzvLraZuyRB3ETJ6IESV27XZvL5vdvLd5kEvettFo+QWIo6JcHJhQk9np8QYGHBQ9gRHCp3v6y7Y2gw==", + "version": "2.24.3", + "resolved": "https://registry.npmjs.org/@conduction/nextcloud-vue/-/nextcloud-vue-2.24.3.tgz", + "integrity": "sha512-Hflys+AxGNNSkDxuMf04RdFzijhWDKtcRJAHtmtYLj6ntwoIT51k0rfRju6S5GuTNF+daJDUv9tHDVVXb9ZIWw==", "license": "EUPL-1.2", "dependencies": { "@ckpack/vue-color": "^1.6.0", diff --git a/package.json b/package.json index 2d2f4811c..4bee6b113 100644 --- a/package.json +++ b/package.json @@ -50,7 +50,7 @@ "extends @nextcloud/browserslist-config" ], "dependencies": { - "@conduction/nextcloud-vue": "^2.24.2", + "@conduction/nextcloud-vue": "^2.24.3", "@nextcloud/auth": "^2.6.0", "@nextcloud/axios": "~2.5.2", "@nextcloud/capabilities": "^1.2.1", diff --git a/src/App.vue b/src/App.vue index cbb00d5d5..b59838c08 100644 --- a/src/App.vue +++ b/src/App.vue @@ -26,7 +26,7 @@ `objectSidebarState` when a detail page enables `config.sidebar`; this slot renders the tabs. Mirrors the decidesk / procest shell pattern. --> - From ec4d40a84ec7eb4f11500af6bfe459afc9154df9 Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Sun, 30 Aug 2026 14:31:57 +0200 Subject: [PATCH 2/3] chore(deps): @conduction/nextcloud-vue 2.24.4, which supports pinia 4 (#1360) This app is on pinia 4. Until 2.24.4 the library peered `^2.0.0 || ^3.0.0`, so the single pinia in this tree was a version the library did not accept. 2.24.4 widens that peer (nextcloud-vue#860), which makes the pairing correct rather than merely installable. Note this does NOT by itself fix the blank render: shillinq still mounts an empty `#content-vue` with no JS error, so there is a second cause still to find. The dependency pairing is right either way, and leaving the app on an unsupported combination would only obscure the remaining fault. Verified: npm install and npm run build both exit 0. --- package-lock.json | 10 +++++----- package.json | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 005a0a0cc..ecea12c76 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,7 @@ "version": "0.2.1", "license": "EUPL-1.2", "dependencies": { - "@conduction/nextcloud-vue": "^2.24.3", + "@conduction/nextcloud-vue": "^2.24.4", "@nextcloud/auth": "^2.6.0", "@nextcloud/axios": "~2.5.2", "@nextcloud/capabilities": "^1.2.1", @@ -644,9 +644,9 @@ } }, "node_modules/@conduction/nextcloud-vue": { - "version": "2.24.3", - "resolved": "https://registry.npmjs.org/@conduction/nextcloud-vue/-/nextcloud-vue-2.24.3.tgz", - "integrity": "sha512-Hflys+AxGNNSkDxuMf04RdFzijhWDKtcRJAHtmtYLj6ntwoIT51k0rfRju6S5GuTNF+daJDUv9tHDVVXb9ZIWw==", + "version": "2.24.4", + "resolved": "https://registry.npmjs.org/@conduction/nextcloud-vue/-/nextcloud-vue-2.24.4.tgz", + "integrity": "sha512-Q65rPltPvWbhT2gjK7EreZoJ+78+eFkkC+VZZYE72Yat8gfKP4QTl9xmMGrv3OGVy6z3CKZPV17Z3GBI7GgJuA==", "license": "EUPL-1.2", "dependencies": { "@ckpack/vue-color": "^1.6.0", @@ -710,7 +710,7 @@ "eslint-plugin-vue": "^9.21.0 || ^10.0.0", "gridstack": "^12.0.0 || ^13.0.0", "marked": "^12.0.0", - "pinia": "^2.0.0 || ^3.0.0", + "pinia": "^2.0.0 || ^3.0.0 || ^4.0.0", "vue": "^3.5.0", "vue-eslint-parser": "^9.4.0 || ^10.0.0", "vue-material-design-icons": "^5.0.0" diff --git a/package.json b/package.json index 4bee6b113..5d587937d 100644 --- a/package.json +++ b/package.json @@ -50,7 +50,7 @@ "extends @nextcloud/browserslist-config" ], "dependencies": { - "@conduction/nextcloud-vue": "^2.24.3", + "@conduction/nextcloud-vue": "^2.24.4", "@nextcloud/auth": "^2.6.0", "@nextcloud/axios": "~2.5.2", "@nextcloud/capabilities": "^1.2.1", From ff6be621c684d90bb56bf16a2c248de1356b64cf Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Sun, 30 Aug 2026 15:48:55 +0200 Subject: [PATCH 3/3] style: run Prettier over the sidebar change (#1363) The 'render the manifest page's sidebar alongside our own' commit landed unformatted, and quality / Frontend Check (format) has been red on development ever since. Eight apps took the same change and eight went red together. prettier --write over the affected files and nothing else. Verified: npm run format exits 0. --- src/App.vue | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/App.vue b/src/App.vue index b59838c08..1e5930a4d 100644 --- a/src/App.vue +++ b/src/App.vue @@ -46,9 +46,7 @@ - +