phpmd.baseline.xml

<?xml version="1.0"?>
<!--
  PHPMD baseline — RETAINED, not deleted, and DELIBERATELY SMALLER.

  Part of the fleet suppression audit (ConductionNL/.github#155). Measured with
  PHPMD 2.15.0 / PHP 8.4.22, exit code read directly:

      reported with this baseline      0
      baseline deleted, before the PR  44   (what the 39 old entries hid)
      baseline deleted, after the PR   30

  The 14 findings that are gone were FIXED, not re-baselined; their entries are
  removed below, so the gate genuinely covers those files again. Deleting an
  entry whose finding no longer exists is the point: a file-scoped entry (one
  with no `method` attribute) suppresses EVERY future finding of that rule in
  that file, so a stale entry is a dead gate, not a harmless leftover.

  A further 3 entries (UnusedFormalParameter on CallbackOverdueJob,
  EmailSyncJob, TaskEscalationJob) are gone because the exclusion moved to
  phpmd-unusedparams.xml, where it is scoped to lib/BackgroundJob and states its
  own reason: OCP\BackgroundJob\TimedJob declares
  `abstract protected function run($argument)`, so a job that needs no argument
  still cannot drop the parameter.

  WHAT REMAINS (30 findings, 27 entries) and why the file is still here:

  * 6 x WeightedMethodCount (ExcessiveClassComplexity) — Application 66,
    SemanticHandoffController 50, MigrateAvgVerzoekenToOrDsar 81,
    DemoSeedService 62, TimeBillingHandoffService 82, TrackingLinkService 79,
    against a threshold of 50. WMC is the SUM of every method's cyclomatic
    complexity, so it only falls when logic moves to another class — splitting a
    method in place makes it WORSE. Each needs a cohesive-collaborator
    extraction, which is a behaviour-bearing refactor with its own review, not
    a suppression sweep.

  * 24 method- and class-level findings (CyclomaticComplexity, NPathComplexity,
    LongMethod, LongParameterList, StaticAccess, TooManyPublicMethods,
    CouplingBetweenObjects) that are genuine, fixable debt — they were simply
    out of scope for this pass.

  Deleting this file today would redden `development` for everyone with 30 real
  findings, which helps nobody. It stays until the remainder is burned down.

  This baseline is a RATCHET: any NEW violation outside these entries fails the
  gate. Do NOT regenerate it to silence a new finding, and do NOT re-add an
  entry that a fix has retired.
-->
<phpmd-baseline>
  <violation rule="PHPMD\Rule\Design\WeightedMethodCount" file="lib/AppInfo/Application.php"/>
  <violation rule="PHPMD\Rule\Design\LongParameterList" file="lib/Controller/PortalController.php" method="__construct"/>
  <violation rule="PHPMD\Rule\Design\WeightedMethodCount" file="lib/Controller/SemanticHandoffController.php"/>
  <violation rule="PHPMD\Rule\Design\LongMethod" file="lib/Notification/Notifier.php" method="applyNotificationSubject"/>
  <violation rule="PHPMD\Rule\Design\LongMethod" file="lib/Portal/PortalContributionProvider.php" method="clientContribution"/>
  <violation rule="PHPMD\Rule\Design\WeightedMethodCount" file="lib/Repair/MigrateAvgVerzoekenToOrDsar.php"/>
  <violation rule="PHPMD\Rule\Design\LongMethod" file="lib/Repair/MigrateAvgVerzoekenToOrDsar.php" method="migrateOne"/>
  <violation rule="PHPMD\Rule\Design\CouplingBetweenObjects" file="lib/Repair/UnifyClientContactIdentity.php"/>
  <violation rule="PHPMD\Rule\Design\LongMethod" file="lib/Repair/UnifyClientContactIdentity.php" method="migrate"/>
  <violation rule="PHPMD\Rule\Design\WeightedMethodCount" file="lib/Service/DemoSeedService.php"/>
  <violation rule="PHPMD\Rule\Design\LongParameterList" file="lib/Service/EmailSyncService.php" method="buildEmailLinkData"/>
  <violation rule="PHPMD\Rule\CyclomaticComplexity" file="lib/Service/LeadService.php" method="createLead"/>
  <violation rule="PHPMD\Rule\Design\NpathComplexity" file="lib/Service/LeadService.php" method="createLead"/>
  <violation rule="PHPMD\Rule\Design\TooManyPublicMethods" file="lib/Service/NotificationService.php"/>
  <violation rule="PHPMD\Rule\CleanCode\StaticAccess" file="lib/Service/Payment/BrokerHttpTransport.php"/>
  <violation rule="PHPMD\Rule\CyclomaticComplexity" file="lib/Service/Payment/CurlHttpTransport.php" method="request"/>
  <violation rule="PHPMD\Rule\Design\NpathComplexity" file="lib/Service/Payment/CurlHttpTransport.php" method="request"/>
  <violation rule="PHPMD\Rule\CleanCode\StaticAccess" file="lib/Service/PosPaymentService.php"/>
  <violation rule="PHPMD\Rule\CyclomaticComplexity" file="lib/Service/TicketService.php" method="logContactmoment"/>
  <violation rule="PHPMD\Rule\Design\NpathComplexity" file="lib/Service/TicketService.php" method="logContactmoment"/>
  <violation rule="PHPMD\Rule\Design\WeightedMethodCount" file="lib/Service/TimeBillingHandoffService.php"/>
  <violation rule="PHPMD\Rule\CyclomaticComplexity" file="lib/Service/TimeBillingHandoffService.php" method="selectBatch"/>
  <violation rule="PHPMD\Rule\Design\NpathComplexity" file="lib/Service/TimeBillingHandoffService.php" method="selectBatch"/>
  <violation rule="PHPMD\Rule\CyclomaticComplexity" file="lib/Service/TimeBillingHandoffService.php" method="notifyPendingFailures"/>
  <violation rule="PHPMD\Rule\Design\NpathComplexity" file="lib/Service/TimeBillingHandoffService.php" method="notifyPendingFailures"/>
  <violation rule="PHPMD\Rule\Design\WeightedMethodCount" file="lib/Service/TrackingLinkService.php"/>
  <violation rule="PHPMD\Rule\CyclomaticComplexity" file="lib/Service/TrackingLinkService.php" method="extractId"/>
</phpmd-baseline>