Merge pull request #1355 from ConductionNL/development

Merge development to beta

Author: rjzondervan

.git-blame-ignore-revs

@@ -0,0 +1,3 @@
+# Retrofit annotation commits (opsx-annotate, 2026-04-23)
+197da46fc795acb5052f1557f675dbf14d8d24f0
+5e0d5a800318df890f69328e6ea25f685316a167

.github/workflows/quality.yml

@@ -2,8 +2,9 @@ name: Code Quality
 
 on:
   push:
-    branches: [main, development, feature/**, bugfix/**, hotfix/**]
+    branches: [main, beta, development, feature/**, bugfix/**, hotfix/**]
   pull_request:
+    types: [opened, reopened]
     branches: [main, beta, development]
   workflow_dispatch:
 
@@ -13,6 +14,7 @@ concurrency:
 
 jobs:
   quality:
+    if: github.event_name != 'push' || github.event.created != true
     uses: ConductionNL/.github/.github/workflows/quality.yml@main
     with:
       app-name: openregister

composer.lock

@@ -16,6 +16,9 @@
  * @version GIT: <git_id>
  *
  * @link https://www.OpenRegister.app
+ *
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-63
  */
 
 declare(strict_types=1);
@@ -161,6 +164,8 @@ protected function run($argument): void
      * @return void
      *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-63
      */
     private function sendPreDestructionNotifications(
         RetentionService $retentionService,
@@ -299,6 +304,8 @@ private function sendObjectNotification(
      * @param LoggerInterface $logger      Logger
      *
      * @return void
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
      */
     private function sendReviewNotification(
         string $listUuid,

lib/BackgroundJob/DestructionCheckJob.php

@@ -17,6 +17,9 @@
  * @version GIT: <git_id>
  *
  * @link https://www.OpenRegister.app
+ *
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-5
  */
 
 declare(strict_types=1);
@@ -72,6 +75,8 @@ public function __construct(ITimeFactory $time)
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
      */
     protected function run($argument): void
     {
@@ -238,6 +243,8 @@ protected function run($argument): void
      * @param LoggerInterface $logger       Logger
      *
      * @return void
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-5
      */
     private function notifySkippedHolds(
         string $listUuid,

lib/BackgroundJob/DestructionExecutionJob.php

@@ -15,6 +15,8 @@
  * @version GIT: <git-id>
  *
  * @link https://www.OpenRegister.app
+ *
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-72
  */
 
 declare(strict_types=1);
@@ -83,6 +85,8 @@ public function __construct(
      * @return void
      *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-72
      */
     protected function run($argument): void
     {

lib/BackgroundJob/HookRetryJob.php

@@ -15,6 +15,8 @@
  * @version GIT: <git-id>
  *
  * @link https://www.OpenRegister.app
+ *
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-83
  */
 
 declare(strict_types=1);
@@ -192,6 +194,8 @@ private function evaluateSchedule(ScheduledWorkflow $schedule): void
      * @param string            $error     Error message
      *
      * @return void
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-83
      */
     private function handleError(ScheduledWorkflow $schedule, $startTime, string $error): void
     {

lib/BackgroundJob/ScheduledWorkflowJob.php

@@ -15,6 +15,8 @@
  * @version GIT: <git-id>
  *
  * @link https://www.OpenRegister.app
+ *
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-79
  */
 
 declare(strict_types=1);
@@ -118,6 +120,8 @@ public function __construct(
      *                                       - attempt: Current attempt number (default: 1)
      *
      * @return void
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-79
      */
     protected function run($argument): void
     {

lib/BackgroundJob/WebhookDeliveryJob.php

@@ -16,6 +16,9 @@
  * @version GIT: <git_id>
  *
  * @link https://www.OpenRegister.app
+ *
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-5
  */
 
 namespace OCA\OpenRegister\Controller;
@@ -131,6 +134,8 @@ public function __construct(
      * @return JSONResponse The list of destruction lists.
      *
      * @NoAdminRequired
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
      */
     public function listDestructionLists(): JSONResponse
     {
@@ -161,6 +166,8 @@ public function listDestructionLists(): JSONResponse
      * @return JSONResponse The destruction list detail.
      *
      * @NoAdminRequired
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
      */
     public function getDestructionList(string $id): JSONResponse
     {
@@ -191,6 +198,8 @@ public function getDestructionList(string $id): JSONResponse
      * @return JSONResponse The updated destruction list.
      *
      * @NoAdminRequired
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
      */
     public function approveDestructionList(string $id): JSONResponse
     {
@@ -258,6 +267,8 @@ public function approveDestructionList(string $id): JSONResponse
      * @return JSONResponse The updated destruction list.
      *
      * @NoAdminRequired
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
      */
     public function rejectDestructionList(string $id): JSONResponse
     {
@@ -439,6 +450,8 @@ public function releaseLegalHold(string $id): JSONResponse
      * @return JSONResponse The list of active legal holds.
      *
      * @NoAdminRequired
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-5
      */
     public function listLegalHolds(): JSONResponse
     {
@@ -463,6 +476,8 @@ public function listLegalHolds(): JSONResponse
      * @return JSONResponse The list of destruction certificates.
      *
      * @NoAdminRequired
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
      */
     public function listCertificates(): JSONResponse
     {
@@ -486,6 +501,8 @@ public function listCertificates(): JSONResponse
      * Check if the current user has the archivist role.
      *
      * @return JSONResponse|null Returns a 403 response if unauthorized, null if authorized.
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-2
      */
     private function checkArchivistRole(): ?JSONResponse
     {

lib/Controller/ArchivalController.php

@@ -17,6 +17,8 @@
  * @version GIT: <git-id>
  *
  * @link https://OpenRegister.app
+ *
+ * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
  */
 
 namespace OCA\OpenRegister\Controller;
@@ -67,6 +69,8 @@ public function __construct(
      *
      * @SuppressWarnings(PHPMD.NPathComplexity)      Request parameter extraction requires many conditional checks
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     private function extractRequestParameters(): array
     {
@@ -180,6 +184,8 @@ function ($key) {
      *     array{results: array<\OCA\OpenRegister\Db\AuditTrail>,
      *     total: int<0, max>, page: int|null, pages: float, limit: int,
      *     offset: int|null}, array<never, never>>
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function index(): JSONResponse
     {
@@ -225,6 +231,8 @@ public function index(): JSONResponse
      *     array{error: 'Audit trail not found'},
      *     array<never, never>
      * >
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function show(int $id): JSONResponse
     {
@@ -247,6 +255,8 @@ public function show(int $id): JSONResponse
      * @NoCSRFRequired
      *
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function update(int $id): JSONResponse
     {
@@ -274,6 +284,8 @@ public function update(int $id): JSONResponse
      *     results?: array<\OCA\OpenRegister\Db\AuditTrail>,
      *     total?: int<0, max>, page?: int|null, pages?: float, limit?: int,
      *     offset?: int|null}, array<never, never>>
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function objects(string $register, string $schema, string $id): JSONResponse
     {
@@ -318,6 +330,8 @@ public function objects(string $register, string $schema, string $id): JSONRespo
      * @NoCSRFRequired
      *
      * @return JSONResponse JSON response with export data or error
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function export(): JSONResponse
     {
@@ -387,6 +401,8 @@ public function export(): JSONResponse
      * @NoCSRFRequired
      *
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function destroy(int $id): JSONResponse
     {
@@ -404,6 +420,8 @@ public function destroy(int $id): JSONResponse
      * @NoCSRFRequired
      *
      * @return JSONResponse JSON response with deletion results or error
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function destroyMultiple(): JSONResponse
     {
@@ -462,6 +480,8 @@ public function destroyMultiple(): JSONResponse
      * @NoCSRFRequired
      *
      * @return JSONResponse JSON response confirming clear or error
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function clearAll(): JSONResponse
     {
@@ -506,6 +526,8 @@ public function clearAll(): JSONResponse
      * @NoCSRFRequired
      *
      * @return JSONResponse Verification result with valid/invalid status
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function verify(): JSONResponse
     {
@@ -538,6 +560,8 @@ public function verify(): JSONResponse
      * @return JSONResponse List of processing activities
      *
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function verwerkingsregister(): JSONResponse
     {
@@ -564,6 +588,8 @@ public function verwerkingsregister(): JSONResponse
      * @NoCSRFRequired
      *
      * @return JSONResponse Matching audit trail entries grouped by schema
+     *
+     * @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-8
      */
     public function inzageverzoek(): JSONResponse
     {