Commit de1bed0
fix(gates): the run address names the spec it implements, and why it has no baseline (#3471)
Hydra Gates has been red on development since #3462, on two findings that
are the same new file:
[gate-16] spec-coverage: 1 changed method missing @SPEC
[gate-26] visual-coverage: 1 new page component missing a visual baseline
Both are src/views/flows/FlowRunDetail.vue.
gate-16: `resolve()` now carries @SPEC pointing at the flow-runs-subject-scope
spec, which is where the deep link this page implements is written down: "the
run uuid in the row is the deep link to it". The path was opened and read
rather than guessed. A tag the gate accepts but that resolves to nothing
clears the finding without covering anything, and that is worth stating
because the gate cannot tell the difference.
gate-26: an @visual exclude with its reason, rather than a baseline. This
page has no screen. It is a resolver: the spinner is replaced by the flow
editor as soon as the run resolves, and the failure state is one
NcEmptyContent whose pixels say nothing the flow editor's own baselines do
not already cover.
WHAT IS STILL MISSING, PLAINLY. The behaviour here is worth a test and does
not have one: that a cold load of /flow-runs/{uuid} reaches the flow rather
than the manifest's catch-all, that Back does not bounce because the handover
replaces rather than pushes, and that an absent run says so at its own
address. I wrote that spec and could not run it: this workstation's instance
carries 30-odd apps and the shared global setup times out logging in at 30s,
twice, before any test starts. Rather than ship a playwright spec whose only
evidence is that it reads correctly, the exclude says what is not covered and
the comment in the file says what to write. The gap is named, not hidden.
Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 15d9832 commit de1bed0
1 file changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
24 | 34 | | |
25 | 35 | | |
26 | 36 | | |
| |||
92 | 102 | | |
93 | 103 | | |
94 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
95 | 109 | | |
96 | 110 | | |
97 | 111 | | |
| |||
0 commit comments