Commit c130aa2
fix(nav): let users reach Personal settings again (#3367)
* fix(nav): let users reach Personal settings again
The manifest carried `nav.includePersonalSettings: false`, which turns off the
entry CnAppNav auto-prepends at the top of the settings foldout. There was no
note saying why, and nothing replaced it.
That entry is not decoration. It opens CnAppRoot's NcAppSettingsDialog, whose
`#user-settings` slot falls back to the user's NOTIFICATION PREFERENCES and
renders the ADR-110 Integrations section below them. Suppressing the entry put
both out of reach from inside the app entirely.
The flag is legitimate for an app that declares its own entry with
`action: "user-settings"`, which opens the same dialog: keepiq does exactly
that and injects its own Session / Security / Encryption sections into the
slot, so re-enabling the shell copy there would give it two entries onto one
dialog. This app declares no such entry, so the flag was simply hiding a
surface.
Found by pointing gate-107 (ADR-114, the seven-item app chrome) at the fleet:
three apps set this flag, and only keepiq had a replacement.
* fix(spec-tags): repair the anchor truncated mid-word in TaskSequenceMapper
gate-46 (spec-anchor-existence) fails openregister on `development`, and every
branch cut from it inherits the red. One tag, one file:
lib/Db/TaskSequenceMapper.php:122
…spec.md#requirement-an-approval-is-an-ordered-task-sequence-with-o
The anchor stops mid-word at `with-o`. Three sibling tags in the same file
(lines 26, 62 and 149) carry the full
`…-with-one-position-enabled-at-a-time`, and the heading it names exists in
the spec, so this is a truncation rather than a stale reference to something
that moved.
Verified by running the gate's own checker over every tracked lib/**/*.php:
1 finding before, 0 after. Fixing the TARGET rather than each tag, as the gate
asks — here the target was right all along and the tag was wrong.
---------
Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>1 parent 0961e89 commit c130aa2
2 files changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | 29 | | |
33 | 30 | | |
34 | 31 | | |
| |||
0 commit comments