Skip to content

Commit c130aa2

Browse files
rubenvdlindeConduction Release Bot
andauthored
fix(nav): let users reach Personal settings again (#3367)
* fix(nav): let users reach Personal settings again The manifest carried `nav.includePersonalSettings: false`, which turns off the entry CnAppNav auto-prepends at the top of the settings foldout. There was no note saying why, and nothing replaced it. That entry is not decoration. It opens CnAppRoot's NcAppSettingsDialog, whose `#user-settings` slot falls back to the user's NOTIFICATION PREFERENCES and renders the ADR-110 Integrations section below them. Suppressing the entry put both out of reach from inside the app entirely. The flag is legitimate for an app that declares its own entry with `action: "user-settings"`, which opens the same dialog: keepiq does exactly that and injects its own Session / Security / Encryption sections into the slot, so re-enabling the shell copy there would give it two entries onto one dialog. This app declares no such entry, so the flag was simply hiding a surface. Found by pointing gate-107 (ADR-114, the seven-item app chrome) at the fleet: three apps set this flag, and only keepiq had a replacement. * fix(spec-tags): repair the anchor truncated mid-word in TaskSequenceMapper gate-46 (spec-anchor-existence) fails openregister on `development`, and every branch cut from it inherits the red. One tag, one file: lib/Db/TaskSequenceMapper.php:122 …spec.md#requirement-an-approval-is-an-ordered-task-sequence-with-o The anchor stops mid-word at `with-o`. Three sibling tags in the same file (lines 26, 62 and 149) carry the full `…-with-one-position-enabled-at-a-time`, and the heading it names exists in the spec, so this is a truncation rather than a stale reference to something that moved. Verified by running the gate's own checker over every tracked lib/**/*.php: 1 finding before, 0 after. Fixing the TARGET rather than each tag, as the gate asks — here the target was right all along and the tag was wrong. --------- Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
1 parent 0961e89 commit c130aa2

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

lib/Db/TaskSequenceMapper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ public function findRunning(string $anchorObjectUuid, string $templateId): ?Task
119119
*
120120
* @return TaskSequence|null The newest sequence for the template, or null when none has run.
121121
*
122-
* @spec openspec/changes/flow-approval-consolidation/specs/flow-approval-consolidation/spec.md#requirement-an-approval-is-an-ordered-task-sequence-with-o
122+
* @spec openspec/changes/flow-approval-consolidation/specs/flow-approval-consolidation/spec.md#requirement-an-approval-is-an-ordered-task-sequence-with-one-position-enabled-at-a-time
123123
*/
124124
public function findNewestForTemplate(string $templateId): ?TaskSequence {
125125
$qb = $this->db->getQueryBuilder();

src/manifest.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@
2626
]
2727
},
2828
"version": "1.1.0",
29-
"nav": {
30-
"includePersonalSettings": false
31-
},
3229
"pages": [
3330
{
3431
"id": "dashboard",

0 commit comments

Comments
 (0)