Skip to content

E2E: three empty-state specs fail since 'ship a dashboard' — the empty state can no longer occur #372

Description

@rubenvdlinde

Bracketed on development: last green E2E at 65aa1928, first red at c9e58089, with exactly one commit between them.

c9e58089  fix(dashboards): ship a dashboard, and let the API resolve the one …

Three specs now fail, all asserting the absence of a dashboard:

spec assertion
active-dashboard-resolution.spec.ts:89 .workspace-shell__empty visible when GET /api/dashboard returns none
runtime-shell-canEdit.spec.ts:172 empty state renders with Create CTA when allowUserDashboards true
runtime-shell-canEdit.spec.ts:197 empty state renders without CTA when false
Error: expect(locator).toBeVisible() failed
Locator: locator('.workspace-shell__empty')
Timeout: 15000ms — element(s) not found

If the app now always ships a dashboard, the empty state is unreachable in a default install, and these three need a fixture that removes it — or they need retiring. Which of those is right is a product call for whoever owns c9e5808, so I have not guessed at it.

Not caused by the hydra-gates or l10n changes merged here today: those touch composer.lock and l10n/*, neither of which can remove a CSS class from the DOM.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triageAwaiting triage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions