Commit d158755
fix(deps): pin @nextcloud/vue below the NcSelect rework (#438)
E2E went from 127 passed / 0 failed to 127 passed / 11 failed between two
runs 36 minutes apart:
10:45 4d3819d @nextcloud/vue 9.9.0 E2E success
11:21 b0a322a @nextcloud/vue 9.11.0 E2E failure
Nothing about the tests changed -- both failing specs
(conditional-visibility-editor, dashboard-sharing) were last touched on
2026-08-13. What changed is the lockfile. package.json asked for ^9.5.0,
so regenerating the lockfile for an unrelated stylelint PR silently moved
@nextcloud/vue two minor versions.
9.10.0 reworked NcSelect:
fix(NcSelect): floating label design using NcTextField #8570
fix(NcSelect): truncate long selected labels ... #8829
All 11 failures share one signature, and it is not 'element missing'. The
locator RESOLVES, Playwright logs 'attempting click action', and then
times out on 'waiting for element to be visible, enabled and stable':
- waiting for locator('.vs__dropdown-option').nth(2)
locator resolved to <li role="option" class="vs__dropdown-option">...
attempting click action -> Timeout 10000ms exceeded
An option that exists but never settles is what a re-laying-out floating
label produces.
~9.9.0 holds the last version whose NcSelect these tests were written
against. This is deliberately a PIN, not a fix: adapting the specs to the
new NcSelect is real work and should be its own change, made against the
new component on purpose rather than as a side effect of a lockfile
regeneration.
Verified locally: 9.9.0 installed, 682 unit tests pass, format exits 0.
The E2E itself only runs in CI, and that is the check this is aimed at.
Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>1 parent f93f767 commit d158755
2 files changed
Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
0 commit comments