Commit aa1966c
test(feed): name the failure test after the status it actually exercises (#104)
FeedRefreshServiceTest::testRefreshFeed500RecordsFailurePreservesItems stubs
IResponse::getStatusCode() to 503 and asserts the recorded failure reason
starts with "503". The name and the docblock both said 500 — a status nothing
in the test produces or checks.
The test itself is sound and load-bearing; only the label was wrong.
REQ-FRJ-006 is written about per-feed failure tolerance generally and does not
single out a status, so 503 is a faithful representative and no coverage
changes hands. Renamed, docblock corrected, and the reason for the old label
recorded so it is not "fixed" back.
Behaviour unchanged; this is a rename plus comments.
Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>1 parent 19e9b49 commit aa1966c
1 file changed
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
286 | | - | |
| 286 | + | |
287 | 287 | | |
288 | 288 | | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
289 | 295 | | |
290 | 296 | | |
291 | | - | |
| 297 | + | |
292 | 298 | | |
293 | 299 | | |
294 | 300 | | |
| |||
322 | 328 | | |
323 | 329 | | |
324 | 330 | | |
325 | | - | |
| 331 | + | |
326 | 332 | | |
327 | 333 | | |
328 | 334 | | |
| |||
0 commit comments