Merge pull request #519 from ConductionNL/development

Release: merge development into beta

Author: rubenvdlinde

.github/workflows/code-quality.yml

@@ -149,6 +149,7 @@ permissions:
 
 jobs:
   quality:
+    if: (github.event_name != 'pull_request' || github.head_ref != 'development')
     uses: ConductionNL/.github/.github/workflows/quality.yml@main
     with:
       app-name: launchpad

appinfo/info.xml

@@ -52,7 +52,7 @@ Ideaal voor organisaties die consistente, samengestelde dashboards willen voor h
 
 Vrij en open source onder de EUPL-1.2-licentie.
     ]]></description>
-	<version>1.0.23-unstable.20260831051055</version>
+	<version>1.0.25-unstable.20260831161142</version>
 	<licence>EUPL-1.2</licence>
 	<author mail="info@conduction.nl" homepage="https://www.conduction.nl/">Conduction</author>
 	<namespace>LaunchPad</namespace>

appinfo/routes.php

@@ -14,6 +14,7 @@
 		// First-time setup wizard (ADR-042) — the standard CnSetupWizard contract.
 		['name' => 'setup#status',    'url' => '/api/setup/status',            'verb' => 'GET'],
 		['name' => 'setup#runAction', 'url' => '/api/setup/action/{actionId}', 'verb' => 'POST', 'requirements' => ['actionId' => '[a-z0-9\\-]+']],
+		['name' => 'setup#saveConfig', 'url' => '/api/setup/config',           'verb' => 'POST'],
 		['name' => 'manifest#index', 'url' => '/api/manifest', 'verb' => 'GET'],
 
 		// Metrics and health

composer.lock

@@ -75,6 +75,22 @@
  *
  * Re-declaring it on `body` restores exactly what 9.9.0 did, and is harmless
  * once upstream fixes the scope: the value is identical either way.
+ *
+ * ⚠️ THIS FIXES THE SCOPE, NOT THE VALUE, AND 9999 IS STILL TOO LOW.
+ * `src/styles/workspace.css` carries a SECOND rule raising the same variable
+ * to 10100 on the menu itself. They are not duplicates and removing either
+ * brings a different failure back:
+ *
+ *   - This one restores INHERITANCE, so the menu receives a value at all.
+ *   - That one raises the VALUE above NcModal, which does not use a fixed
+ *     z-index: it assigns one at RUNTIME, counting up as modals open —
+ *     measured 10005 for the first open modal and 10010 for the second. Every
+ *     one of those beats 9999, so with only this rule the menu still renders
+ *     under any modal.
+ *
+ * So when ConductionNL/nextcloud-vue#864 is closed and this block is deleted,
+ * the 10100 rule must STAY until nc-vue relates the two numbers rather than
+ * choosing them independently.
  */
 body {
 	--vs-dropdown-z-index: 9999;

css/launchpad.css

@@ -144,11 +144,32 @@ export default [
 			'no-console': 'off',
 			'n/no-process-exit': 'off',
 			'n/hashbang': 'off',
-			// `_` / `__` as a deliberate throwaway binding — `catch (_)`, a
-			// discarded destructuring slot. Narrow on purpose: the pattern matches
-			// UNDERSCORES ONLY, so a real name that happens to start with `_` is
-			// still reported. v9 drives plain `.js` through the CORE rule (the
-			// `@typescript-eslint` swap is per-file-type), so it is set here.
+			// Tests import devDependencies by definition; this rule is about what
+			// ships in the published package, which tests/ never does.
+			'n/no-unpublished-import': 'off',
+		},
+	},
+
+	{
+		// `_` / `__` as a deliberate throwaway binding — `catch (_)`, a discarded
+		// destructuring slot. Narrow on purpose: the pattern matches UNDERSCORES
+		// ONLY, so a real name that happens to start with `_` is still reported.
+		//
+		// 🔴 `.js` / `.mjs` ONLY, NOT `.ts`. The CORE rule is not TypeScript-aware:
+		// applied to a `.ts` file it reads the parameter NAMES inside a function
+		// TYPE as bindings and reports them unused. Measured on humaniq —
+		//
+		//   t?: (app: string, key: string) => string
+		//
+		// produced four `no-unused-vars` errors for `app` and `key`, which are
+		// documentation, not variables. The same mis-scoping made every unused
+		// `catch (e)` in a `.ts` spec report TWICE, once per rule.
+		//
+		// v9 already turns the core rule off for `.ts` and drives
+		// `@typescript-eslint/no-unused-vars` instead; naming `.ts` here switched
+		// it back on. TypeScript files are handled by the block below.
+		files: ['tests/**/*.js', 'tests/**/*.mjs'],
+		rules: {
 			'no-unused-vars': [
 				'error',
 				{
@@ -165,12 +186,117 @@ export default [
 					ignoreRestSiblings: true,
 				},
 			],
-			// Tests import devDependencies by definition; this rule is about what
-			// ships in the published package, which tests/ never does.
-			'n/no-unpublished-import': 'off',
 		},
 	},
 
+	{
+		// The TypeScript half of the block above. Same intent, same patterns, on
+		// the rule that actually understands the language: it knows a name inside
+		// a function type is not a binding, so type annotations stay quiet while a
+		// genuinely dead local is still reported.
+		files: ['tests/**/*.ts', 'tests/**/*.tsx'],
+		rules: {
+			'@typescript-eslint/no-unused-vars': [
+				'error',
+				{
+					varsIgnorePattern: '^_+$',
+					caughtErrors: 'all',
+					caughtErrorsIgnorePattern: '^_+$',
+					argsIgnorePattern: '^_',
+					ignoreRestSiblings: true,
+				},
+			],
+		},
+	},
+
+	{
+		// 🔴 Node-side CLI tooling under `scripts/`, which is COMMONJS. Flat
+		// config defaults every `.js` to ESM with browser-ish globals, so without
+		// this block eslint reports the CommonJS wrapper itself as undefined
+		// identifiers. Measured on this app: 52 of the 233 errors under
+		// `tests/` + `scripts/` were `no-undef`, ALL of them in `scripts/`, and
+		// all five names were the environment rather than a typo — `process` 23,
+		// `require` 20, `__dirname` 6, `__filename` 2, `module` 1.
+		//
+		// This is describing the environment, not relaxing a rule, and it is the
+		// same argument the test-globals block below makes: declaring them keeps
+		// `no-undef` able to do its real job, which is catching a genuinely
+		// misspelled identifier. Suppressing the rule instead would bury that.
+		//
+		// `no-console` is off because printing its report is what a CLI checker
+		// is FOR.
+		//
+		// 🔴 NO `n/*` ENTRIES HERE, DELIBERATELY. `eslint-plugin-n` is NOT
+		// registered for these files under eslint 10 + @nextcloud/eslint-config
+		// 9, so `'n/no-process-exit': 'off'` would be dead config that reads as
+		// if it were doing something. Measured both ways on this app: 0 `n/`
+		// findings with the entries and 0 without.
+		//
+		// What DID report was the opposite — four `scripts/*.js` carried
+		// `/* eslint-disable n/no-process-exit */` and `/* eslint-disable
+		// n/shebang */` left over from the eslintrc era, and an inline disable
+		// naming an unregistered plugin is itself an error ("Definition for rule
+		// 'n/shebang' was not found"). Those 8 comments are removed; do not add
+		// `n/*` rules back to replace them.
+		//
+		// ⚠️ `.js` and `.cjs` ONLY. A `scripts/*.mjs` is genuinely ESM and must
+		// keep the default `sourceType`, or `import` stops parsing there.
+		files: ['scripts/**/*.js', 'scripts/**/*.cjs'],
+		languageOptions: {
+			sourceType: 'commonjs',
+			globals: {
+				require: 'readonly',
+				module: 'writable',
+				exports: 'writable',
+				process: 'readonly',
+				__dirname: 'readonly',
+				__filename: 'readonly',
+				console: 'readonly',
+				Buffer: 'readonly',
+				global: 'readonly',
+				URL: 'readonly',
+				TextEncoder: 'readonly',
+				TextDecoder: 'readonly',
+			},
+		},
+		rules: {
+			'no-console': 'off',
+		},
+	},
+
+	{
+		// The ESM half of the block above. A `scripts/*.mjs` is genuinely a module
+		// and must keep the default `sourceType`, so it gets Node's globals but
+		// none of the CommonJS wrapper. Measured: `process` reported undefined 2x
+		// in hermiq's generate-opengemeenten-icons.mjs and 4x in openregister's
+		// l10n/runtime-check.mjs, which the `.js`/`.cjs` block deliberately does
+		// not match.
+		files: ['scripts/**/*.mjs', 'tests/**/*.mjs'],
+		languageOptions: {
+			globals: {
+				process: 'readonly',
+				console: 'readonly',
+				Buffer: 'readonly',
+				global: 'readonly',
+				URL: 'readonly',
+				TextEncoder: 'readonly',
+				TextDecoder: 'readonly',
+			},
+		},
+		rules: {
+			'no-console': 'off',
+		},
+	},
+
+	{
+		// eslint must not try to PARSE a shell script. `tests/e2e/seed.test.sh`
+		// matches the `**/*.test.*` glob some presets use, and eslint then reads
+		// it as JavaScript and reports "Parsing error: Unexpected character" —
+		// a finding about a file it should never have opened.
+		ignores: ['**/*.sh', '**/*.bash'],
+	},
+
+
 	{
 		// Test globals. Several apps keep their spec files INSIDE `src/`, which the
 		// lint script scans, and neither `@nextcloud/eslint-config` nor the runner

eslint.config.mjs

@@ -1,6 +1,7 @@
 OC.L10N.register(
     "launchpad",
     {
+    "Features & roadmap" : "Функцыі і дарожная карта",
     "Maximum dashboards per user" : "Максімальная колькасць дашбордаў на карыстальніка",
     "Maximum widgets per dashboard" : "Максімальная колькасць віджэтаў на дашборд",
     "0 = unlimited. Lowering a limit never deletes existing dashboards; it only blocks new ones until users are back under the limit." : "0 = без абмежаванняў. Зніжэнне ліміту ніколі не выдаляе існуючыя дашборды; яно толькі блакуе стварэнне новых, пакуль карыстальнікі не вернуцца пад ліміт.",
@@ -1088,6 +1089,31 @@ OC.L10N.register(
     "No dashboards in this group yet" : "У гэтай групе пакуль няма панэляў",
     "Rename" : "Перайменаваць",
     "New dashboard name" : "Новая назва панэлі",
-    "Delete this dashboard? This cannot be undone." : "Выдаліць гэтую панэль? Гэта нельга адмяніць."
+    "Delete this dashboard? This cannot be undone." : "Выдаліць гэтую панэль? Гэта нельга адмяніць.",
+    "Reports": "Справаздачы",
+    "Pick a report to open it.": "Выберыце справаздачу, каб адкрыць яе.",
+    "Open": "Адкрыта",
+    "In progress": "У працы",
+    "Blocked": "Заблакіравана",
+    "Date": "Дата",
+    "Due": "Тэрмін",
+    "Assignee": "Прызначана",
+    "Who": "Хто",
+    "What": "Што",
+    "Minutes": "Хвіліны",
+    "Entries": "Запісы",
+    "Most recent": "Найноўшыя",
+    "Per person": "На асобу",
+    "By status": "Па статусе",
+    "By priority": "Па прыярытэце",
+    "Personal": "Асабістыя",
+    "Shared with a group": "Агульнае з групай",
+    "Admin templates": "Шаблоны адміністратара",
+    "Who they belong to": "Каму яны належаць",
+    "Kind": "Від",
+    "Version": "Версія",
+    "How many dashboards there are, and who they belong to.": "Колькі ёсць панэляў і каму яны належаць.",
+    "Store": "Крама",
+    "Install dashboard configurations that other organisations have published: a set of tiles, a layout, or the flows behind them.": "Усталюйце рэестры, схемы і патокі, апублікаваныя іншымі арганізацыямі."
 },
 "nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2);");

l10n/be.js

@@ -9,7 +9,11 @@
         "Kiosk playlists": "Кіёскавыя плэйлісты",
         "New playlist": "Новы плэйліст",
         "Point a wall display or reception screen at a playlist URL to rotate dashboards chrome-less and unattended.": "Накіруйце насценны дысплей або экран рэцэпцыі на URL плэйліста, каб ратаваць дашборды без інтэрфейсу і без нагляду.",
-        "_%n dashboard_::_%n dashboards_": ["%n дашборд", "%n дашборды", "%n дашбордаў"],
+        "_%n dashboard_::_%n dashboards_": [
+            "%n дашборд",
+            "%n дашборды",
+            "%n дашбордаў"
+        ],
         "refresh every {seconds}s": "абнаўляць кожныя {seconds} с",
         "Copy URL": "Капіяваць URL",
         "Revoke": "Адклікаць",
@@ -1061,6 +1065,32 @@
         "Bridge": "Мост",
         "No widgets match this filter": "Няма віджэтаў, якія адпавядаюць гэтаму фільтру",
         "Catalog": "Каталог",
-        "General": "Агульныя"
+        "General": "Агульныя",
+        "Features & roadmap": "Функцыі і дарожная карта",
+        "Reports": "Справаздачы",
+        "Pick a report to open it.": "Выберыце справаздачу, каб адкрыць яе.",
+        "Open": "Адкрыта",
+        "In progress": "У працы",
+        "Blocked": "Заблакіравана",
+        "Date": "Дата",
+        "Due": "Тэрмін",
+        "Assignee": "Прызначана",
+        "Who": "Хто",
+        "What": "Што",
+        "Minutes": "Хвіліны",
+        "Entries": "Запісы",
+        "Most recent": "Найноўшыя",
+        "Per person": "На асобу",
+        "By status": "Па статусе",
+        "By priority": "Па прыярытэце",
+        "Personal": "Асабістыя",
+        "Shared with a group": "Агульнае з групай",
+        "Admin templates": "Шаблоны адміністратара",
+        "Who they belong to": "Каму яны належаць",
+        "Kind": "Від",
+        "Version": "Версія",
+        "How many dashboards there are, and who they belong to.": "Колькі ёсць панэляў і каму яны належаць.",
+        "Store": "Крама",
+        "Install dashboard configurations that other organisations have published: a set of tiles, a layout, or the flows behind them.": "Усталюйце рэестры, схемы і патокі, апублікаваныя іншымі арганізацыямі."
     }
 }