From 2df91061c6bd1d88e586d86171c9dd6a20a39c4c Mon Sep 17 00:00:00 2001
From: Ruben van der Linde <rubenvdlinde@gmail.com>
Date: Mon, 31 Aug 2026 15:58:09 +0200
Subject: [PATCH] fix(e2e): click the button inside the Move action, not its li
 wrapper

The folder-sharing spec drove the new sidebar's "Secret actions" menu via
getByTestId('secret-detail-move'), but data-testid falls through to
NcActionButton's ROOT element, which is the <li> wrapper rather than the
<button> that carries the click handler. Dispatching a native click on the
<li> is a silent no-op, so SecretMoveDialog never opened and the spec failed
on the downstream '.move-form' assertion instead of at the click.

The testid resolving fine is what made this read as a dialog bug: the click
step passed and only the next assertion timed out.

Descend to the button so the handler actually fires. The sibling testids in
this spec (secret-detail-share, secret-detail-more-info) sit on NcButton and
a native <summary>, whose roots ARE the interactive element, so they are
unaffected.
---
 tests/e2e/workflows/folder-sharing.spec.ts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/e2e/workflows/folder-sharing.spec.ts b/tests/e2e/workflows/folder-sharing.spec.ts
index 5b8cbe7d..939efeb5 100644
--- a/tests/e2e/workflows/folder-sharing.spec.ts
+++ b/tests/e2e/workflows/folder-sharing.spec.ts
@@ -279,8 +279,13 @@ test.describe('Workflow: folders + sharing — folders/spec.md', () => {
 		await page
 			.getByRole('button', { name: /Secret actions/i })
 			.evaluate((el: HTMLElement) => el.click())
+		// `data-testid` falls through to NcActionButton's ROOT, which is the
+		// <li> wrapper, not the <button> carrying the click handler — so
+		// clicking the testid node itself is a silent no-op and the dialog
+		// never opens. Descend to the button.
 		await page
 			.getByTestId('secret-detail-move')
+			.locator('button')
 			.evaluate((el: HTMLElement) => el.click())
 		await expect(page.locator('.move-form')).toBeVisible({ timeout: 10_000 })
 		await page.locator('.move-form .vs__dropdown-toggle').click()