Skip to content

Commit df38fc8

Browse files
author
Conduction Release Bot
committed
fix(e2e): the lint pass renamed Playwright fixtures, which killed the suite
Playwright resolves a fixture BY NAME from the destructured parameter, so renaming an unused one to `_page` asks for a fixture that does not exist. The e2e leg dies before a single test runs and the report contains no test entries at all. Introduced by the pass that let the linter see tests/. The linter was right that the parameters were unused; underscore-prefixing is the fix for an ordinary unused argument and the wrong fix for a Playwright fixture, because the name is the lookup key. Same defect as buildiq#642, found by a fleet sweep.
1 parent a231112 commit df38fc8

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

tests/e2e/workflows/team-folder-sharing.spec.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,7 @@ import {
4848
const API = `${APP_BASE.replace('/apps/keepiq', '')}/apps/keepiq/api/v1`
4949

5050
test.describe('team folder sharing', () => {
51-
test('owner shares a folder, fans out to a user, and revokes', async ({
52-
page,
53-
_request,
54-
}) => {
51+
test('owner shares a folder, fans out to a user, and revokes', async ({ page }) => {
5552
await gotoLockSettled(page)
5653
await unlockVault(page)
5754
await openVault(page)

0 commit comments

Comments
 (0)