Commit df38fc8
Conduction Release Bot
fix(e2e): the lint pass renamed Playwright fixtures, which killed the suite
Playwright resolves a fixture BY NAME from the destructured parameter, so
renaming an unused one to `_page` asks for a fixture that does not exist. The
e2e leg dies before a single test runs and the report contains no test
entries at all.
Introduced by the pass that let the linter see tests/. The linter was right
that the parameters were unused; underscore-prefixing is the fix for an
ordinary unused argument and the wrong fix for a Playwright fixture, because
the name is the lookup key.
Same defect as buildiq#642, found by a fleet sweep.1 parent a231112 commit df38fc8
1 file changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
| 51 | + | |
55 | 52 | | |
56 | 53 | | |
57 | 54 | | |
| |||
0 commit comments