Skip to content

Commit c1dc58b

Browse files
authored
fix(docs): publish the documentation from development, not a stale branch (#428)
* fix(docs): publish the documentation from development, not a stale branch This workflow triggered on `push: branches: [documentation]`. That branch exists, which is why nothing ever looked broken — but nobody updates it. Its last commit predates most of this year's work: larpinq 19 May (development is 594 commits ahead), buildiq 9 July (980 ahead). So the docs pipeline has been faithfully republishing a months-old snapshot, and reporting success every time. It is the reason larpinq.conduction.nl still says "LarpingApp" and decidiq.conduction.nl still says "Decidesk" while both repos' docs sources have said the new name since the app-id rename merged. The rename was never missed in the docs — the docs were publishing from somewhere else. Four of the twelve fleet apps (dossiq, integriq, stackiq, thematiq) already point at `development`. This brings the rest in line. Pairs with ConductionNL/.github#555, which made the reusable workflow publish to the Cloudflare Worker that actually serves the host — previously it wrote gh-pages and nothing read it. Both halves are needed: one fixes WHERE the docs go, this one fixes WHICH COMMIT they come from. * fix(docs): name the worker that actually serves this site The trigger fix in this PR makes the docs workflow run. This commit makes the run reach the edge. `worker-name` was never passed, so the callee derived it from `cname`. Since the app-id rename `cname` is the NEW host, and the worker that actually holds the custom domains is still named after the OLD app id. The derived name therefore points at a worker that does not exist — deploying it CREATES a second worker while both custom domains keep routing to the original. Every deploy green, reaching nobody, with the live-site verification added in ConductionNL/.github#555 as the only thing that would ever have noticed. Pinning the name also decouples the worker from `cname`, so the docs host can move to the new subdomain later without silently forking the worker. Measured today: the live host still serves the pre-rename title, which is the staleness this PR chain exists to end. * fix(docs): stop MDX parsing a placeholder as a JSX tag The docs build FAILS, and has been failing — it was simply never run, because the workflow triggered on a branch nobody updates. Making the trigger correct surfaced it on the first run. Error: MDX compilation failed for application-secret-requests.md Cause: Expected a closing tag for `<date>` (27:39-27:45) `<date>` was written as a plain-English placeholder inside a table cell. MDX reads it as an opening JSX tag, finds no closing tag, and aborts the whole client bundle — so no page of this site could publish, whatever the workflow did. Backticks the two placeholders. They now render as code, which is what a placeholder should look like anyway, and the sentence is unchanged. Verified locally: npm ci --legacy-peer-deps && npm run build now exits 0 with all 10 AI-baseline checks passing.
1 parent 4e3c511 commit c1dc58b

2 files changed

Lines changed: 12 additions & 4 deletions

File tree

‎.github/workflows/documentation.yml‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: Documentation
22

33
on:
44
push:
5-
branches: [documentation]
5+
branches: [development]
66
pull_request:
7-
branches: [documentation]
7+
branches: [development]
88

99
jobs:
1010
deploy:
@@ -18,4 +18,12 @@ jobs:
1818
# step with docs/static/CNAME.
1919
cname: keepiq.conduction.nl
2020

21-
docs-hosts: doriath.conduction.nl,keepiq.conduction.nl
21+
docs-hosts: doriath.conduction.nl,keepiq.conduction.nl
22+
23+
# Named explicitly, because the comment above already knows the answer
24+
# and the workflow did not. The callee derives the worker from `cname`
25+
# when not told — `keepiq-docs`, which does not exist. Deploying that
26+
# creates a SECOND worker while both custom domains keep routing to
27+
# `doriath-docs`: every deploy green, reaching nobody. Renaming the
28+
# worker is a Cloudflare-side move, not something this file can perform.
29+
worker-name: doriath-docs

‎docs/application-secret-requests.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ shows:
2424
| Column | Notes |
2525
|---|---|
2626
| Status | Pending, Fulfilled, Declined, Expired |
27-
| Expiry | "Expires <date>", "Expired <date>", or **"No expiry"** — a link that works forever |
27+
| Expiry | `Expires <date>`, `Expired <date>`, or **"No expiry"** — a link that works forever |
2828
| Token | Truncated. The full value goes to the clipboard only via **Copy fill link** |
2929
| Requested fields | The field names asked for, e.g. `key, login` |
3030

0 commit comments

Comments
 (0)