Skip to content

Commit bc82eb4

Browse files
rubenvdlindeclaude
andcommitted
fix(ci): a standing release PR ran every development push twice
Every push to development fired Code Quality TWICE on the same commit: once for the push event, once for the pull_request event of the permanently-open "Release: merge development into beta", whose head_ref IS development. The concurrency block is not the bug and must not be changed: it suffixes the group by event name deliberately so the push run is NOT cancelled by the PR run, because the push run is the only carrier of Coverage Baseline Check, SBOM and Features Extract. The consequence is that both lanes run to completion, so the duplicate has to be dropped at the job. The PR run is the one to drop: its head sha IS development's, which the push run already decided, and it runs strictly fewer jobs. Not done by removing `beta` from pull_request.branches, though that would also stop it: the release/v* and sync/main-to-beta PRs target beta too and genuinely need their run. Only the head_ref:development PR is redundant. A development -> main promotion PR is skipped by the same clause, for the same reason and just as correctly. Proven on openregister#3370 before rolling out: run 33757014196 (pull_request, sha 4f3ef5e9) completed as `skipped` with ZERO jobs in 72s, while the push run for the same sha ran the full suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent a4edf56 commit bc82eb4

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.github/workflows/code-quality.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ permissions:
143143

144144
jobs:
145145
quality:
146+
if: (github.event_name != 'pull_request' || github.head_ref != 'development')
146147
uses: ConductionNL/.github/.github/workflows/quality.yml@main
147148
with:
148149
app-name: keepiq

0 commit comments

Comments
 (0)