Merge pull request #288 from ConductionNL/fix/development-openspec-chores

chore(openspec): archive two finished changes and clear the debt behind them

Author: rubenvdlinde

lib/Service/SecretRequestService.php

@@ -387,7 +387,7 @@ public function create(
 	 *
 	 * @throws InvalidArgumentException When userId or requestedFields are missing
 	 *
-	 * @spec openspec/changes/request-first-secret-requests/specs/secret-requests/spec.md#requirement-create-secret-request
+	 * @spec openspec/specs/secret-requests/spec.md#requirement-create-secret-request
 	 */
 	public function createForUserVault(
 		string $userId,
@@ -633,7 +633,7 @@ public function decline(string $requestId, string $userId): SecretRequest {
 	 *
 	 * @return void
 	 *
-	 * @spec openspec/changes/request-first-secret-requests/specs/secrets/spec.md#requirement-unfilled-request-placeholder
+	 * @spec openspec/specs/secrets/spec.md#requirement-unfilled-request-placeholder
 	 */
 	private function deletePlaceholderIfUnfilled(SecretRequest $request, string $userId): void {
 		try {
@@ -687,7 +687,7 @@ private function deletePlaceholderIfUnfilled(SecretRequest $request, string $use
 	 *
 	 * @return bool True when every value column is empty
 	 *
-	 * @spec openspec/changes/request-first-secret-requests/specs/secrets/spec.md#requirement-unfilled-request-placeholder
+	 * @spec openspec/specs/secrets/spec.md#requirement-unfilled-request-placeholder
 	 */
 	private function holdsNoValues(Secret $secret): bool {
 		return (string)$secret->getKey() === ''

lib/Service/SecretRequestSuiteLockService.php

@@ -62,7 +62,7 @@ public function __construct(
 	 *
 	 * @throws InvalidArgumentException When the suite ID is blank.
 	 *
-	 * @spec openspec/specs/encryption-suites/spec.md#requirement-master-password-change--compromise-recovery
+	 * @spec openspec/specs/encryption-suites/spec.md#requirement-master-password-change-compromise-recovery
 	 */
 	public function lockByEncryptionSuiteId(string $encryptionSuiteId): int {
 		if ($encryptionSuiteId === '') {

lib/Service/SecretService.php

@@ -234,7 +234,7 @@ private function dispatchAudit(AuditEvent $event): void {
 	 * every user write would let an ordinary create silently store a valueless
 	 * secret — the failure this flag exists to prevent.
 	 *
-	 * @spec openspec/changes/request-first-secret-requests/specs/secrets/spec.md#requirement-unfilled-request-placeholder
+	 * @spec openspec/specs/secrets/spec.md#requirement-unfilled-request-placeholder
 	 */
 	public function create(array $data, string $userId, bool $allowUnfilled = false): Secret {
 		$this->assertNotWriteLocked(userId: $userId);
@@ -1398,7 +1398,7 @@ public function setExpiry(string $id, ?DateTime $expiresAt, string $userId): Sec
 	 *
 	 * @return bool True when a version row is warranted.
 	 *
-	 * @spec openspec/changes/request-first-secret-requests/specs/secrets/spec.md#requirement-unfilled-request-placeholder
+	 * @spec openspec/specs/secrets/spec.md#requirement-unfilled-request-placeholder
 	 */
 	private function shouldSnapshot(Secret $before, Secret $after): bool {
 		if ($this->versionService === null) {
@@ -1423,7 +1423,7 @@ private function shouldSnapshot(Secret $before, Secret $after): bool {
 	 *
 	 * @return bool True when the row carried no value.
 	 *
-	 * @spec openspec/changes/request-first-secret-requests/specs/secrets/spec.md#requirement-unfilled-request-placeholder
+	 * @spec openspec/specs/secrets/spec.md#requirement-unfilled-request-placeholder
 	 */
 	private function hadNoValues(Secret $secret): bool {
 		return (string)$secret->getKey() === ''