What
Nine files carry a comment citing FlowDetailPage.fetchPickerOptions() as the canonical explanation
of a picker-loading quirk:
// ... under HTTP 200. See FlowDetailPage.fetchPickerOptions().
src/views/Flow/FlowDetailPage.vue contains zero occurrences of fetchPickerOptions. The file
is a 71-line wrapper that renders CnFlowDetail and nothing else. The citation was already dangling
before the flow-page migration; that migration deletes the file, so it will now name a path that does
not exist at all.
Where
| File |
Line |
src/views/Synchronization/SyncReferenceList.vue |
148 |
src/views/Synchronization/SyncMappingPicker.vue |
206 |
src/views/Synchronization/SyncConfigWidget.vue |
909 |
src/views/ApiProducts/ApiProductDetail.vue |
433, 476 |
src/views/Rule/actionForms/shared.js |
42 |
src/modals/v2/AddEndpointRuleModal.vue |
196 |
src/modals/v2/JobFormFields.vue |
609 |
src/modals/EventSubscription/SubscriptionActionFields.vue |
526, 563 |
src/modals/NotificatiesAbonnement/NotificatiesAbonnementForm.vue |
299 |
Each of those files defines its own fetchPickerOptions, so the comment reads as "the shared
explanation lives over there" while there is no over-there.
Why it matters more than a typo
The comment is load-bearing documentation: it explains an API that returns an error shape under
HTTP 200, which is the kind of thing a reader will otherwise assume is a bug and "fix". Nine copies
of a pointer to a missing explanation is worse than one copy of the explanation.
Suggested fix
Pick the canonical home — src/views/Rule/actionForms/shared.js looks like it, being the only
non-component file in the list — write the explanation there once, and repoint the other eight.
Not fixed in the migration PR
Deliberately left out of the flow-page migration: touching nine unrelated files would have made a
focused manifest change unreviewable, and the rot predates it.
What
Nine files carry a comment citing
FlowDetailPage.fetchPickerOptions()as the canonical explanationof a picker-loading quirk:
src/views/Flow/FlowDetailPage.vuecontains zero occurrences offetchPickerOptions. The fileis a 71-line wrapper that renders
CnFlowDetailand nothing else. The citation was already danglingbefore the flow-page migration; that migration deletes the file, so it will now name a path that does
not exist at all.
Where
src/views/Synchronization/SyncReferenceList.vuesrc/views/Synchronization/SyncMappingPicker.vuesrc/views/Synchronization/SyncConfigWidget.vuesrc/views/ApiProducts/ApiProductDetail.vuesrc/views/Rule/actionForms/shared.jssrc/modals/v2/AddEndpointRuleModal.vuesrc/modals/v2/JobFormFields.vuesrc/modals/EventSubscription/SubscriptionActionFields.vuesrc/modals/NotificatiesAbonnement/NotificatiesAbonnementForm.vueEach of those files defines its own
fetchPickerOptions, so the comment reads as "the sharedexplanation lives over there" while there is no over-there.
Why it matters more than a typo
The comment is load-bearing documentation: it explains an API that returns an error shape under
HTTP 200, which is the kind of thing a reader will otherwise assume is a bug and "fix". Nine copies
of a pointer to a missing explanation is worse than one copy of the explanation.
Suggested fix
Pick the canonical home —
src/views/Rule/actionForms/shared.jslooks like it, being the onlynon-component file in the list — write the explanation there once, and repoint the other eight.
Not fixed in the migration PR
Deliberately left out of the flow-page migration: touching nine unrelated files would have made a
focused manifest change unreviewable, and the rot predates it.