feat(schemas): namespace the case task (#1845)

`task` was claimed by three apps: planninq, pipelinq and this one. They share
`description`, `priority` and `status` — what any task-shaped record carries,
and nothing that identifies the record. planninq's project task is the largest
and keeps the bare slug; pipelinq's became `crmTask`.

WHAT THE SUITE FOUND THAT THE GREP DID NOT. The rename reached the descriptors,
the config-key map and every store call on the first pass, and the suite still
failed six times — twice for the same reason in two different places.

KpiAggregationService::ids() and DemoCaseloadGateway::schemaIds() each build a
LOCAL array keyed 'task' and hand it round as $ids['task']. Renaming the readers
without the builders left $ids['caseTask'] resolving to null, which surfaced as
a TypeError on a nullable argument three frames away, in a class that never
mentions the slug.

Then PHPStan caught the declared array shapes still saying `task: string` after
the builders moved.

Neither would ever appear in `grep -rn "'task'"`-shaped triage as a schema
reference: the array key is not the slug, it is just spelled like it. This is
the first rename tonight where the escaped sites were STRUCTURAL rather than
lexical.

tests/e2e/ci-seed.sh names the slug in its required-schema list and moved with
it — that list is checked after the import and exits BEFORE Playwright, so a
miss reports every spec as not run rather than as a failure.

Decoys left alone: `itemType` in WorkQueueService and the `type` key in
CaseReassignmentService, BulkReassignModal, taskApi and dashboardHelpers, all
row labels for mixed lists.

Full suite: 3,045 tests, 18,012 assertions, exit 0. phpcs, phpstan, psalm exit
0.

Author: rubenvdlinde

lib/Repair/RenameCollidingSchemaSlugs.php

@@ -69,6 +69,10 @@ class RenameCollidingSchemaSlugs implements IRepairStep {
 	 */
 	private const RENAMES = [
 		'supplierInvoice' => ['to' => 'caseSupplierInvoice', 'with' => 'shillinq'],
+		// The case task. `task` was claimed by three apps and they share only
+		// `description`, `priority` and `status`. planninq's project task is the
+		// largest and keeps the bare slug; pipelinq took crmTask.
+		'task' => ['to' => 'caseTask', 'with' => 'planninq, pipelinq'],
 	];
 
 	/**

lib/Service/DemoCaseloadGateway.php

@@ -65,7 +65,7 @@ public function __construct(
 	/**
 	 * The register and schema ids the demo caseload reads and writes.
 	 *
-	 * @return array{register: string, case: string, task: string, caseType: string, statusType: string} The ids.
+	 * @return array{register: string, case: string, caseTask: string, caseType: string, statusType: string} The ids.
 	 *
 	 * @throws RuntimeException When the app is not configured against a register yet.
 	 *
@@ -75,7 +75,7 @@ public function schemaIds(): array {
 		$ids = [
 			'register' => $this->config(key: 'register'),
 			'case' => $this->config(key: 'case_schema'),
-			'task' => $this->config(key: 'task_schema'),
+			'caseTask' => $this->config(key: 'task_schema'),
 			'caseType' => $this->config(key: 'case_type_schema'),
 			'statusType' => $this->config(key: 'status_type_schema'),
 		];

lib/Service/DemoCaseloadReport.php

@@ -92,7 +92,7 @@ public function buckets(?DateTimeImmutable $now = null): array {
 		$tasks = $this->gateway->findMany(
 			objectService: $objectService,
 			registerId: $ids['register'],
-			schemaId: $ids['task'],
+			schemaId: $ids['caseTask'],
 			filters: []
 		);
 

lib/Service/DemoCaseloadSeedDataService.php

@@ -257,7 +257,7 @@ private function createTasks(
 			$id = $this->gateway->create(
 				objectService: $objectService,
 				registerId: $ids['register'],
-				schemaId: $ids['task'],
+				schemaId: $ids['caseTask'],
 				data: $this->taskPayload(taskSeed: $taskSeed, caseId: $caseId, now: $now)
 			);
 

lib/Service/KpiAggregationService.php

@@ -192,7 +192,7 @@ private function countCases(array $ids, array $filters): int {
 	 * @return int The count.
 	 */
 	private function countTasks(array $ids, array $filters): int {
-		return $this->countObjects(ids: $ids, schema: $ids['task'], filters: $filters);
+		return $this->countObjects(ids: $ids, schema: $ids['caseTask'], filters: $filters);
 	}//end countTasks()
 
 	/**
@@ -450,13 +450,13 @@ private function toArray(mixed $object): array {
 	/**
 	 * The register and schema ids these metrics read.
 	 *
-	 * @return array{register: string, case: string, task: string}|null The ids, or null when unconfigured.
+	 * @return array{register: string, case: string, caseTask: string}|null The ids, or null when unconfigured.
 	 */
 	private function ids(): ?array {
 		$ids = [
 			'register' => $this->appConfig->getValueString(Application::APP_ID, 'register', ''),
 			'case' => $this->appConfig->getValueString(Application::APP_ID, 'case_schema', ''),
-			'task' => $this->appConfig->getValueString(Application::APP_ID, 'task_schema', ''),
+			'caseTask' => $this->appConfig->getValueString(Application::APP_ID, 'task_schema', ''),
 		];
 
 		if (in_array('', $ids, true) === true) {

lib/Service/Settings/SchemaSlugMap.php

@@ -48,7 +48,7 @@ class SchemaSlugMap {
 	public const SLUG_TO_CONFIG_KEY = [
 		'catalog' => 'catalogus_schema',
 		'case' => 'case_schema',
-		'task' => 'task_schema',
+		'caseTask' => 'task_schema',
 		'status' => 'status_schema',
 		'statusRecord' => 'status_record_schema',
 		'role' => 'role_schema',

lib/Service/Settings/SchemaSlugResolver.php

@@ -99,7 +99,7 @@ public function __construct(
 	 * and dropping the fallback would blank all three.
 	 *
 	 * @param object $schemaMapper The OpenRegister SchemaMapper.
-	 * @param string $slug The schema slug, e.g. 'task'.
+	 * @param string $slug The schema slug, e.g. 'caseTask'.
 	 *
 	 * @return object|null The live schema, or null when the slug does not resolve.
 	 *

lib/Service/Support/JsonEncodedStringProperties.php

@@ -86,7 +86,7 @@ class JsonEncodedStringProperties {
 		'notificationChannel' => ['filters'],
 		'objection' => ['attachments'],
 		'resultType' => ['sourceDateArchiveProcedure'],
-		'task' => ['checklist'],
+		'caseTask' => ['checklist'],
 		'workflowTemplate' => ['nodePositions', 'steps', 'transitions'],
 	];
 

lib/Settings/dossiq_mock_register.json

@@ -13112,8 +13112,8 @@
           }
         }
       },
-      "task": {
-        "slug": "task",
+      "caseTask": {
+        "slug": "caseTask",
         "x-openregister-notifications": {
           "taskAssigned": {
             "trigger": {
@@ -22676,7 +22676,7 @@
       {
         "@self": {
           "register": "dossiq",
-          "schema": "task",
+          "schema": "caseTask",
           "slug": "task-voorbeeld-title-1-1",
           "id": "fab148e2-e14d-45ca-a0c2-58073d5e59b3"
         },
@@ -22695,7 +22695,7 @@
       {
         "@self": {
           "register": "dossiq",
-          "schema": "task",
+          "schema": "caseTask",
           "slug": "task-voorbeeld-title-2-2",
           "id": "10d3503b-1077-45db-8516-ae4719f1a40f"
         },
@@ -22714,7 +22714,7 @@
       {
         "@self": {
           "register": "dossiq",
-          "schema": "task",
+          "schema": "caseTask",
           "slug": "task-voorbeeld-title-3-3",
           "id": "0d4e9a65-535b-4ef8-bd93-453713b8fa78"
         },

lib/Settings/dossiq_register.json

@@ -1848,8 +1848,8 @@
                 },
                 "searchable": true
             },
-            "task": {
-                "slug": "task",
+            "caseTask": {
+                "slug": "caseTask",
                 "x-openregister-notifications": {
                     "taskAssigned": {
                         "trigger": {
@@ -9230,7 +9230,7 @@
                     "documentType",
                     "decisionType",
                     "case",
-                    "task",
+                    "caseTask",
                     "role",
                     "result",
                     "statusRecord",