Skip to content

Register import broken: SettingsService::loadConfiguration calls stale OpenRegister importFromApp signature #196

Description

@rubenvdlinde

Symptom

In the dev container, the Decidesk register (decidesk, OpenRegister register id 264) had only 8 of its 24 schemas attached, the in-app Settings → Registers widget read 0/24 configured, and every list view's Add Item dialog opened with no form fields. The repair step / re-import button both failed with "Configuration import failed. See server log for details."

Root cause

OCA\Decidesk\Service\SettingsService::loadConfiguration() calls:

$configurationService->importFromApp(appId: Application::APP_ID, force: $force);

but OCA\OpenRegister\Service\ConfigurationService::importFromApp is:

public function importFromApp(string $appId, array $data, string $version, bool $force = false): array

— so the call dies with ArgumentCountError: Argument #2 ($data) not passed. The OpenRegister API gained $data / $version parameters; Decidesk's caller was never updated.

Fix

SettingsService::loadConfiguration should read lib/Settings/decidesk_register.json, pull the version from info.version, and call importFromApp($appId, $data, $version, $force). (Verified manually: calling it with the correct signature imports the full schema set and the create forms render.)

InitializeSettings repair step calls through loadConfiguration, so fixing it there fixes the install/upgrade path too.

Impact

App is effectively unusable on a fresh install in the dev env (and presumably anywhere the OpenRegister version is recent enough to have the new signature) until this is fixed. Surfaced while filling the journeydoc tutorials (#195).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions