Skip to content

Commit 9382751

Browse files
committed
Remove unused metrics writer
1 parent 117b343 commit 9382751

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

backend/api/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@compass/api",
3-
"version": "1.38.0",
3+
"version": "1.38.1",
44
"private": true,
55
"description": "Backend API endpoints",
66
"main": "src/serve.ts",

backend/api/src/serve.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {ErrorRequestHandler} from 'express'
77
import * as admin from 'firebase-admin'
88
import {getServiceAccountCredentials} from 'shared/firebase-utils'
99
import {initAdmin} from 'shared/init-admin'
10-
import {METRIC_WRITER} from 'shared/monitoring/metric-writer'
1110
import {log} from 'shared/utils'
1211
import {listen as webSocketListen} from 'shared/websockets/server'
1312

@@ -46,7 +45,7 @@ if (IS_LOCAL) {
4645
})
4746
}
4847

49-
METRIC_WRITER.start()
48+
// METRIC_WRITER.start()
5049

5150
const credentials = IS_LOCAL
5251
? getServiceAccountCredentials()

backend/shared/src/monitoring/metric-writer.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ function serializeEntries(instance: InstanceInfo, entries: MetricStoreEntry[], t
8282
}
8383

8484
/** Writes metrics out to GCP's API from a metric store on an interval. */
85-
export class MetricWriter {
85+
class MetricWriter {
8686
client: MetricServiceClient
8787
store: MetricStore
8888
intervalMs: number
@@ -101,7 +101,8 @@ export class MetricWriter {
101101
for (const entry of freshEntries) {
102102
entry.fresh = false
103103
}
104-
if (IS_GOOGLE_CLOUD) {
104+
if (IS_GOOGLE_CLOUD && !process.env.K_SERVICE) {
105+
// only for vm, not cloud run
105106
log.debug('Writing GCP metrics.', {entries: freshEntries})
106107
if (this.instance == null) {
107108
this.instance = await getInstanceInfo()

0 commit comments

Comments
 (0)