Refine search alert handling: fix search_ids type mismatch, improve shortBio filtering logic, and ensure consistent behavior between notification alerts and alert page display.

Author: MartinBraquet

android/app/build.gradle

@@ -11,7 +11,7 @@ android {
         applicationId "com.compassconnections.app"
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
-        versionCode 149
+        versionCode 150
         versionName "1.37.0"
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         aaptOptions {

backend/api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@compass/api",
-  "version": "1.60.2",
+  "version": "1.60.3",
   "private": true,
   "description": "Backend API endpoints",
   "main": "src/serve.ts",

backend/api/src/get-search-alert.ts

@@ -13,7 +13,8 @@ export const getSearchAlert: APIHandler<'get-search-alert'> = async (props, auth
   const pg = createSupabaseDirectClient()
 
   const send = await pg.oneOrNone<{
-    search_ids: number[]
+    // bigint[] comes back from pg as strings, not numbers.
+    search_ids: string[]
     matched_user_ids: string[]
     created_time: string
   }>(
@@ -33,13 +34,18 @@ export const getSearchAlert: APIHandler<'get-search-alert'> = async (props, auth
       skipId: auth.uid,
       skipCount: true,
       limit: send.matched_user_ids.length,
+      // No filtering here — whether a thin profile belongs in this alert was decided when the alert
+      // was generated, against the search's own toggle. Re-deciding it at read time can only
+      // disagree with what was sent, reporting people as "no longer available" while their profile
+      // is sitting right there.
+      shortBio: true,
     }),
     // A member may have deleted the search since; the alert it produced still stands, it just loses
     // its description.
     pg.manyOrNone<{id: number; search_name: string | null; search_filters: any; location: any}>(
       `select id, search_name, search_filters, location
        from bookmarked_searches
-       where id = any($(searchIds)) and creator_id = $(uid)`,
+       where id = any($(searchIds)::bigint[]) and creator_id = $(uid)`,
       {searchIds: send.search_ids, uid: auth.uid},
     ),
   ])

backend/api/src/send-search-notifications.ts

@@ -52,7 +52,9 @@ const searchProps = (row: SearchRow, userIds: string[]): profileQueryType => {
     ...filters,
     skipId: row.creator_id,
     userId: row.creator_id,
-    shortBio: true,
+    // `shortBio` comes from the search's own "include incomplete profiles" toggle and is deliberately
+    // not overridden: a barely-filled profile is not worth an email unless the member asked to see
+    // those. Forcing it on here also alerted about people the alert page then filtered back out.
     skipCount: true,
     userIds,
   }