Skip to content

Review PR set_contract_storage() #115

Description

@arturoBeccar

Review the PR on set_contract_storage()
use-ink/ink#1961

In particular, review these failing tests:

failures:

---- lazy::mapping::tests::fallible_storage_fails_gracefully_for_overgrown_data stdout ----
thread 'lazy::mapping::tests::fallible_storage_fails_gracefully_for_overgrown_data' panicked at /mnt/dev-disk/OnInk/on-ink_ink_set-contract-storage/crates/env/src/engine/off_chain/impls.rs:202:13:
Value too large to be stored in contract storage, maximum size is 16380 bytes
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- lazy::mapping::tests::fallible_storage_works_for_fitting_data stdout ----
thread 'lazy::mapping::tests::fallible_storage_works_for_fitting_data' panicked at /mnt/dev-disk/OnInk/on-ink_ink_set-contract-storage/crates/env/src/engine/off_chain/impls.rs:202:13:
Value too large to be stored in contract storage, maximum size is 16380 bytes

---- lazy::tests::fallible_storage_works_for_fitting_data stdout ----
thread 'lazy::tests::fallible_storage_works_for_fitting_data' panicked at /mnt/dev-disk/OnInk/on-ink_ink_set-contract-storage/crates/env/src/engine/off_chain/impls.rs:202:13:
Value too large to be stored in contract storage, maximum size is 16380 bytes

---- lazy::tests::fallible_storage_fails_gracefully_for_overgrown_data stdout ----
thread 'lazy::tests::fallible_storage_fails_gracefully_for_overgrown_data' panicked at /mnt/dev-disk/OnInk/on-ink_ink_set-contract-storage/crates/env/src/engine/off_chain/impls.rs:202:13:
Value too large to be stored in contract storage, maximum size is 16380 bytes


failures:
	lazy::mapping::tests::fallible_storage_fails_gracefully_for_overgrown_data
	lazy::mapping::tests::fallible_storage_works_for_fitting_data
	lazy::tests::fallible_storage_fails_gracefully_for_overgrown_data
	lazy::tests::fallible_storage_works_for_fitting_data

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions