From 0861279f45095cf142f9a0d506deb06a6916c111 Mon Sep 17 00:00:00 2001 From: Jaideep Date: Fri, 6 Feb 2026 06:15:11 +0530 Subject: [PATCH] Replace bare except clauses with specific exception handling - Replace bare except clauses in apps/analytics/views.py with specific exception handling (TypeError, ValueError, AttributeError) - Add logging for better debuggability when serialization errors occur - Remove noqa: E722 suppression comments - Follows Python best practices (PEP 8) Fixes #4890 --- apps/analytics/views.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/apps/analytics/views.py b/apps/analytics/views.py index 9d2ffd910c..be668caab2 100644 --- a/apps/analytics/views.py +++ b/apps/analytics/views.py @@ -1,4 +1,5 @@ import csv +import logging from datetime import timedelta from accounts.permissions import HasVerifiedEmail @@ -170,7 +171,11 @@ def get_challenge_phase_submission_count_by_team( ) response_data = serializer.data return Response(response_data, status=status.HTTP_200_OK) - except: # noqa: E722 + except (TypeError, ValueError, AttributeError) as e: + logger = logging.getLogger(__name__) + logger.error( + "Error serializing challenge phase submission count: %s", str(e) + ) response_data = {"error": "Bad request. Please try again later!"} return Response(response_data, status=status.HTTP_400_BAD_REQUEST) @@ -267,7 +272,11 @@ def get_last_submission_datetime_analysis( ) response_data = serializer.data return Response(response_data, status=status.HTTP_200_OK) - except: # noqa: E722 + except (TypeError, ValueError, AttributeError) as e: + logger = logging.getLogger(__name__) + logger.error( + "Error serializing last submission timestamp: %s", str(e) + ) response_data = {"error": "Bad request. Please try again later!"} return Response(response_data, status=status.HTTP_400_BAD_REQUEST)