Commit 3a66cc5
committed
fix(clickhouse): eliminate 4 oracle false positives from 36h run
36h dev-vm run (head 26.7.1.535, 8.67M queries) surfaced 5 reproducers;
4 were oracle false positives with distinct root causes, now fixed:
- TLPHaving: float group-by keys (tan/log) produce NaN, inflating the
UNION-ALL row count. Added a NaN/Infinity guard -> IgnoreMeException,
matching the existing TLPSetOp pattern.
- TextIndexLike: a lightweight DELETE that CH applied but whose execute()
returned false (transient) left the Java ground-truth corpus stale, so
it counted a deleted row (34 vs CH's correct 33 across all arms + a pure
use_skip_indexes=0 scan). Track groundTruthReliable and skip only the
ground-truth assertion when a DELETE's status is uncertain; the CH-vs-CH
cross-arm checks still run.
- JoinGetSet: a transient NoHttpResponseException (server unresponsive
under a squeezed -m cap) killed the worker because the oracle's error
sets lacked transport tolerations. Added getTransportErrors()/
addTransportErrors() and wired them into addSessionSettingsErrors so
every special oracle tolerates connection transients.
- TLPSetOp: SummingMergeTree(c3) leaves non-summed columns ANY-like under
FINAL, so intDiv(c2,c4) over FINAL is not a deterministic function of the
logical content; a merge landing between the baseline and branched reads
flips the multiset. Serial replay confirmed baseline==branched. Added
guardAgainstFinalNonDeterminism() to skip FINAL queries (FINAL stays
covered by FinalMerge/CoalescingFinal/ReplacingDedup).
The 5th (CountOptimization "Not-ready Set ... notIn" LOGICAL_ERROR) is the
known-open upstream bug ClickHouse#107619; it reproduces deterministically
via full-history table replay (not a fresh clone).
Also raise per-oracle validation CH mem to 16g / heap to 12g to fit the
co-located release-radar VM budget.1 parent a62ea50 commit 3a66cc5
5 files changed
Lines changed: 40 additions & 2 deletions
File tree
- .claude
- src/sqlancer/clickhouse
- oracle
- textindex
- tlp
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
142 | 154 | | |
143 | 155 | | |
144 | 156 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
| 157 | + | |
157 | 158 | | |
158 | 159 | | |
159 | 160 | | |
| |||
169 | 170 | | |
170 | 171 | | |
171 | 172 | | |
| 173 | + | |
172 | 174 | | |
173 | 175 | | |
174 | 176 | | |
| |||
215 | 217 | | |
216 | 218 | | |
217 | 219 | | |
218 | | - | |
| 220 | + | |
219 | 221 | | |
220 | 222 | | |
221 | 223 | | |
| |||
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
78 | 82 | | |
79 | 83 | | |
80 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
81 | 98 | | |
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| |||
258 | 259 | | |
259 | 260 | | |
260 | 261 | | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
261 | 268 | | |
262 | 269 | | |
263 | 270 | | |
| |||
0 commit comments