There's currently a ridiculous redundancy in the neighbour.NeighbourLonLatBase class because I stupidly refused to set centreline_id as the index of self.data rather than one of the columns. Since data lookup needs to be done using centreline IDs anyway, it only makes sense to set centreline_id as the index so we can directly refer to values using self.data.loc.
The class and test will have to be refactored, but a lot of the integration testing we're doing from other modules won't be affected.
There's currently a ridiculous redundancy in the
neighbour.NeighbourLonLatBaseclass because I stupidly refused to setcentreline_idas the index ofself.datarather than one of the columns. Since data lookup needs to be done using centreline IDs anyway, it only makes sense to setcentreline_idas the index so we can directly refer to values usingself.data.loc.The class and test will have to be refactored, but a lot of the integration testing we're doing from other modules won't be affected.