Skip to content

Pre execute cannot see the data that will be synced/ignored/conflicts #1

Description

@ChrisVilches

Just populate those arrays before pre-execute hook. Then executeSync simply executes the already populated stuff. ExecuteSync method needs to be divided into populate & execute.

Then execute them in this order.

Populate (itemsToSync, ignored, etc) → pre execute → execute

This is necessary, for example to push files from local disk to Amazon S3 which are tracked by a local DB (file upload is implemented in the pre execute hook, and that needs to know which files to upload.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions