Issue #278 and more

[palexdev]

Hello @ChrisDKN, I saw you answer in #278, but I wanted to tell you more about that issue specifically and something else

Yesterday, because I did not want to risk losing ~1000 mods for my Cyberpunk profile (again), I made Claude take a look at it and it seems to have identified the same problematic path,
(I don't know what your stance on AI is, I'm not fond of vibe coding, but I do recognize the value they bring to the table.)

So, I asked it to fix three things:

1. Issue Amethyst keep on nuking profiles #278
2. Nexus categories not always fetched: I made it add a re-sync metadata button in the context menu and that works, it fetches the category when blank
3. Nexus premium status not always recognized: I did not check what exactly it did here, but I think it now relies on some sort of cache to retrieve the account status. Not sure if I'd have done it the same way. One thing for sure, as I already told you, I think it would be best to query account info at the start of the app. One call to the API is not a big deal and it should save you some headaches.

Another thing, which is also related to 3: I think the app lacks mechanisms to lock the UI when critical operations are occurring. For example, when querying for the premium status (installing a collection) I think the UI should be blocked, waiting for the query to return. If it fails, you can just pop up an error message, unlock the UI and let the user retry.
For number 2 (or update check which is already implemented), there should be some sort of progress tracking, because when you run it on hundreds of mods at one time, you can't tell if it finished and you are free to do anything else or what. Not sure if I'd lock the UI here too, probably yes. It's an easy mechanism to prevent bugs/unexpected interactions.

Attached you can find the three local commits as patches.
0001-Don-t-treat-a-failed-Nexus-validate-as-not-premium-2.patch
0001-Fix-blank-Nexus-category-for-MD5-identified-mods.patch
0001-Never-delete-a-pre-existing-profile-on-collection-in.patch

Anyway, this project has huge potential in my opinion. Keep it up! 🙂

[ChrisDKN]

1. Should already be fixed in the pre release version
2. Was a bug with the md5 lookup not converting the category number to it's actual name, The check updates button and right click option already fetch metadata. I don't use the category column myself so I just didn't notice where it was failing
3. I've never had the premium check fail and the query should be instant, there shouldn't be a need to lock the UI for this

The update check also can't have any progress shown as it's done in batches and everything returns at the same time. So progress would only be arbitrary and wouldn't show anything useful. It needs to be this way as checking updates 1 mod at a time will consume 1 rate limit call per mod and checking only a couple hundred mods would take several minutes