Currently, there is huge config.py that both handles converting legacy config to current config, and validates the config file to fix possible errors.
For the config converter, it is not elegant as we do not have many (or any) active instances on older versions. Also, the config converter may introduce unnecessary/unwanted default values in current config. Thus, the conversion functionality should be moved to a separate setup command such as migrate-config, so it is not executed at every launch.
For the config validator, it is not even validating the entire config, and most validation is introduced along the converter. Thus, the validator should be re-written so that the config is fully validated before launch. It is acceptable to keep the current behaviour of removing/auto-fixing invalid values so that drivers hub can launch, but warnings should be printed when invalid values are detected.
Currently, there is huge
config.pythat both handles converting legacy config to current config, and validates the config file to fix possible errors.For the config converter, it is not elegant as we do not have many (or any) active instances on older versions. Also, the config converter may introduce unnecessary/unwanted default values in current config. Thus, the conversion functionality should be moved to a separate
setupcommand such asmigrate-config, so it is not executed at every launch.For the config validator, it is not even validating the entire config, and most validation is introduced along the converter. Thus, the validator should be re-written so that the config is fully validated before launch. It is acceptable to keep the current behaviour of removing/auto-fixing invalid values so that drivers hub can launch, but warnings should be printed when invalid values are detected.