Skip to content

Review inconsistent runtime defaults and frontend_urls validation #11

Description

@kosmosac

While comparing config_sample.json and docs/config.jsonc with default_config in src/config.py ( see #9 ), I found several inconsistent runtime defaults.

This issue is separate from corrections to the sample configuration files because some of these values affect validation and fallback behavior.

Frontend URLs

default_config currently uses:

"frontend_urls": {
    "member": "https://{domain}/member?userid={userid}",
    "delivery": "https://{domain}/delivery?logid={logid}",
    "email_confirm": "https://{domain}/auth/email?secret={secret}"
}

Both configuration samples use path parameters instead:

"member": "https://{domain}/member/{userid}",
"delivery": "https://{domain}/delivery/{logid}"

The current public frontend also defines /member/:userid and /delivery/:logid routes.

There is also a validation problem: validateConfig() accesses cfg["frontend_urls"] before the final top-level defaults are applied. It only adds a missing email_confirm entry. Missing member and delivery entries are not restored, and a completely missing or invalid frontend_urls object can cause validation to fail before default_config is used.

Economy rental cost

default_config sets:

"truck_rental_cost": 0.01

Both configuration samples use 5000. The economy code subtracts this value as a static amount from the delivery revenue. When the setting is missing or invalid, validateConfig() restores the 0.01 default.

Registration email subject

The default registration email subject contains a typo:

"subject": "Register Acccount"

The sample files use Register Account.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions