From 769747eaa2270cd12c4019c0b8d185e0c627195f Mon Sep 17 00:00:00 2001 From: "Han, Chao" Date: Thu, 22 Jan 2026 15:52:33 +0800 Subject: [PATCH] fix xccl func register --- comms/torchcomms/xccl/TorchCommXCCL.cpp | 5 ----- comms/torchcomms/xccl/TorchCommXCCL.hpp | 2 -- comms/torchcomms/xccl/TorchWorkXCCL.cpp | 4 ---- comms/torchcomms/xccl/TorchWorkXCCL.hpp | 1 - 4 files changed, 12 deletions(-) diff --git a/comms/torchcomms/xccl/TorchCommXCCL.cpp b/comms/torchcomms/xccl/TorchCommXCCL.cpp index d909512916..eaeafa9c77 100644 --- a/comms/torchcomms/xccl/TorchCommXCCL.cpp +++ b/comms/torchcomms/xccl/TorchCommXCCL.cpp @@ -550,11 +550,6 @@ std::shared_ptr TorchCommXCCL::split( "XCCL split is not supported now and will be added later"); } -std::shared_ptr TorchCommXCCL::getMemAllocator() { - throw std::runtime_error( - "XCCL getMemAllocator is not supported now and will be added later"); -} - XCCLException::XCCLException( XcclApi& xccl_api, const std::string& message, diff --git a/comms/torchcomms/xccl/TorchCommXCCL.hpp b/comms/torchcomms/xccl/TorchCommXCCL.hpp index 607e2397a7..4bb0f42222 100644 --- a/comms/torchcomms/xccl/TorchCommXCCL.hpp +++ b/comms/torchcomms/xccl/TorchCommXCCL.hpp @@ -177,8 +177,6 @@ class TorchCommXCCL : public TorchCommBackend, const std::string& name, const CommOptions& options = {}) override; - std::shared_ptr getMemAllocator() override; - // Friend access for TorchCommXCCL friend class TorchWorkXCCL; diff --git a/comms/torchcomms/xccl/TorchWorkXCCL.cpp b/comms/torchcomms/xccl/TorchWorkXCCL.cpp index 6c7401ff4e..a06e45b887 100644 --- a/comms/torchcomms/xccl/TorchWorkXCCL.cpp +++ b/comms/torchcomms/xccl/TorchWorkXCCL.cpp @@ -49,10 +49,6 @@ void TorchWorkXCCL::recordEnd() { "Failed to record end event"); } -bool TorchWorkXCCL::isCompleted() { - return state_ == WorkStatus::COMPLETED; -} - TorchWorkXCCL::WorkStatus TorchWorkXCCL::checkStatus() { // If already marked as completed, return COMPLETED if (state_ == WorkStatus::COMPLETED || state_ == WorkStatus::ERROR || diff --git a/comms/torchcomms/xccl/TorchWorkXCCL.hpp b/comms/torchcomms/xccl/TorchWorkXCCL.hpp index 600505915e..a23d43ea97 100644 --- a/comms/torchcomms/xccl/TorchWorkXCCL.hpp +++ b/comms/torchcomms/xccl/TorchWorkXCCL.hpp @@ -45,7 +45,6 @@ class TorchWorkXCCL : public TorchWork { TorchWorkXCCL& operator=(TorchWorkXCCL&&) = delete; // Override virtual functions from TorchWork - bool isCompleted() override; void wait() override; protected: