Inverter lifetime uses max years

[BenWinchester]

Describe the bug

The inverter lifetime in optimisations and simulations in CLOVER is based on the max_years variable, the purpose of which is for the solar data fetching and which should not be used for other functionality, and hence the inverter replacement intervals are incorrect.

To Reproduce

Steps to reproduce the behavior:

1. Place pdb at line 297 of impact/finance.py on v5.0.7
2. Run CLOVER
3. Check the replacement_intervals variable
4. See error

Expected behaviour

The start and end years of a simulation should be used to determine the inverter replacement periods.

Additional Information

Desktop

• OS: 🏁 but affects 🍎 and 🐧
• Installation setup: git clone
• Version: v5.0.7
• Branch, if relevant: master and all downstream branches

[BenWinchester]

@BenWinchester , check the following:

• Double-check that this bug with the replacement times is, indeed, replacing inverters as expected,
• Decide how to change the functionality for start years that aren't zero.

[BenWinchester]

⬆️ Promotion to issue ⬆️

As this is a 🐛 (bug), an issue will be created from this within the main repo of CLOVER as well as the IAA project so that it can be addressed sooner rather than later 😄